Re: [Patch v2] drivers: staging : wlan-ng : collect return status without variable

On Sat, May 11, 2019 at 03:18:59PM +0530, Hariprasad Kelam wrote: > As caller rdev_set_default_key not particular about -EFAULT. > We can preserve the return value of prism2_domibset_uint32. > > Signed-off-by: Hariprasad Kelam > - > Changes in v2: > - remove masking of original return val

[PATCH] staging: wlan-ng: fix adapter initialization failure

Commit e895f00a8496 ("Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.") moved the retrieval of the transfer buffer from the URB from the top of function hfa384x_usbin_callback to a point after reposting of the URB via a call to submit_rx_urb. The reposting of the URB allocates a

[PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

From: Colin Ian King The variable ret is being initialized however this is never read and later it is being reassigned to a new value. The initialization is redundant and hence can be removed. Addresses-Coverity: ("Unused Value") Signed-off-by: Colin Ian King --- drivers/staging/vc04_services/

[Patch v2] drivers: staging : wlan-ng : collect return status without variable

As caller rdev_set_default_key not particular about -EFAULT. We can preserve the return value of prism2_domibset_uint32. Signed-off-by: Hariprasad Kelam - Changes in v2: - remove masking of original return value with EFAULT --- drivers/staging/wlan-ng/cfg80211.c | 9 +++-- 1 file cha

Re: [PATCH] staging: wlan-ng: collect return status without variable

On Fri, May 10, 2019 at 09:40:11PM +0300, Dan Carpenter wrote: > On Fri, May 10, 2019 at 10:53:08PM +0530, Hariprasad Kelam wrote: > > On Fri, May 10, 2019 at 01:57:54PM +0300, Dan Carpenter wrote: > > > On Fri, May 10, 2019 at 08:09:00AM +0530, Hariprasad Kelam wrote: > > > > diff --git a/drivers/