[PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

From: Yue Hu Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode(). Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Reviewed-by: Chao Yu --- no change drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 d

Re: [PATCH v3] Staging: most: fix coding style issues

://github.com/0day-ci/linux/commits/Gabriel-Beauchamp/Staging-most-fix-coding-style-issues/20190701-203804 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__

Re: [PATCH v2 3/3] staging: comedi: mite: Replace function mite_request_channel_in_range()

On 01/07/2019 08:00, Nishka Dasgupta wrote: Remove function mite_request_channel_in_range as all it does is call __mite_request_channel. Rename __mite_request_channel to mite_request_channel_in_range and change its type from static to non-static to maintain compatibility with call sites. Change o

Re: [PATCH v2 2/3] staging: comedi: amplc_dio200: Remove function gat_sce()

On 01/07/2019 08:00, Nishka Dasgupta wrote: Remove function gat_sce as all it does is call clk_gat_sce. Modify call sites of the former to call the latter directly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Edit subject line to include driver name. driv

Re: [PATCH v2 1/3] staging: comedi: amplc_dio200: Remove function clk_sce()

On 01/07/2019 08:00, Nishka Dasgupta wrote: Remove function clk_sce as all it does is call clk_gat_sce. Modify call site of clk_sce to call clk_gat_sce instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Edit subject line to include driver name. drivers/

[PATCH] staging: kpc2000: drop useless softdep statement

The i2c-dev module is for access to I2C buses from user-space. Kernel drivers do not care about its presence. Signed-off-by: Jean Delvare Cc: Matt Sickler Cc: Greg Kroah-Hartman --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c |1 - 1 file changed, 1 deletion(-) --- linux-5.2-rc7.orig/dri

[PATCH] staging: most: remove data sanity check

This patch removes the data check in the set_cfg_* functions, because the modules infacing the hardware (usb, i2c, ...) already have it. Signed-off-by: Christian Gromm --- drivers/staging/most/configfs.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/most/conf

Re: [PATCH v3] Staging: most: fix coding style issues

://github.com/0day-ci/linux/commits/Gabriel-Beauchamp/Staging-most-fix-coding-style-issues/20190701-203804 config: i386-randconfig-x074-201926 (attached as .config) compiler: gcc-7 (Debian 7.4.0-9) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix

[PATCH v5 0/3] [v4.9.y] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping

coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping [PATCH v5 1/3]: Backporting of commit 04f5866e41fb70690e28397487d8bd8eea7d712a upstream. [PATCH v5 2/3]: Extension of commit 04f5866e41fb to fix the race condition between get_task_mm() and core dumping for IB->m

[PATCH v5 2/3][v4.9.y] infiniband: fix race condition between infiniband mlx4, mlx5 driver and core dumping

This patch is the extension of following upstream commit to fix the race condition between get_task_mm() and core dumping for IB->mlx4 and IB->mlx5 drivers: commit 04f5866e41fb ("coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping")' Thanks to Jason for pointing t

[PATCH v5 3/3] [v4.9.y] coredump: fix race condition between collapse_huge_page() and core dumping

From: Andrea Arcangeli coredump: fix race condition between collapse_huge_page() and core dumping commit 59ea6d06cfa9247b586a695c21f94afa7183af74 upstream. When fixing the race conditions between the coredump and the mmap_sem holders outside the context of the process, we focused on mmget_not_z

[PATCH v5 1/3] [v4.9.y] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping

From: Andrea Arcangeli commit 04f5866e41fb70690e28397487d8bd8eea7d712a upstream. The core dumping code has always run without holding the mmap_sem for writing, despite that is the only way to ensure that the entire vma layout will not change from under it. Only using some signal serialization o

Re: [PATCH] media: imx7-media-csi: Remove unneeded break after return

Hi Chinmaya, Thanks for your patch. On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: break is not useful after a goto or return but this is already fixed in the media subsystem tree, by a patch from Fabio: 964fcacddf media: i

[PATCH 07/10] staging: rtl8723bs: Remove rtw_btcoex_SetBTCoexist()

Remove function rtw_btcoex_SetBTCoexist as it does nothing except call hal_btcoex_SetBTCoexist. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 - drivers/staging/rtl8723bs/hal/rtl8723b_hal_i

[PATCH 06/10] staging: rtl8723bs: Remove rtw_btcoex_IsBtDisabled()

Remove function rtw_btcoex_IsBtDisabled as it does nothing except call hal_btcoex_IsBtDisabled. Modify call sites accordingly. Issue found wth Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_mlme.c |

[PATCH 05/10] staging: rtl8723bs: Remove rtw_btcoex_IsBtControlLps()

Remove function rtw_btcoex_IsBtControlLps as it does nothing except call hal_btcoex_IsBtControlLps. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 - drivers/staging/rtl8723bs/core/rtw_cmd.c

[PATCH 08/10] staging: rtl8723bs: Remove rtw_btcoex_ConnectNotify()

Remove function rtw_btcoex_ConnectNotify as all it does is call hal_btcoex_ConnectNotify. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 - drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

[PATCH 09/10] staging: rtl8723bs: Remove rtw_btcoex_SetChipType()

Remove function rtw_btcoex_SetChipType as it does nothing but call hal_btcoex_SetChipType. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 - drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

[PATCH v2] staging: kpc2000: fix brace issues in kpc2000_spi.c

Fixes issues found by checkpatch: - "WARNING: braces {} are not necessary for single statement blocks" - "WARNING: braces {} are not necessary for any arm of this statement" Signed-off-by: Simon Sandström --- Changed in v2: rebased. drivers/staging/kpc2000/kpc2000_spi.c | 33 ++---

[PATCH 04/10] staging: rtl8723bs: Remove rtw_btcoex_Handler()

Remove function rtw_btcoex_Handler as it does nothing except call hal_btcoex_Handler. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- dri

[PATCH 03/10] staging: rtl8723bs: Remove rtw_btcoex_LpsVal()

Remove function rtw_btcoex_LpsVal as all it does is call hal_btcoex_LpsVal. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 7 +-- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 8 driv

[PATCH 02/10] staging: rtl8723bs: Remove rtw_btcoex_RecordPwrMode()

Remove function rtw_btcoex_RecordPwrMode as all it does is call hal_btcoex_RecordPwrMode. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-

[PATCH 10/10] staging: rtl8723bs: Remove rtw_btcoex_GetRaMask()

Remove function rtw_btcoex_GetRaMask as all it does is call hal_btcoex_GetRaMask. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 - drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- d

[PATCH 01/10] staging: rtl8723bs: Remove rtw_btcoex_RpwmVal()

Remove function rtw_btcoex_RpwmVal as all it does is call hal_btcoex_RpwmVal. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +- drivers/st

[PATCH v2] staging: rtl8192u: Replace function rtl8192_rx_enable()

Remove function rtl8192_rx_enable as all it does is call rtl8192_rx_initiate. Rename rtl8192_rx_initiate to rtl8192_rx_enable and change its type from static to non-static to maintain compatibility with call sites of rtl8192_rx_enable. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta -

Re: [PATCH] staging: rtl8192u: Replace function rtl8192_rx_enable()

On Mon, Jul 01, 2019 at 11:49:02AM +0530, Nishka Dasgupta wrote: > Remove function rtl8192_rx_enable as all it does is call > rtl8192_rx_initiate. > Rename rtl8192_rx_initiate to rtl8192_rx_enable and change its type from > static to non-static to maintain compatibility with call sites of > rtl8192

Re: use exact allocation for dma coherent memory

On Fri, Jun 14, 2019 at 03:47:10PM +0200, Christoph Hellwig wrote: > Switching to a slightly cleaned up alloc_pages_exact is pretty easy, > but it turns out that because we didn't filter valid gfp_t flags > on the DMA allocator, a bunch of drivers were passing __GFP_COMP > to it, which is rather bo

Re: [PATCH 1/2] staging:kpc2000:Fix symbol not declared warning

On Fri, Jun 28, 2019 at 10:57:23PM +0530, Harsh Jain wrote: > It fixes "symbol was not declared. Should it be static?" > sparse warning. > > Signed-off-by: Harsh Jain > --- > drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- This file isn't even in the linux-next tree at all, it has moved w

Re: [PATCH] staging: kpc2000: fix brace issues in kpc2000_spi.c

On Thu, Jun 27, 2019 at 09:53:23PM +0200, Simon Sandström wrote: > Fixes issues found by checkpatch: > > - "WARNING: braces {} are not necessary for single statement blocks" > - "WARNING: braces {} are not necessary for any arm of this statement" > > Signed-off-by: Simon Sandström > --- > drive

Re: [PATCH 1/8] staging: kpc2000: add line breaks

On Wed, Jun 26, 2019 at 09:35:19AM +0200, Fabian Krueger wrote: > To fix some checkpatch-warnings some lines of this module had to be > shortened so that they do not exceed 80 characters per line. > This refactoring makes the code more readable. > > Signed-off-by: Fabian Krueger > Signed-off-by:

[PATCH v3 1/2] drivers/staging/rtl8192u: drop first comment line

As stated in coding-styles.rst multiline comments should be structured in a way, that the actual comment starts on the second line of the commented portion. E.g: /* * Multiline comments * should look like * this. */ However, there is an exception to files in drivers/net/ and net/, where multi

[PATCH v3 2/2] drivers/staging/rtl8192u: style nonstyled comments

The coding-styles.rst states, that multiline comments should allways contain a leading "*" in each line. For multiline comments in general they /* * should look * like this. */ For multiline comments in either net/ or drivers/net/ however, they should /* omit * the first * empty line. */

[PATCH 08/10] staging: rtl8723bs: Remove rtw_btcoex_SetManualControl()

Remove function rtw_btcoex_SetManualControl as all it does is call hal_btcoex_SetManualControl. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/include/rtw_btcoex.h

Re: [PATCH 1/3] staging: comedi: Remove function clk_sce()

On Wed, Jun 26, 2019 at 12:24:02PM +0530, Nishka Dasgupta wrote: > Remove function clk_sce as all it does is call clk_gat_sce. > Modify call site of clk_sce to call clk_gat_sce instead. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/comedi/drivers/amplc

Re: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

On Sat, Jun 29, 2019 at 03:49:09PM +0530, Hariprasad Kelam wrote: > fix below issues reported by checkpatch > > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/hal/hal_intf.c |

[PATCH 09/10] staging: rtl8723bs: Remove rtw_btcoex_SuspendNotify()

Remove function rtw_btcoex_SuspendNotify as all it does is call hal_btcoex_SuspendNotify. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/include/rtw_btcoex.h | 1 -

Re: [PATCH v2] Staging: most: fix coding style issues

On Sun, Jun 30, 2019 at 08:27:26AM -0700, Gabriel Beauchamp wrote: > This is a patch for the core.[ch] files that fixes up warnings > found with the checkpatch.pl tool. > > Signed-off-by: Gabriel Beauchamp Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that

[PATCH v2 3/3] staging: comedi: mite: Replace function mite_request_channel_in_range()

Remove function mite_request_channel_in_range as all it does is call __mite_request_channel. Rename __mite_request_channel to mite_request_channel_in_range and change its type from static to non-static to maintain compatibility with call sites. Change only remaining call site of __mite_request_chan

[PATCH 07/10] staging: rtl8723bs: Remove rtw_btcoex_SpecialPacketNotify()

Remove function rtw_btcoex_SpecialPacketNotify as all it does is call hal_btcoex_SpecialPacketNotify. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_cmd.c

[PATCH 02/10] staging: rtl8723bs: Remove rtw_btcoex_PowerOnSetting()

Remove function rtw_btcoex_PowerOnSetting as all it does is call hal_btcoex_PowerOnSetting. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2

[PATCH v2 2/3] staging: comedi: amplc_dio200: Remove function gat_sce()

Remove function gat_sce as all it does is call clk_gat_sce. Modify call sites of the former to call the latter directly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Edit subject line to include driver name. drivers/staging/comedi/drivers/amplc_dio200_common.

[PATCH 10/10] staging: rtl8723bs: Remove rtw_btcoex_IsLpsOn()

Remove function rtw_btcoex_IsLpsOn as all it does is call hal_btcoex_IsLpsOn. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- drivers/

[PATCH 05/10] staging: rtl8723bs: Remove rtw_btcoex_IpsNotify()

Remove function rtw_btcoex_IpsNotify as all it does is call hal_btcoex_IpsNotify. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- driv

[PATCH 04/10] staging: rtl8723bs: Remove rtw_btcoex_IQKNotify()

Remove function rtw_btcoex_IQKNotify as all it does is call hal_btcoex_IQKNotify. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ++-- driv

[PATCH 06/10] staging: rtl8723bs: Remove rtw_btcoex_LpsNotify()

Remove function rtw_btcoex_LpsNotify as all it does is call hal_btcoex_LpsNotify. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- driv

[PATCH 03/10] staging: rtl8723bs: Remove rtw_btcoex_HAL_Initialize()

Remove function rtw_btcoex_HAL_Initialize as it does nothing except call hal_btcoex_InitHwConfig. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/hal/sdio_halinit.c

[PATCH v2 1/3] staging: comedi: amplc_dio200: Remove function clk_sce()

Remove function clk_sce as all it does is call clk_gat_sce. Modify call site of clk_sce to call clk_gat_sce instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Edit subject line to include driver name. drivers/staging/comedi/drivers/amplc_dio200_common.c |