Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

On Sun, Aug 18, 2019 at 01:47:38AM -0400, Donald Yandt wrote: > On Sun, Aug 18, 2019 at 1:03 AM Greg KH wrote: > > > > On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > > > This patch removes the todo for the ion chunk and > > > carveout device tree bindings. > > > > > > Signed-off-b

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Am 18.08.19 um 04:29 schrieb Chuanhong Guo: > Hi! > > On Sun, Aug 18, 2019 at 2:06 AM Oleksij Rempel wrote: SYSC_REG_CPLL_CLKCFG1 register is a clock gate controller. It is used to enable or disable clocks. Jist wild assumption. All peripheral devices are suing bus clock. >>> >>> T

Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

On Sun, Aug 18, 2019 at 1:03 AM Greg KH wrote: > > On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > > This patch removes the todo for the ion chunk and > > carveout device tree bindings. > > > > Signed-off-by: Donald Yandt > > --- > > drivers/staging/android/TODO | 2 -- > > 1 fil

Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > This patch removes the todo for the ion chunk and > carveout device tree bindings. > > Signed-off-by: Donald Yandt > --- > drivers/staging/android/TODO | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/andro

[PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()

From: Gao Xiang Richard observed a forever loop of erofs_read_raw_page() [1] which can be generated by forcely setting ->u.i_blkaddr to 0xdeadbeef (as my understanding block layer can handle access beyond end of device correctly). After digging into that, it seems the problem is highly related w

[PATCH] staging: erofs: fix an error handling in erofs_readdir()

From: Gao Xiang Richard observed a forever loop of erofs_read_raw_page() [1] which can be generated by forcely setting ->u.i_blkaddr to 0xdeadbeef (as my understanding block layer can handle access beyond end of device correctly). After digging into that, it seems the problem is highly related w

Re: [PATCH v2] staging: erofs: fix an error handling in erofs_readdir()

On Sat, Aug 17, 2019 at 07:53:39PM -0700, Matthew Wilcox wrote: > On Sun, Aug 18, 2019 at 10:32:45AM +0800, Gao Xiang wrote: > > On Sat, Aug 17, 2019 at 07:20:55PM -0700, Matthew Wilcox wrote: > > > On Sun, Aug 18, 2019 at 09:56:31AM +0800, Gao Xiang wrote: > > > > @@ -82,8 +82,12 @@ static int ero

Re: [PATCH v2] staging: erofs: fix an error handling in erofs_readdir()

On Sun, Aug 18, 2019 at 10:32:45AM +0800, Gao Xiang wrote: > On Sat, Aug 17, 2019 at 07:20:55PM -0700, Matthew Wilcox wrote: > > On Sun, Aug 18, 2019 at 09:56:31AM +0800, Gao Xiang wrote: > > > @@ -82,8 +82,12 @@ static int erofs_readdir(struct file *f, struct > > > dir_context *ctx) > > >

Re: [PATCH v2] staging: erofs: fix an error handling in erofs_readdir()

Hi Willy, On Sat, Aug 17, 2019 at 07:20:55PM -0700, Matthew Wilcox wrote: > On Sun, Aug 18, 2019 at 09:56:31AM +0800, Gao Xiang wrote: > > @@ -82,8 +82,12 @@ static int erofs_readdir(struct file *f, struct > > dir_context *ctx) > > unsigned int nameoff, maxsize; > > > >

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Hi! On Sun, Aug 18, 2019 at 2:06 AM Oleksij Rempel wrote: > >> SYSC_REG_CPLL_CLKCFG1 register is a clock gate controller. It is used to > >> enable or disable clocks. > >> Jist wild assumption. All peripheral devices are suing bus clock. > > > > This assumption is incorrect. When this patchset i

Re: [PATCH v2] staging: erofs: fix an error handling in erofs_readdir()

On Sun, Aug 18, 2019 at 09:56:31AM +0800, Gao Xiang wrote: > @@ -82,8 +82,12 @@ static int erofs_readdir(struct file *f, struct > dir_context *ctx) > unsigned int nameoff, maxsize; > > dentry_page = read_mapping_page(mapping, i, NULL); > - if (IS_ERR(dentr

[PATCH v2] staging: erofs: fix an error handling in erofs_readdir()

From: Gao Xiang Richard observed a forever loop of erofs_read_raw_page() [1] which can be generated by forcely setting ->u.i_blkaddr to 0xdeadbeef (as my understanding block layer can handle access beyond end of device correctly). After digging into that, it seems the problem is highly related w

[PATCH] staging: erofs: fix an error handling in erofs_readdir()

From: Gao Xiang Richard observed a forever loop of erofs_read_raw_page() [1] which can be generated by forcely setting ->u.i_blkaddr to 0xdeadbeef (as my understanding block layer can handle access beyond end of device correctly). After digging into that, it seems the problem is highly related w

Re: [PATCH] erofs: move erofs out of staging

On Sun, Aug 18, 2019 at 08:04:11AM +0800, Gao Xiang wrote: > On Sun, Aug 18, 2019 at 07:38:47AM +0800, Gao Xiang wrote: > > Hi Richard, > > > > On Sun, Aug 18, 2019 at 01:25:58AM +0200, Richard Weinberger wrote: > > [] > > > > > > > While digging a little into the code I noticed that you have v

Re: [PATCH] erofs: move erofs out of staging

On Sun, Aug 18, 2019 at 07:38:47AM +0800, Gao Xiang wrote: > Hi Richard, > > On Sun, Aug 18, 2019 at 01:25:58AM +0200, Richard Weinberger wrote: [] > > > > While digging a little into the code I noticed that you have very few > > checks of the on-disk data. > > For example ->u.i_blkaddr. I gave

Re: [PATCH] erofs: move erofs out of staging

Hi Richard, On Sun, Aug 18, 2019 at 01:25:58AM +0200, Richard Weinberger wrote: > - Urspr?ngliche Mail - > >> How does erofs compare to squashfs? > >> IIUC it is designed to be faster. Do you have numbers? > >> Feel free to point me older mails if you already showed numbers, > >> I have to

Re: [PATCH] erofs: move erofs out of staging

- Ursprüngliche Mail - >> How does erofs compare to squashfs? >> IIUC it is designed to be faster. Do you have numbers? >> Feel free to point me older mails if you already showed numbers, >> I have to admit I didn't follow the development very closely. > > You can see the following related

Re: [PATCH] erofs: move erofs out of staging

Hi Richard, On Sat, Aug 17, 2019 at 11:19:50PM +0200, Richard Weinberger wrote: > - Urspr?ngliche Mail - > > Von: "Gao Xiang" > > An: "Greg Kroah-Hartman" , "Al Viro" > > , "linux-fsdevel" > > , de...@driverdev.osuosl.org, > > linux-er...@lists.ozlabs.org, "linux-kernel" > > > > CC: "A

[PATCH] staging: android: Remove ion device tree bindings from the TODO

This patch removes the todo for the ion chunk and carveout device tree bindings. Signed-off-by: Donald Yandt --- drivers/staging/android/TODO | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index fbf015cc6..767dd98fd 100644 --- a/d

Re: [PATCH] erofs: move erofs out of staging

- Ursprüngliche Mail - > Von: "Gao Xiang" > An: "Greg Kroah-Hartman" , "Al Viro" > , "linux-fsdevel" > , de...@driverdev.osuosl.org, > linux-er...@lists.ozlabs.org, "linux-kernel" > > CC: "Andrew Morton" , "Stephen Rothwell" > , "tytso" , > "Pavel Machek" , "David Sterba" , "Amir > Go

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Am 17.08.19 um 18:22 schrieb Chuanhong Guo: > Hi! > > On Sat, Aug 17, 2019 at 11:40 PM Oleksij Rempel wrote: > >> In provided link [0] the ralink_clk_init function is reading >> SYSC_REG_CPLL_CLKCFG0 R/W register. >> This register is used to determine clock source, clock freq and CPU or bus >>

Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

/commits/Matthew-Hanzelik/Staging-speakup-spk_types-fixed-an-unnamed-parameter-style-issue/20190817-235230 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-10) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Hi! On Sat, Aug 17, 2019 at 11:40 PM Oleksij Rempel wrote: > In provided link [0] the ralink_clk_init function is reading > SYSC_REG_CPLL_CLKCFG0 R/W register. > This register is used to determine clock source, clock freq and CPU or bus > clocks. This register should only be changed by boot

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Hi, Am 17.08.19 um 16:42 schrieb Chuanhong Guo: Hi! On Tue, Aug 13, 2019 at 11:51 PM Rob Herring wrote: [...] +Example: + pll { + compatible = "mediatek,mt7621-pll"; You didn't answer Stephen's question on v1. I thought he was asking why there's a syscon in compatible str

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Hi, Am 17.08.19 um 16:42 schrieb Chuanhong Guo: Hi! On Tue, Aug 13, 2019 at 11:51 PM Rob Herring wrote: [...] +Example: + pll { + compatible = "mediatek,mt7621-pll"; You didn't answer Stephen's question on v1. I thought he was asking why there's a syscon in compatible str

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

Hi! On Tue, Aug 13, 2019 at 11:51 PM Rob Herring wrote: > [...] > > +Example: > > + pll { > > + compatible = "mediatek,mt7621-pll"; > > You didn't answer Stephen's question on v1. I thought he was asking why there's a syscon in compatible string. I noticed that the syscon in my p

[PATCH] erofs: move erofs out of staging

EROFS filesystem has been merged into linux-staging for a year. EROFS is designed to be a better solution of saving extra storage space with guaranteed end-to-end performance for read-only files with the help of reduced metadata, fixed-sized output compression and decompression inplace technologie

Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

On Sat, Aug 17, 2019 at 02:54:26AM -0400, Matthew Hanzelik wrote: > Fixed an unnamed parameter style issue. > > Signed-off-by: Matthew Hanzelik > --- > drivers/staging/speakup/spk_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/spk_types.