Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-19 Thread Joe Perches
On Sat, 2019-10-19 at 21:05 +0300, Dan Carpenter wrote: > On Sat, Oct 19, 2019 at 04:09:03PM +0100, Jules Irenge wrote: > > Checkpatch was complaining about space between type cast and the > > variable. I just get rid of the space. Well I don't know whether this was > > false positive one. > >

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-19 Thread Dan Carpenter
On Sat, Oct 19, 2019 at 04:09:03PM +0100, Jules Irenge wrote: > Checkpatch was complaining about space between type cast and the > variable. I just get rid of the space. Well I don't know whether this was > false positive one. > > Thanks for the feedback. I will update the patch. No no. The p

Re: [Outreachy kernel] Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-19 Thread Julia Lawall
On Sat, 19 Oct 2019, Jules Irenge wrote: > > > On Sat, 19 Oct 2019, Dan Carpenter wrote: > > > On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote: > > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > > > index 3355183fc86c..573216b08042 100644 > > > --- a/drivers/s

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-19 Thread Jules Irenge
On Sat, 19 Oct 2019, Dan Carpenter wrote: > On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote: > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > > index 3355183fc86c..573216b08042 100644 > > --- a/drivers/staging/wfx/bh.c > > +++ b/drivers/staging/wfx/bh.c > > @@

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-19 Thread Dan Carpenter
On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote: > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > index 3355183fc86c..573216b08042 100644 > --- a/drivers/staging/wfx/bh.c > +++ b/drivers/staging/wfx/bh.c > @@ -69,13 +69,13 @@ static int rx_helper(struct wfx_dev *wde

[PATCH v1 3/5] staging: wfx: fix warnings of logical continuation

2019-10-19 Thread Jules Irenge
Fix check warnings of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/data_rx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wfx/data_rx.c b/drivers/

[PATCH v1 0/5] staging: wfx: fix checkpatch warnings

2019-10-19 Thread Jules Irenge
Fix checkpatch warnings. Jules Irenge (5): staging: wfx: fix warnings of no space is necessary staging: wfx: fix warning of line over 80 characters staging: wfx: fix warnings of logical continuation staging: wfx: correct misspelled words staging: wfx: fix warnings of alignment should mat

[PATCH v1 5/5] staging: wfx: fix warnings of alignment should match open parenthesis

2019-10-19 Thread Jules Irenge
: Fix warnings of alignment should match open parenthesis. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_tx.c | 2 +- drivers/staging/wfx/debug.c | 14 -- 3 files changed, 10 insertions(+), 8 dele

[PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-19 Thread Jules Irenge
Fix warnings of no space is necessary after a cast. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/bh.c | 8 drivers/staging/wfx/bus_sdio.c | 6 +++--- drivers/staging/wfx/bus_spi.c | 2 +- drivers/staging/wfx/data_rx.c | 8 d

[PATCH v1 4/5] staging: wfx: correct misspelled words

2019-10-19 Thread Jules Irenge
Correct misspelled words: retrieved and auxiliary. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/data_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 619ab2ca

[PATCH v1 2/5] staging: wfx: fix warning of line over 80 characters

2019-10-19 Thread Jules Irenge
Fix warning of lines over 80 characters. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/bh.c | 17 -- drivers/staging/wfx/bus.h | 6 +- drivers/staging/wfx/bus_sdio.c | 3 +- drivers/staging/wfx/bus_spi.c | 9 ++- drivers/staging/wfx

Re: [PATCH 2/3] binder: Prevent repeated use of ->mmap() via NULL mapping

2019-10-19 Thread Christian Brauner
On Fri Oct 18, 2019 at 10:56 PM Jann Horn wrote: > binder_alloc_mmap_handler() attempts to detect the use of ->mmap() on a > binder_proc whose binder_alloc has already been initialized by checking > whether alloc->buffer is non-zero. > > Before commit 880211667b20 ("binder: remove kernel vm_area f

Re: [PATCH 3/3] binder: Handle start==NULL in binder_update_page_range()

2019-10-19 Thread Christian Brauner
On Fri Oct 18, 2019 at 10:56 PM Jann Horn wrote: > The old loop wouldn't stop when reaching `start` if `start==NULL`, instead > continuing backwards to index -1 and crashing. > > Luckily you need to be highly privileged to map things at NULL, so it's not > a big problem. > > Fix it by adjusting t

Re: [PATCH 3/3] binder: Handle start==NULL in binder_update_page_range()

2019-10-19 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 457b9a6f09f01 Staging: android: add binder driver. The bot has tested the following trees: v5.3.6, v4.19.79, v4.14.149, v4.9.196, v4.4.196. v5.3.6: Build OK! v4.19.79: Build OK! v

Re: [PATCH 1/3] binder: Fix race between mmap() and binder_alloc_print_pages()

2019-10-19 Thread Christian Brauner
On Fri Oct 18, 2019 at 10:56 PM Jann Horn wrote: > binder_alloc_print_pages() iterates over > alloc->pages[0..alloc->buffer_size-1] under alloc->mutex. > binder_alloc_mmap_handler() writes alloc->pages and alloc->buffer_size > without holding that lock, and even writes them before the last bailout