Re: [Outreachy kernel] [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h,c}

2019-10-30 Thread Julia Lawall
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Avoid CamelCase" in files ms.{h,c} I think that these should be converted to all upper case rather than all lower case. julia > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/rts5208/ms.c | 86 ++

Re: [Outreachy kernel] [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c}

2019-10-30 Thread Julia Lawall
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Avoid CamelCase" in files xd.{h,c} > > Signed-off-by: Gabriela Bittencourt Acked-by: Julia Lawall > --- > drivers/staging/rts5208/xd.c | 8 > drivers/staging/rts5208/xd.h | 6 +++--- > 2 files changed, 7 inse

Re: [Outreachy kernel] [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h

2019-10-30 Thread Julia Lawall
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Avoid CamelCase" in file sd.h > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/rts5208/sd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rts5208/sd.h b/drivers/st

Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody

2019-10-30 Thread Valdis Klētnieks
On Wed, 30 Oct 2019 20:04:49 -0700, "Darrick J. Wong" said: > I would add (d) can we do the same to EFSBADCRC, seeing as f2fs, > ext4, xfs, and jbd2 all define it the same way? If this one flies, that's a good candidate for a second patch pgpCNp_PdIQvD.pgp Description: PGP signature ___

Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody

2019-10-30 Thread Darrick J. Wong
On Wed, Oct 30, 2019 at 09:07:33PM -0400, Valdis Kletnieks wrote: > Three questions: (a) ACK/NAK on this patch, Acked-by: Darrick J. Wong > (b) should it be all in one patch, or one to add to errno.h and 6 > patches for 6 filesystems?), and I don't particularly care, but I've a slight preferenc

[RFC] errno.h: Provide EFSCORRUPTED for everybody

2019-10-30 Thread Valdis Kletnieks
Three questions: (a) ACK/NAK on this patch, (b) should it be all in one patch, or one to add to errno.h and 6 patches for 6 filesystems?), and (c) if one patch, who gets to shepherd it through? There's currently 6 filesystems that have the same #define. Move it into errno.h so it's defined in jus

[PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h, c}

2019-10-30 Thread Gabriela Bittencourt
Cleans up checks of "Avoid CamelCase" in files ms.{h,c} Signed-off-by: Gabriela Bittencourt --- drivers/staging/rts5208/ms.c | 86 ++-- drivers/staging/rts5208/ms.h | 70 ++--- 2 files changed, 78 insertions(+), 78 deletions(-) diff --git

[PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h, c}

2019-10-30 Thread Gabriela Bittencourt
Cleans up checks of "Avoid CamelCase" in files xd.{h,c} Signed-off-by: Gabriela Bittencourt --- drivers/staging/rts5208/xd.c | 8 drivers/staging/rts5208/xd.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts520

[PATCH v3 0/3] staging: rts5208: Eliminate the use of Camel Case

2019-10-30 Thread Gabriela Bittencourt
Cleans up checks of "Avoid CamelCase" in tree rts5208 Changes in v3: - Change the subject line of commits to make it more clear and informative Changes in v2: - Place the changes on variable's names in the use and definition in the same commit I compile the kernel after each commit of the series

[PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h

2019-10-30 Thread Gabriela Bittencourt
Cleans up checks of "Avoid CamelCase" in file sd.h Signed-off-by: Gabriela Bittencourt --- drivers/staging/rts5208/sd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h index dc9e8cad7a74..f4ff62653b56 100644 --- a/dr

Re: [PATCH 6/6] staging: exfat: replace kmalloc with kmalloc_array

2019-10-30 Thread Greg KH
On Wed, Oct 30, 2019 at 02:03:28AM +0100, Roi Martin wrote: > Replace expressions of the form: > kmalloc(count * size, GFP_KERNEL); > With: > kmalloc_array(count, size, GFP_KERNEL); > > Signed-off-by: Roi Martin > --- > drivers/staging/exfat/exfat_core.c | 8 > 1 file change

Re: [PATCH v2 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms

2019-10-30 Thread Greg KH
On Tue, Oct 29, 2019 at 11:55:15AM -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Avoid CamelCase" in file ms.h and ms.c > > Signed-off-by: Gabriela Bittencourt The subject line seems odd, what does "in files ms" mean? Same for other patches in this series, please clean that up to ma