allmodconfig
powerpc allnoconfig
i386 randconfig-a006-20200515
i386 randconfig-a005-20200515
i386 randconfig-a003-20200515
i386 randconfig-a001-20200515
i386 randconfig-a004-20200515
i386
ig
powerpc rhel-kconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a006-20200515
i386 randconfig-a005-20200515
i386 randconfig-a003-20200515
i386 randconfig-a001-202
ig
powerpc allyesconfig
powerpc rhel-kconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a006-20200515
i386 randconfig-a005-20200515
i386 randconfig-a003-202
fix below issue reported by checkpatch
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
Signed-off-by: John Oldman
---
drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/st
Coding style issues:
This patch clears the checkpatch.pl "braces {} are not necessary for
single statement blocks" and "else_should_follow_close_brace"
warnings.
Signed-off-by: John Oldman
---
v1: First attempt
v2: Followed The rule is that "if one side of the if else statement
has curly braces t
Coding style issues:
This patch clears the checkpatch.pl "braces {} are not necessary for
single statement blocks" and "else_should_follow_close_brace"
warnings.
Signed-off-by: John Oldman
---
v1: First attempt
v2: Followed The rule is that "if one side of the if else statement
has curly braces t
On Fri, May 15, 2020 at 05:03:40PM +0200, Jérôme Pouiller wrote:
> On Friday 15 May 2020 15:53:59 CEST Greg Kroah-Hartman wrote:
> > On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote:
> > > From: Jérôme Pouiller
> > >
> > > The function hif_scan() return the timeout for the completio
On Friday 15 May 2020 15:53:59 CEST Greg Kroah-Hartman wrote:
> On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > The function hif_scan() return the timeout for the completion of the
> > scan request. It is the only function from hif_tx.c that retur
On Fri, May 15, 2020 at 03:48:59PM +0200, Greg Kroah-Hartman wrote:
I still fail to understand the need for this patch at all. It doesn't
clean anything up, nor change anything. There is no rule that this has
to be in one order or the other, and in fact, I like the order that the
files currentl
On Fri, May 15, 2020 at 03:53:59PM +0200, Greg Kroah-Hartman wrote:
> On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > The function hif_scan() return the timeout for the completion of the
> > scan request. It is the only function from hif_tx.c tha
On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> The function hif_scan() return the timeout for the completion of the
> scan request. It is the only function from hif_tx.c that return another
> thing than just an error code. This behavior is not coheren
On Wed, May 13, 2020 at 09:15:51PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put
> obj-$(CONFIG_X) at the beginning of the file. This order of variables is
> used in other drives, so this will make vt665x Makefiles fit into the
> pattern.
>
> Indentatio
On Thu, May 14, 2020 at 01:07:36AM +0530, Vaibhav Agarwal wrote:
> On Wed, May 13, 2020 at 11:15 PM Mark Greer wrote:
> >
> > On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> > > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> > > reported in September 20
On Fri, May 15, 2020 at 01:49:30PM +0100, John Oldman wrote:
> @@ -1167,9 +1166,8 @@ void rtw_dev_unload(struct adapter *padapter)
> DBG_871X_LEVEL(_drv_always_, "%s: driver in
> IPS-FWLPS\n", __func__);
> pdbgpriv->dbg_dev_unload_inIPS_cnt++;
>
Coding style issues:
This patch clears the checkpatch.pl "braces {} are not necessary for
single statement blocks" and "else_should_follow_close_brace"
warnings."
Signed-off-by: John Oldman
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 49 +++--
1 file changed, 17 insertions(
On Fri, May 15, 2020 at 05:40:44PM +0800, heshuai1 wrote:
> Fix this coding style error reported by checkpatch.pl:
> ERROR: do not use assignment in if condition
> #1120: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1120::
> +if ((addr = of_get_property(np, "local-mac-address", &l
Fix this coding style error reported by checkpatch.pl:
ERROR: do not use assignment in if condition
#1120: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1120::
+ if ((addr = of_get_property(np, "local-mac-address", &len)) &&
Signed-off-by: heshuai1
---
drivers/staging/rtl8723bs
This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups
instead of defining them manually.
Signed-off-by: Christian Gromm
Reported-by: Greg Kroah-Hartman
---
v2:
v3:
drivers/staging/most/usb/usb.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/d
This patch removes the reference to the driver API file for USB error
codes.
Signed-off-by: Christian Gromm
Reported-by: Greg Kroah-Hartman
---
v2:
removed copied USB error code section
v3:
drivers/staging/most/usb/usb.c | 97 --
1 file changed,
This patch fixes the ABI description file sysfs-bus-most.
Signed-off-by: Christian Gromm
---
v2:
v3:
Documentation/ABI/testing/sysfs-bus-most | 104 ---
1 file changed, 53 insertions(+), 51 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-bus-most
b/Docume
This patch removes the pr_*() functions and uses dev_*() instead.
Signed-off-by: Christian Gromm
Reported-by: Greg Kroah-Hartman
---
v2:
v3:
drivers/staging/most/usb/usb.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/most/usb/usb.c b/driv
This patch checks the number of endpoints reported by the USB
interface descriptor and throws an error if the number exceeds
MAX_NUM_ENDPOINTS.
Signed-off-by: Christian Gromm
Reported-by: Greg Kroah-Hartman
---
v2:
v3:
- initialize return variable
Reported-by: kbuild test robot
drive
This series fixes the comments/findings on the previously submitted code
of the USB adapter driver. The fixes should be applied in staging before
moving the driver out as one patch.
v2:
modded patch 2/7
v3:
modded patch 3/7
Christian Gromm (7):
staging: most: usb: use dev_*() fu
This patch replaces the functions dev_notice with dev_dbg to silence
the driver during normal operation.
Signed-off-by: Christian Gromm
Reported-by: Greg Kroah-Hartman
---
v2:
v3:
drivers/staging/most/usb/usb.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
dif
This patch corrects the typo in the Kconfig file where it says
tranceiver instead of transceiver.
Signed-off-by: Christian Gromm
Reported-by: Randy Dunlap
---
v2:
v3:
drivers/staging/most/usb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/usb/K
From: Jérôme Pouiller
Currently, when mac80211 want to disable beacon filtering, the driver
reset the filter table and disable the beacon filtering. Only the latter
action is required.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: Jérôme Pouiller
Some resources are associated to the outgoing of the stations. To avoid
any resource leaks. It is important to understand why an acknowledge is
not associated to any station.
Add a trace for that purpose.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c |
From: Jérôme Pouiller
wfx_tx_policy_put() use data from the skb. However, the call to
skb_pull() has just discarded them (even if the memory is in fact not
really discarded).
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Jérôme Pouiller
In fact, wfx_do_unjoin() resets the interface. This mechanism can be
used in more cases than just disassociating from a BSS. So, rename it to
reflect that fact.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 32 +++-
drivers/sta
From: Jérôme Pouiller
When a station is removed, the driver check that all the Tx frames were
correctly sent. However, the station can be removed before all the Tx
frames were acknowledged and a false positive warning can be emitted.
The previous commit has added a trace when driver received an
From: Jérôme Pouiller
The device disallows to start a scan request between hif_join() and
hif_set_bss_params(). The driver is not protected against that. The
worst case happens when association is aborted and hif_set_bss_params()
never happens.
mac80211 would never ask for scan during the associ
From: Jérôme Pouiller
If AP did not start, the error was not reported to mac80211.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 57304ed42e79..f
From: Jérôme Pouiller
The function wfx_tx_flush() wait for there is no more queued frames in
hardware queue. Then, for the sanity, it checks that there is no more
pending frame on any AC queue.
However, there is a race here. It may happens that hardware queues are
empty, but the counters of the
From: Jérôme Pouiller
wfx_stop_ap() and wfx_reset() do the same thing. Merge them.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index e077f42b62dc..7d9
From: Jérôme Pouiller
When multiple vif are in use (= one access point and one station), and
when the channels are different, it is necessary to enable power save on
station.
The firmware check that steps are done in the correct order:
- AP can't start if PS is not enable on the station
- PS
From: Jérôme Pouiller
The function wfx_notify_buffered_tx() need to know if the frame was
associated to a station. This information is available in the Control
Buffer (CB) of the skb. However, when wfx_notify_buffered_tx() is
called, the CB is no more available. Thus, the caller has to take care
From: Jérôme Pouiller
The function hif_scan() return the timeout for the completion of the
scan request. It is the only function from hif_tx.c that return another
thing than just an error code. This behavior is not coherent with the
rest of file. Worse, if value returned is positive, the caller c
From: Jérôme Pouiller
When wfx_flush() is called, the status of pending frames are reported to
mac80211 with random status. mac80211 probably won't interpret this
status in this case, but it is cleaner to return a correctly initialized
status.
Signed-off-by: Jérôme Pouiller
---
drivers/staging
From: Jérôme Pouiller
wfx_tx_confirm_cb() is a big function. A big part of its body aims to
fill the rates list. So, create a new function wfx_tx_fill_rates() and
make wfx_tx_confirm_cb() smaller.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 63 ++-
From: Jérôme Pouiller
Strings are allowed to exceed 80 columns but, in this case, the format
arguments should be placed on a new line. Apply this rule to the whole
code of the driver.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bus_sdio.c | 3 ++-
drivers/staging/wfx/data_tx.c |
From: Jérôme Pouiller
The device does not answer to the command hif_shutdown. Therefore,
hif_shutdown() is a bit special. It bypasses some of work normally made
by wfx_cmd_send(). In particularly, it unlock hif_cmd.lock and
hif_cmd.key_renew_lock.
However, if the driver notice that the device is
From: Jérôme Pouiller
Until now, the driver did not always check if the allocations success.
The issue was discussed here:
https://lore.kernel.org/netdev/2026476.QLiXXEGFCf@pc-42/
Reported-by: Dan Carpenter
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 43 +
From: Jérôme Pouiller
Hello,
This series contains various changes. The most important patches are the
13 and 14 since they fix two functional defects. The other patches fix
runtime warnings (1, 17, 18, 19), improve robustness (3, 4, 5, 7, 10, 16)
and do some cosmetics improvements (2, 6, 8, 9, 1
From: Jérôme Pouiller
Fix indention of wfx_skb_dtor().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index cac8c9ecbc34..a12590214a5d 10064
From: Jérôme Pouiller
Before to start the scan request, the firmware signals (with a null
frame) to the AP it won't be able to receive data. This frame can be
long to send: up to 512TU. The current calculus of the scan timeout does
not take into account this delay.
Signed-off-by: Jérôme Pouiller
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I includ
On Thu, May 14, 2020 at 02:51:01PM -0400, Sasha Levin wrote:
> From: Christian Gromm
>
> [ Upstream commit 5e56bc06e18dfc8a66180fa369384b36e2ab621a ]
>
> This patch replaces function module_init() with subsys_initcall().
> It is needed to ensure that the core module of the driver is
> initialize
47 matches
Mail list logo
