Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 04:58:46PM +0100, Pascal Terjan wrote: > On Tue, 2 Jun 2020 at 15:57, Larry Finger wrote: > > > > On 6/1/20 3:24 PM, Pascal Terjan wrote: > > > This patch switches to and and > > > deletes a lot of duplicate definitions plus many unused ones. > > > > > > Non obvious chang

[PATCH] staging: vc04_services: Convert get_user_pages*() --> pin_user_pages*()

2020-06-02 Thread Souptick Joarder
In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/

Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread kbuild test robot
Hi Pascal, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20200602] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest

Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread Larry Finger
On 6/1/20 3:24 PM, Pascal Terjan wrote: This patch switches to and and deletes a lot of duplicate definitions plus many unused ones. Non obvious changes: - struct ieee80211_ht_cap is different enough that I preferred to keep (and rename) it for now. - mcs_rate in translate_scan was not read

Re: [RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote: > Currently, GB codec and audio module is conditionally compiled based on > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 > platform and can be used generically with any platform that follows > GB Audio clas

Re: [RESEND PATCH v1 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:14AM +0530, Vaibhav Agarwal wrote: > +static int gbaudio_remove_controls(struct snd_card *card, struct device *dev, > +const struct snd_kcontrol_new *controls, > +int num_controls, const char *prefix) > +{

Re: [RESEND PATCH v1 4/6] staging: greybus: audio: Resolve compilation error in topology parser

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:13AM +0530, Vaibhav Agarwal wrote: > Fix compilation errors for GB Audio topology parser code with recent > kernel versions. > > Signed-off-by: Vaibhav Agarwal > --- > drivers/staging/greybus/audio_topology.c | 130 +++ > 1 file changed, 61 inser

Re: [RESEND PATCH v1 3/6] staging: greybus: audio: Resolve compilation errors for GB codec module

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:12AM +0530, Vaibhav Agarwal wrote: > Due to dependencies on ASoC framework changes, GB dummy codec module > compilation is currently disabled. This patch updates codec driver as > per the latest ASoC APIs. > > Signed-off-by: Vaibhav Agarwal > --- > drivers/staging/g

Re: [RESEND PATCH v1 2/6] staging: greybus: audio: Maintain jack list within GB Audio module

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:11AM +0530, Vaibhav Agarwal wrote: > As per the current implementation for GB codec driver, a jack list is > maintained for each module. And it expects the list to be populated by > the snd_soc_jack structure which would require modifications in > mainstream code. > >

Re: [RESEND PATCH v1 1/6] staging: greybus: audio: Update snd_jack FW usage as per new APIs

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:10AM +0530, Vaibhav Agarwal wrote: > diff --git a/drivers/staging/greybus/audio_codec.c > b/drivers/staging/greybus/audio_codec.c > index 08746c85dea6..ebf8484f0ae7 100644 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c > @@

Re: [PATCH] media: staging: tegra-vde: add missing pm_runtime_put_autosuspend

2020-06-02 Thread Markus Elfring
> Call to pm_runtime_get_sync increments counter even in case of > failure leading to incorrect ref count. > Call pm_runtime_put_autosuspend if pm_runtime_get_sync fails. How do you think about a wording variant like the following? Change description: The PM runtime reference counter is gen

[PATCH v5] drivers: most: add USB adapter driver

2020-06-02 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove subdirec

[PATCH] staging: rtl8192e: Using comparison to false is error prone

2020-06-02 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/s