[RFC 3/3] staging: qlge: clean up code that dump info to dmesg

2020-08-14 Thread Coiby Xu
The related code are not necessary because, - Device status and general registers can be obtained by ethtool. - Coredump can be done via devlink health reporter. - Structure related to the hardware (struct ql_adapter) can be obtained by crash or drgn. Signed-off-by: Coiby Xu --- drivers/stagin

[RFC 2/3] staging: qlge: coredump via devlink health reporter

2020-08-14 Thread Coiby Xu
$ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

[RFC 1/3] Initialize devlink health dump framework for the dlge driver

2020-08-14 Thread Coiby Xu
Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Makefile | 2 +- drivers/staging/qlge/qlge.h| 9 +++ drivers/staging/qlge/qlge_health.c | 43 ++

[PATCH v3] staging: greybus: audio: fix uninitialized value issue

2020-08-14 Thread Vaibhav Agarwal
The current implementation for gbcodec_mixer_dapm_ctl_put() uses uninitialized gbvalue for comparison with updated value. This was found using static analysis with coverity. Uninitialized scalar variable (UNINIT) 11. uninit_use: Using uninitialized value gbvalue.value.integer_value[0]. 460

Re: [PATCH v2] staging: greybus: audio: fix uninitialized value issue

2020-08-14 Thread Dan Carpenter
On Fri, Aug 14, 2020 at 01:07:20PM +0530, Vaibhav Agarwal wrote: > The current implementation for gbcodec_mixer_dapm_ctl_put() uses > uninitialized gbvalue for comparison with updated value. This was found > using static analysis with coverity. > > Uninitialized scalar variable (UNINIT) > 11. unin

[PATCH v2] staging: greybus: audio: fix uninitialized value issue

2020-08-14 Thread Vaibhav Agarwal
The current implementation for gbcodec_mixer_dapm_ctl_put() uses uninitialized gbvalue for comparison with updated value. This was found using static analysis with coverity. Uninitialized scalar variable (UNINIT) 11. uninit_use: Using uninitialized value gbvalue.value.integer_value[0]. 460