When aspect_ratio_crop_init() fails, curr_stream needs
to be freed just like what we've done in the following
error paths. However, current code is returning directly
and ends up leaking memory.
Signed-off-by: Dinghao Liu
---
drivers/staging/media/atomisp/pci/sh_css.c | 2 +-
1 file changed, 1 i
On 2020-08-21 11:08 +0800, Coiby Xu wrote:
[...]
> > > diff --git a/drivers/staging/qlge/qlge_health.h
> > > b/drivers/staging/qlge/qlge_health.h
> > > new file mode 100644
> > > index ..07d3bafab845
> > > --- /dev/null
> > > +++ b/drivers/staging/qlge/qlge_health.h
> > > @@ -0,0 +1,2
On Fri, 2020-08-21 at 10:42 +0800, Nicolas Boichat wrote:
> On Fri, Aug 21, 2020 at 10:36 AM Joe Perches wrote:
> > On Thu, 2020-08-20 at 21:57 -0400, Steven Rostedt wrote:
> > > On Fri, 21 Aug 2020 09:39:19 +0800
> > > Nicolas Boichat wrote:
> > []
> > > > Some other approaches/ideas:
> > > > 1
On Sun, Aug 16, 2020 at 11:57:17AM +0900, Benjamin Poirier wrote:
On 2020-08-15 00:06 +0800, Coiby Xu wrote:
The related code are not necessary because,
- Device status and general registers can be obtained by ethtool.
- Coredump can be done via devlink health reporter.
- Structure related to th
On Sun, Aug 16, 2020 at 11:56:40AM +0900, Benjamin Poirier wrote:
On 2020-08-15 00:05 +0800, Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Makefile | 2 +-
drivers/
On Thu, 20 Aug 2020 23:04:59 -0400
Steven Rostedt wrote:
> On Thu, 20 Aug 2020 19:49:59 -0700
> Joe Perches wrote:
>
> > Perhaps make trace_printk dependent on #define DEBUG?
>
> This is basically what Nicolas's patch series does in this very patch!
>
> And no, I hate it. We are currently d
On Thu, 20 Aug 2020 19:49:59 -0700
Joe Perches wrote:
> Perhaps make trace_printk dependent on #define DEBUG?
This is basically what Nicolas's patch series does in this very patch!
And no, I hate it. We are currently discussing ways of not having to
modify the config in order to allow trace_pri
On Fri, 21 Aug 2020 10:39:02 +0800
Nicolas Boichat wrote:
> I'm not sure how that helps? I mean, the use case you have in mind is
> somebody reusing a distro/random config and not being able to use
> trace_printk, right? If that config has CONFIG_DISABLE_TRACE_PRINTK=y,
> then the developer will
On Thu, 20 Aug 2020 19:36:19 -0700
Joe Perches wrote:
> On Thu, 2020-08-20 at 21:57 -0400, Steven Rostedt wrote:
> > On Fri, 21 Aug 2020 09:39:19 +0800
> > Nicolas Boichat wrote:
> []
> > > Some other approaches/ideas:
> > > 1. Filter all lkml messages that contain trace_printk. Already found
On Fri, Aug 21, 2020 at 10:36 AM Joe Perches wrote:
>
> On Thu, 2020-08-20 at 21:57 -0400, Steven Rostedt wrote:
> > On Fri, 21 Aug 2020 09:39:19 +0800
> > Nicolas Boichat wrote:
> []
> > > Some other approaches/ideas:
> > > 1. Filter all lkml messages that contain trace_printk. Already found
>
On Fri, Aug 21, 2020 at 9:57 AM Steven Rostedt wrote:
>
> On Fri, 21 Aug 2020 09:39:19 +0800
> Nicolas Boichat wrote:
>
> > On Fri, Aug 21, 2020 at 8:36 AM Steven Rostedt wrote:
> > >
> > > On Fri, 21 Aug 2020 08:13:00 +0800
> > > Nicolas Boichat wrote:
> > >
> > > > On Thu, Aug 20, 2020 at 10:
On Fri, 21 Aug 2020 09:39:19 +0800
Nicolas Boichat wrote:
> On Fri, Aug 21, 2020 at 8:36 AM Steven Rostedt wrote:
> >
> > On Fri, 21 Aug 2020 08:13:00 +0800
> > Nicolas Boichat wrote:
> >
> > > On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt
> > > wrote:
> > > >
> > > > On Thu, 20 Aug 202
On Fri, Aug 21, 2020 at 8:36 AM Steven Rostedt wrote:
>
> On Fri, 21 Aug 2020 08:13:00 +0800
> Nicolas Boichat wrote:
>
> > On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt wrote:
> > >
> > > On Thu, 20 Aug 2020 17:14:12 +0800
> > > Nicolas Boichat wrote:
> > >
> > > > Technically, we could only
On Fri, 21 Aug 2020 08:13:00 +0800
Nicolas Boichat wrote:
> On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt wrote:
> >
> > On Thu, 20 Aug 2020 17:14:12 +0800
> > Nicolas Boichat wrote:
> >
> > > Technically, we could only initialize the trace_printk buffers
> > > when the print env is switche
On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt wrote:
>
> On Thu, 20 Aug 2020 17:14:12 +0800
> Nicolas Boichat wrote:
>
> > Technically, we could only initialize the trace_printk buffers
> > when the print env is switched, to avoid the build error and
> > unconditional boot-time warning, but I a
Hi Anday,
On Tue, Aug 18, 2020 at 4:14 AM Andy Shevchenko
wrote:
>
> On Mon, Aug 17, 2020 at 05:53:09PM -0400, Jim Quinlan wrote:
> > The new field 'dma_range_map' in struct device is used to facilitate the
> > use of single or multiple offsets between mapping regions of cpu addrs and
> > dma ad
From: Jérôme Pouiller
A binary operator should be followed by exactly one space.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/key.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/key.c b/drivers/staging/wfx/key.c
index 5ee2ffc5f935..6165
From: Jérôme Pouiller
When MFP is enabled, the multicast management frames are not protected,
in fact. Instead, but they should include an IE containing the MMIC of
the frames (i.e. a cryptographic signature).
Until now, the driver didn't correctly detect this kind of frames (they
are not marked
From: Jérôme Pouiller
When mac80211 debug is enabled, the trace below appears:
[60744.340037] wlan0: Rx A-MPDU request on aa:bb:cc:97:60:24 tid 0 result
-524
This imply that ___ieee80211_start_rx_ba_session will prematurely exit
and frame reordering won't be enabled.
Fixes: e5da5fbd77411
From: Jérôme Pouiller
The device is able to scan while running an Access Point. Just declare
it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 1 +
drivers/staging/wfx/scan.c | 4
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/main.c b/
From: Jérôme Pouiller
The trace below can appear:
[83613.832200] INFO: trying to register non-static key.
[83613.837248] the code is fine but needs lockdep annotation.
[83613.842808] turning off the locking correctness validator.
[83613.848375] CPU: 3 PID: 141 Comm: kworker/3:2H
From: Jérôme Pouiller
The device need to receive a skb with necessary space for the ICV. So,
the driver adds this space before to send the frame.
Currently, once the frame is sent, the driver restore the original
content of the skb. However, this step is useless. Mac80211 don't do it
when softwa
From: Jérôme Pouiller
The protection of the management frames is mainly done by mac80211.
However, frames for the management of the BlockAck sessions are directly
sent by the device. These frames have to be protected if MFP is in use.
So the driver has to pass the MFP configuration to the device.
From: Jérôme Pouiller
Until now, hif_map_link() get as argument the raw value for
map_link_flags when map_link_flags is defined as a bitfield. It was
error prone.
Now hif_map_link() takes explicit value for every flags of the
struct map_link_flags.
Signed-off-by: Jérôme Pouiller
---
drivers/s
From: Jérôme Pouiller
The protection of the management frames is mainly done by mac80211.
However, frames for the management of the BlockAck sessions are directly
sent by the device. These frames have to be protected if MFP is in use.
So the driver has to pass the MFP configuration to the device.
From: Jérôme Pouiller
The host and the device can be connected with a called Wake-Up GPIO.
When the host fall down this GPIO, it allows the device to enter in deep
sleep and no communication with the device is no more possible (the
device wakes up automatically on DTIM and fetch data if necessary
From: Jérôme Pouiller
The initial developer has feared msecs_to_jiffies() could round down the
result. However, the documentation of msecs_to_jiffies() says that the
result is rounded upward. So the increment of the result of
msecs_to_jiffies() is not necessary.
Signed-off-by: Jérôme Pouiller
-
From: Jérôme Pouiller
In the old days, ieee80211 powersave has some impact on the Rx speed.
These problems are solved for a long time now. There is no more reason
to not enabling it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git
The most common cause of the binder transaction buffer filling up is a
client rapidly firing oneway transactions into a process, before it has
a chance to handle them. Yet the root cause of this is often hard to
debug, because either the system or the app will stop, and by that time
binder debug in
On Thu, Aug 20, 2020 at 12:41 PM kernel test robot wrote:
>
> Hi Martijn,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v5.9-rc1 next-20200820]
> [If your patch is applied to the wrong gi
Hi Mauro.
Quick feedback below.
Sam
On Thu, Aug 20, 2020 at 05:13:22PM +0200, Mauro Carvalho Chehab wrote:
> Em Thu, 20 Aug 2020 16:48:08 +0200
> Sam Ravnborg escreveu:
>
> > Hi Mauro.
> >
> > On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> > > Em Wed, 19 Aug
This patch adds the character device (cdev) driver source file
most_cdev.c and modifies the Makefiles and Kconfigs accordingly.
Signed-off-by: Christian Gromm
---
drivers/most/Kconfig | 9 +
drivers/most/Makefile | 1 +
drivers/most/most_cdev.c | 543
Em Thu, 20 Aug 2020 16:48:08 +0200
Sam Ravnborg escreveu:
> Hi Mauro.
>
> On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 19 Aug 2020 19:35:58 +0200
> > Sam Ravnborg escreveu:
> >
> > I'm already handling the other comments from your review (I'll send a
> > m
Hi Mauro.
On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> I'm already handling the other comments from your review (I'll send a
> more complete comment about them after finishing),
If you get back only on th
On Thu, 20 Aug 2020 17:14:12 +0800
Nicolas Boichat wrote:
> Technically, we could only initialize the trace_printk buffers
> when the print env is switched, to avoid the build error and
> unconditional boot-time warning, but I assume this printing
> framework will eventually get removed when the
Em Wed, 19 Aug 2020 19:35:58 +0200
Sam Ravnborg escreveu:
I'm already handling the other comments from your review (I'll send a
more complete comment about them after finishing), but I have a doubt
what you meant about this:
> +static int kirin_drm_bind(struct device *dev)
> > +{
> > + struct
The most common cause of the binder transaction buffer filling up is a
client rapidly firing oneway transactions into a process, before it has
a chance to handle them. Yet the root cause of this is often hard to
debug, because either the system or the app will stop, and by that time
binder debug in
Hi Martijn,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.9-rc1 next-20200820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--bas
Hi Mauro,
On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu:
> > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote:
> > > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > > > On Wed, Aug 19, 2020
We added a config option CONFIG_TRACING_ALLOW_PRINTK to make sure
that no extra trace_printk gets added to the kernel, let's use
that in this driver to guard the trace_printk call.
Signed-off-by: Nicolas Boichat
---
Technically, we could only initialize the trace_printk buffers
when the print en
(added c/c Rob Herring)
Em Wed, 19 Aug 2020 18:53:06 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct
> > platform_device *pdev)
> > }
> >
> > static const struct of_device_id kiri
Em Wed, 19 Aug 2020 14:36:52 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
> >
> > I added this series, together with the regulator driver and
>
From: Colin Ian King
There is a spelling mistake in the MODULE_ALIAS, fix it.
Signed-off-by: Colin Ian King
---
drivers/staging/hikey9xx/hisi-spmi-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c
b/drivers/staging
Em Wed, 19 Aug 2020 20:28:44 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote:
> >
> > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
> >
> > >
> > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> > > wrote:
> > > > So, IMO, the best is to keep
On 2020-08-19 10:48 p.m., Sam Ravnborg wrote:
> Hi Mauro.
>
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.
Right, some e-mails in this thread went through the dri-devel moderation
queue due to their sizes. This mail of yours did as well, because yo
Hi Sam,
Em Wed, 19 Aug 2020 22:48:00 +0200
Sam Ravnborg escreveu:
> Hi Mauro.
>
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.
Probably. It reached here properly.
> Link:
> https://lore.kernel.org/linux-devicetree/20200819173558.ga3...@ravnborg
Em Wed, 19 Aug 2020 12:52:06 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart
> wrote:
> > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > > > This patch series port t
47 matches
Mail list logo
