o not top-post!
What you explained is logical from APIs point of view, what I was
asking is about functional point of view.
Why do you think the skipping iteration is fine?
You need to explain this in the code/commit message.
> At 2022-03-29 19:45:50, "Andy Shevchenko" wrote:
&g
)
> p->func[i]->pins[j] = p->func[i]->pin_first + j;
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
linux.o(.data+0x1a8948): Section mismatch in
> > reference from the variable qede_forced_speed_maps to the variable
> > .init.rodata:__setup_str_initcall_blacklist
> Barry, can I get a fix for this?
Max already pointed out, but I guess you were not in Cc list, that
it's a GCC bug in his opinion, but GCC people don't ack it.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
y using the smaller v4l2_pix_format structure
> directly. This reduces the stack usage to 612 bytes, and it could
> be reduced further by only storing the three members that are used.
Good to me!
Reviewed-by: Andy Shevchenko
> Signed-off-by: Arnd Bergmann
> ---
> .../staging/me
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote:
> On Mon, 1 Feb 2021 19:40:21 +0200
> Andy Shevchenko wrote:
>
> > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> > > On Fri, 29 Jan 2021 16:26:12 +0200
> > > Andy Shevchenko wrote:
> > > > On Fri,
SFI-based platforms are gone. So does this framework.
This removes mention of SFI through the drivers and other code as well.
Signed-off-by: Andy Shevchenko
Reviewed-by: Hans de Goede
Acked-by: Linus Walleij
---
Documentation/ABI/testing/sysfs-firmware-sfi | 15 -
Documentation/ABI/testing
After the commit f1be6cdaf57c ("x86/platform/intel-mid: Make
intel_scu_device_register() static") the platform_device.h is not being
used anymore by intel-mid.h. Remove it.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h | 1 -
1 file changed, 1 deletion(-)
di
The header is used by a single user. Move header content to that user.
Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
---
arch/x86/include/asm/intel_scu_ipc.h| 2 --
arch/x86/include/asm/intel_scu_ipc_legacy.h | 18 --
arch/x86/platform/intel-mid/intel
Since there is no more user of this global variable and associated custom API,
we may safely drop this legacy reinvented a wheel from the kernel sources.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h| 23 ---
arch/x86/platform/intel-mid/intel
'reg'
not described in 'type1_access_ok'
Signed-off-by: Andy Shevchenko
---
arch/x86/pci/intel_mid_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 938a8b7bfe7f..8edd62206604 100644
--- a/arch/x86/pci/inte
Update Copyright year and drop file names from files themselves.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h| 4 ++--
arch/x86/platform/intel-mid/intel-mid.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/intel-mid.h
sfi.h is not anyhow used by the driver. Remove it.
Signed-off-by: Andy Shevchenko
Acked-by: Sakari Ailus
Acked-by: Linus Walleij
---
drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/include/linux
SFI-based platforms are gone. So does this driver.
Signed-off-by: Andy Shevchenko
Acked-by: Linus Walleij
---
drivers/cpufreq/Kconfig.x86 | 10 ---
drivers/cpufreq/Makefile | 1 -
drivers/cpufreq/sfi-cpufreq.c | 127 --
3 files changed, 138 deletions
Switch the platform code to use x86_id_table and accompanying API
instead of custom comparison against x86 CPU model.
This is one of the last users of custom API for that and following
changes will remove it for the good.
Signed-off-by: Andy Shevchenko
---
arch/x86/pci/intel_mid_pci.c | 17
's PM tree,
Note, atomisp change is tagged by Sakari on behalf of media tree maintainers.
Andy Shevchenko (9):
media: atomisp: Remove unused header
cpufreq: sfi-cpufreq: Remove driver for deprecated firmware
sfi: Remove framework for deprecated firmware
x86/PCI: Get rid of custom x86 m
On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> On Fri, 29 Jan 2021 16:26:12 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> > > On Fri, 29 Jan 2021 12:23:08 +0200
> > > Andy Shevchenko wrote:
...
> > > Hi, I apolog
On Fri, Jan 29, 2021 at 3:56 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
We are almost there, I have no idea what Noralf or others are going to
say though.
...
> Hi, I apologize for what I said in the previous two emails. I missed
> one email you
On Fri, Jan 29, 2021 at 2:54 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
...
> > This one is not like
On Fri, Jan 29, 2021 at 2:47 PM carlis wrote:
> On Fri, 29 Jan 2021 12:23:08 +0200
> Andy Shevchenko wrote:
> > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> > > On Thu, 28 Jan 2021 16:33:02 +0200
> > > Andy Shevchenko wrote:
> > > > On Thu, Jan
On Fri, Jan 29, 2021 at 7:01 AM carlis wrote:
> On Thu, 28 Jan 2021 16:33:02 +0200
> Andy Shevchenko wrote:
> > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
> >
> > Thanks for your contribution, my comments below.
> >
> > > From: zhangxuezhi
> >
&
On Thu, Jan 28, 2021 at 4:33 PM Andy Shevchenko
wrote:
> On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote:
...
> Taking all together you probably need to create a helper and use it
> inside init_display(), like
>
> static int init_tearing_effect_line(struct fbtft_par *par)
> {
OCs and make code easier to read and understand.
> + for (i = 0; i < to_copy; i++)
> + txbuf16[i] = cpu_to_be16(vmem16[i]);
If both of them are 16-bit wide, consider moving this to a helper
which somebody can move to byteorder/generic.h in the future.
> + vmem16 = vmem16 + to_copy;
> + ret = par->fbtftops.write(par, par->txbuf.buf,
> +startbyte_size + to_copy * 2);
> + if (ret < 0)
> + return ret;
> + remain -= to_copy;
> + }
> +
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
if (!kref_get_unless_zero(&fw->consumers))
> + return NULL;
Don't we have a more traditional way of doing this, i.e.
try_module_get() coupled with get_device() ?
> + return fw;
> }
--
With Best Regards,
Andy Shevchenko
___
On Wed, Oct 28, 2020 at 07:39:58PM -0400, Sven Van Asbroeck wrote:
> On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko
> wrote:
> >
> > + return snprintf(buf, max_size, "%pM\n", response.addr);
>
> Judging from a few Outreachy patches that have hit my inbox,
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko
---
v2: dropped struct removal (Sven), rebased on top of v5.10-rc1
drivers/staging/fieldbus/anybuss/hms-profinet.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss
rpi_firmware_put(rpipwm->firmware);
> +
> + return ret;
Can't you use the usual pattern?
ret = ...
if (ret)
return ret;
...
return 0;
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
and make sure they all finished
> unbinding before we do.
Wait, if it's a device, why do we need all these?
get_device() / put_device() along with module_get() / module_put()
should be sufficient, no?
--
With Best Regards,
Andy Shevchenko
__
omisp_compat_ioctl32"), nothing in this file is actually getting used
> as the only reference has been stubbed out.
>
> Remove the entire file -- anyone willing to restore the functionality
> can equally well just look up the contents in the git history if needed.
Good one!
Reviewed-by:
On Thu, Oct 1, 2020 at 6:55 PM Mauro Carvalho Chehab
wrote:
> Em Thu, 1 Oct 2020 18:50:12 +0300
> Andy Shevchenko escreveu:
>
> > On Thu, Oct 1, 2020 at 2:17 PM Mauro Carvalho Chehab
> > wrote:
> > >
> > > A temporary var needed for building with ISP
prim_out_info,
> @@ -6009,6 +6014,9 @@ static int load_primary_binaries(
> online = pipe->stream->config.online;
> #ifdef ISP2401
> sensor = (pipe->stream->config.mode == IA_CSS_INPUT_MODE_SENSOR);
> +#else
> + memory = pipe->stream->con
On Mon, Sep 21, 2020 at 02:33:57PM +0100, Dan Scally wrote:
> On 18/09/2020 14:07, Andy Shevchenko wrote:
> > On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote:
> >> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote:
> >>> On Thu, Sep 17,
On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote:
> On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
> > > On 17/09/2020 11:33, Sakari Ailus wrote:
> > > > a module and not
On Thu, Sep 17, 2020 at 02:36:22PM +0100, Dan Scally wrote:
> On 17/09/2020 13:45, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
> >> On 17/09/2020 11:33, Sakari Ailus wrote:
> > I will do better review for next version, assuming y
On Thu, Sep 17, 2020 at 5:19 PM Kieran Bingham
wrote:
> On 17/09/2020 15:08, Andy Shevchenko wrote:
...
> Ayee, ok so we have 'half' the driver for IPU3 out of staging.
Correct. And your below analysis is correct.
> From my understanding, the IPU3 consists of two component
On Thu, Sep 17, 2020 at 4:53 PM Dan Scally wrote:
>
> Hi Andy, thanks for input (as always)
You're welcome! I'm really impressed by your activity in this area.
> On 17/09/2020 13:45, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote:
rs/media/pci/intel
IPU3 from Freescale (IIRC) is a different story.
> Hopefully with more users of the IPU3 brought in by this cio2-bridge,
> that will help gather momentum to get the IPU3 developments required
> completed and moved into drivers/media.
--
With Best Regards,
Andy Shevc
kari, I tend to agree with Dan and have the board file separated from the
driver and even framework.
...
> > Cc Andy, too.
Thanks!
...
> >> I wanted to raise this as an RFC as although I don't think it's ready for
> >> integration it has some things that I
ty much unsigned int i.
> There are very few times where raising the type maximum from 2 billion
> to 4 billion fixes anything.
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
s.
> +static int __attribute__((format (printf, 1, 0)))
> +atomisp_css2_dbg_ftrace_print(const char *fmt, va_list args)
> {
> ftrace_vprintk(fmt, args);
> return 0;
> }
>
Why not to drop it completely as well?
> -static int atomisp_css2_err_print(const char *fmt, va_list args)
> -{
quest/direction_output fail");
> - goto fail2;
> + goto fail3;
> }
> return atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH);
> -fail2:
> +fail3:
> media_entity_cleanup(&flash->sd.entity);
> v4l2_ctrl_handler_fr
> + }
Wouldn't be better to do an assignment of offset here?
> + if (!offset)
> + return 0;
> +
> + map = kcalloc(2, sizeof(*map), GFP_KERNEL);
> + if (!map)
> + return -ENOMEM;
> + map[0].cpu_start = cpu_start;
> + map
On Thu, Aug 20, 2020 at 09:37:12AM -0400, Jim Quinlan wrote:
> On Tue, Aug 18, 2020 at 4:14 AM Andy Shevchenko
> wrote:
> > On Mon, Aug 17, 2020 at 05:53:09PM -0400, Jim Quinlan wrote:
...
> > > +static inline u64 dma_offset_from_dma_addr(struct device *dev,
>
ap)
> +{
> + int num_ranges;
> + struct bus_dma_region *new_map;
> + const struct bus_dma_region *r = map;
> +
> + for (num_ranges = 0; r->size; num_ranges++)
> + r++;
> + new_map = kcalloc(num_ranges + 1, sizeof(*map), GFP_KERNEL);
> + if (new_map)
> + memcpy(new_map, map, sizeof(*map) * num_ranges);
Looks like krealloc() on the first glance...
> +
> + return new_map;
> +}
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
- return -EINVAL if unknown PMIC type.
This has to go after cutter '---' line below.
> Caught-by: Coverity Static Analyzer CID 1465536
Reported-by:
And as discussed previously,
Suggested-by: Mauro ...
> Signed-off-by: Cengiz Can
Convert to %pM instead of using custom code.
While here, replace one time use structure by buffer on stack.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fieldbus/anybuss/hms-profinet.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko
---
drivers/staging/ks7010/ks_hostif.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index d70b671b06aa
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko
---
drivers/staging/most/net/net.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
index 830f089f1a88..b6fecb06a0e6 100644
--- a
static int gmin_v2p8_ctrl(struct v4l2_subdev *subdev,
> int on)
> int ret;
> int value;
>
> + if (!gs) {
> + pr_err("Unable to find gmin subdevice\n");
> + return -EINVAL;
And here is a change of semantics...
> + }
..
On Wed, Jul 29, 2020 at 01:19:50PM +0530, Ankit Baluni wrote:
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Ankit Bal
On Wed, Jul 29, 2020 at 11:12 AM Ankit Baluni
wrote:
>
> Added a missing comma and changed 'it it useful' to 'it is useful'.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Ankit Baluni
> ---
> Changes in -v2:
> -Remove space before ':
On Wed, Jul 29, 2020 at 3:34 AM Ankit Baluni
wrote:
>
> Added a missing comma and changed 'it it useful' to 'it is useful'.
Please, drop spaces before : in the subject line. In all patches you
submitted there is such an issue.
--
With Bes
On Mon, Jul 27, 2020 at 01:31:50PM +0530, Ankit wrote:
> From: Ankit Baluni
>
> Fixed a coding style issue.
One time is enough to be sent :-)
The Subject nevertheless can be amended, like
media: atomisp: fixed a brace coding sytle issue
--
With Best Regards,
Andy S
ap) : 0;
PTR_ERR_OR_ZERO()
...
> + = dma_offset_from_phys_addr(dev,
> PFN_PHYS(mem->pfn_base));
> +
> + return (dma_addr_t)PFN_PHYS(mem->pfn_base) - dma_offset;
Looking at this more, I think you need to introduce in the same header (pfn.h)
som
On Fri, Jun 26, 2020 at 05:52:16PM +0200, Mauro Carvalho Chehab wrote:
> Em Fri, 26 Jun 2020 18:00:21 +0300
> Andy Shevchenko escreveu:
>
> > On Fri, Jun 26, 2020 at 04:04:52PM +0200, Mauro Carvalho Chehab wrote:
> > > Those patches are meant to improve device detecti
267 insertions(+), 128 deletions(-)
>
> --
> 2.26.2
>
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jun 08, 2020 at 11:48:51AM -0400, Jim Quinlan wrote:
> On Sun, Jun 7, 2020 at 12:500f9bfe0fb8840b268af1bbcc51f1cd440514e PM
> Andy Shevchenko wrote:
> > On Fri, Jun 05, 2020 at 05:26:48PM -0400, Jim Quinlan wrote:
...
> > > + *map_size = (num_range
u_addr)
> + - PFN_DOWN(range.bus_addr);
Ditto (indentation).
...
> + unsigned long dma_pfn_offset
> + = dma_pfn_offset_from_phys_addr(dev, paddr);
Ditto.
...
> + unsigned long dma_pfn_offset
> +
in the kernel.
For example, above line is like
pfn = PFN_DOWN(phys);
...
> > > + if (!WARN_ON(!dev) && dev->dma_pfn_offset_map)
> > > + *dma_handle -= PFN_PHYS(
> > > + dma_pfn_offset_from_phys_addr(dev, phys
this patch, only the 'drivers/platform/x86/toshiba_acpi.c' needs an
> update to pass the parent object as a parameter.
Acked-by: Andy Shevchenko
>
> In the next patch all devm_iio_device_alloc() calls will be handled.
>
> Signed-off-by: Alexandru Ardelean
> ---
> drive
trig | grep -vq devm_; then
> echo "$file -> $(grep "parent =" $file)"
> fi
> done
> ---
Side note: time to learn coccinelle or shell better :-)
--
With Best Regards,
Andy Shevchenko
_
for swnodes. With that done it will
be feasible to achieve the rest.
I forgot if we have anything for this already done. Heikki?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject
x27;s a good discussion it reminds me that this entire function,
i.e. reset(), repeats the on provided by fbtft core.
Yes, the only question if it's atomic or not. IIRC ->reset() is being
called only in non-atomic contexts and keeping reset signal longer is
fin
st initializing its notifier with a
> call to v4l2_async_notifier_init().
Hint: When creating a list of maintainers use this (or similar) command:
scripts/get_maintainer.pl --git --git-min-percent=67 ...
P.S. Please, do not add me in Cc list for v4l2 matters.
--
With Best Regard
e use of device property API")
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index e87d839d86ac..4fcc82b7de1b 100644
--- a/d
On Wed, Nov 20, 2019 at 04:04:17PM +0100, Noralf Trønnes wrote:
> Den 20.11.2019 15.43, skrev Noralf Trønnes:
> > Den 20.11.2019 10.57, skrev Andy Shevchenko:
> >> First of all there is no need to guard GPIO request by CONFIG_OF.
> >> It works for everybody indepen
dev->driver->name, 16);
| ^~~~
Later on the copy is being used with the assumption to be NULL terminated.
Make sure string is NULL terminated by switching to snprintf().
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 2 +
ys be true.
Due to above drop useless #ifdef CONFIG_OF and therefore dead code.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/
Now, since driver became OF independent, no need to keep OF dependency.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/Kconfig | 2 +-
drivers/staging/fbtft/fbtft.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging
Make use of device property API in this driver so that both OF based
system and ACPI based system can use this driver.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 105 -
1 file changed, 58 insertions(+), 47 deletions(-)
diff --git a
propriate.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 61f0286fb157..2122c4407bdb 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/s
t;> ld: drivers/iio/common/hid-sensors/hid-sensor-attributes.c:314: undefined
> >> reference to `__umoddi3'
> >> ld: drivers/iio/common/hid-sensors/hid-sensor-attributes.c:324: undefined
> >> reference to `__udivdi3'
mote_port_parent.
>
May I ask if it's going to be used outside of v4l2?
Any user in mind?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tl8723bs/os_dep/ioctl_linux.c| 12 +++-
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
decs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -1405,7 +1405,7 @@ static int max98088_get_channel(struct
> snd_soc_component *component, const char
> {
> int ret;
>
> - ret = __match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name);
> + ret = match_s
From: Petr Štetiar Sent: Tuesday, May 7, 2019 5:25 AM
> There was NVMEM support added to of_get_mac_address, so it could now
> return ERR_PTR encoded error values, so we need to adjust all current users
> of of_get_mac_address to this new fact.
>
> While at it, remove superfluous is_valid_ether_a
E conversion.
> I'll post the patches I made for that later, as they need more
> testing and review from the scsi maintainers.
>
> I hope you can still take these for the coming merge window, unless
> new problems come up.
> drivers/platform/x86/wmi.c
On Mon, Mar 25, 2019 at 5:12 PM Christian Brauner wrote:
>
> On Mon, Mar 25, 2019 at 05:00:17PM -0700, Andy Lutomirski wrote:
> > On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner
> > wrote:
> > >
> > > On Mon, Mar 25, 2019 at 04:42:14PM -0700, Andy Luto
On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner wrote:
>
> On Mon, Mar 25, 2019 at 04:42:14PM -0700, Andy Lutomirski wrote:
> > On Mon, Mar 25, 2019 at 1:23 PM Daniel Colascione wrote:
> > >
> > > On Mon, Mar 25, 2019 at 1:14 PM Jann Horn wrote:
> > > &g
On Mon, Mar 25, 2019 at 1:23 PM Daniel Colascione wrote:
>
> On Mon, Mar 25, 2019 at 1:14 PM Jann Horn wrote:
> >
> > On Mon, Mar 25, 2019 at 8:44 PM Andy Lutomirski wrote:
> > One ioctl on procfs roots to translate pidfds into that procfs,
> > subject to bot
On Wed, Mar 20, 2019 at 12:40 PM Daniel Colascione wrote:
>
> On Wed, Mar 20, 2019 at 12:14 PM Christian Brauner
> wrote:
> >
> > On Wed, Mar 20, 2019 at 11:58:57AM -0700, Andy Lutomirski wrote:
> > > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner
>
PI that gives
you the dirfd associated with a procfd but only if you can see
/proc/PID.
--Andy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Cc: de...@linuxdriverproject.org
Signed-off-by: Andy
that change the same line or
> function for example. Order them with cleanups / non-functional-changes
> first, followed by functional changes.
>
> >
> > Basically all of the above is based on the review by Andy Shevchenko.
>
> Andy, what was your intent for Lubomir here?
;
> + if (!priv->pwrbtn)
> + return -ENOMEM;
> + priv->pwrbtn->name = "Power Button";
> + priv->pwrbtn->dev.parent = &spi->dev;
> + input_set_capability(priv->pwrbtn, EV_KEY, KEY_POWER);
> + ret = input_registe
I'm about to review the patch 6, otherwise read my comments for the
rest and consider addressing them.
>
> Lubo
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
@ static int olpc_battery_probe(struct platform_device
> *pdev)
> if (ecver[0] > 0x44) {
> /* XO 1 or 1.5 with a new EC firmware. */
> data->new_proto = 1;
> + } else if (of_find_compatible_node(NULL, NULL, "
tocol, supported by 0x44 and
> above.
> +*/
> printk(KERN_NOTICE "OLPC EC version 0x%02x too old for "
> - "battery driver.\n", olpc_platform_info.ecver);
> + "battery driver.\n", ecver[0]);
> return -ENXIO;
> }
>
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel wrote:
>
> The global variables for private data are not too nice. I'd like some
> more, and that would clutter the global name space even further.
>
Good change!
Reviewed-by: Andy Shevchenko
> Signed-off-by: Lubomir Rintel
&g
.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
> #include
Keep it sorted, otherwise the change is good!
Reviewed-by: Andy Shevchenko
>
>
> @@ -622,11 +623,13 @@ static int olpc_battery_probe(struct platform_device
> *pdev)
>
"\" /pci/display@1\" find-device"
> " new-device"
> " \" dcon\" device-name \" olpc,xo1-dcon\"
> +compatible"
> " finish-device device-end");
defined as boolean, supplied an int. Not good.
> + return olpc_ec_set_dcon_power(ec, 0);
Ditto.
> +static int dcon_regulator_is_enabled(struct regulator_dev *rdev)
> + return ec->dcon_enabled;
Ditto.
--
With Best Regards,
Andy Shevchenko
0x40
> +#define EC_SCI_SRC_BATCRIT 0x80
> +#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
BIT() ?
> +#define EC_SCI_SRC_ALL 0x1FF
GENMASK()?
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
registered. */
> + if (!ec_driver)
> + return -ENODEV;
Why -ENODEV is preferred over -EPROBE_DEFER?
> +
> + if (WARN_ON(!ec_driver->ec_cmd))
> return -ENODEV;
>
> if (!ec)
> --
> 2.19.0
>
--
With
ARM
depends on OLPC && ARM // or ARM64 or whatever it's called
thus, above would look like
depends on MOUSE_PS2
depends on OLPC && X86
and
depends on FB
depends on OLPC && X86
respectively.
--
With Best Regards,
Andy Shevchenko
___
-15,7 +15,6 @@
> #include
> #include
> #include
> -#include
>
> struct ec_cmd_desc {
> u8 cmd;
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
e
> #include
> -#include
> +#include
> #include
> #include
> #include
> @@ -328,4 +326,8 @@ static int __init olpc_ec_init_module(void)
> {
> return platform_driver_register(&olpc_ec_plat_driver);
> }
> +
> arch_initcall(olpc_e
break;
> case POWER_SUPPLY_PROP_CHARGE_COUNTER:
> ret = olpc_ec_cmd(EC_BAT_ACR, NULL, 0, (void *)&ec_word, 2);
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Oct 11, 2018 at 3:28 PM Marcelo Tosatti wrote:
>
> On Tue, Oct 09, 2018 at 01:09:42PM -0700, Andy Lutomirski wrote:
> > On Tue, Oct 9, 2018 at 8:28 AM Marcelo Tosatti wrote:
> > >
> > > On Mon, Oct 08, 2018 at 10:38:22AM -0700, Andy Lutomirski wrote:
>
On Tue, Oct 9, 2018 at 8:28 AM Marcelo Tosatti wrote:
>
> On Mon, Oct 08, 2018 at 10:38:22AM -0700, Andy Lutomirski wrote:
> > On Mon, Oct 8, 2018 at 8:27 AM Marcelo Tosatti wrote:
> > I read the comment three more times and even dug through the git
> > history. I
On Mon, Oct 8, 2018 at 8:27 AM Marcelo Tosatti wrote:
>
> On Sat, Oct 06, 2018 at 03:28:05PM -0700, Andy Lutomirski wrote:
> > On Sat, Oct 6, 2018 at 1:29 PM Marcelo Tosatti wrote:
> > >
> > > On Thu, Oct 04, 2018 at 03:15:32PM -0700, Andy Lutomirski wrote:
> &
1 - 100 of 648 matches
Mail list logo
