Hi Benjamin,
On Mon, 2021-06-28 at 15:35 +0200, Benjamin Gaignard wrote:
>
> Le 16/04/2021 à 12:54, Lucas Stach a écrit :
> > Am Mittwoch, dem 07.04.2021 um 09:35 +0200 schrieb Benjamin Gaignard:
> > > In order to be able to share the control hardware block between
> > > VPUs use a syscon instead
Hi Lucas,
On Mon, 2021-05-17 at 12:52 +0200, Lucas Stach wrote:
> Hi Ezequiel,
>
> Am Sonntag, dem 16.05.2021 um 19:40 -0300 schrieb Ezequiel Garcia:
> > Hi Lucas,
> >
> > On Fri, 2021-04-16 at 12:54 +0200, Lucas Stach wrote:
> > > Am Mittwoch, dem 07.04.
On Mon, 2021-05-17 at 12:52 +0200, Lucas Stach wrote:
> Hi Ezequiel,
>
> Am Sonntag, dem 16.05.2021 um 19:40 -0300 schrieb Ezequiel Garcia:
> > Hi Lucas,
> >
> > On Fri, 2021-04-16 at 12:54 +0200, Lucas Stach wrote:
> > > Am Mittwoch, dem 07.04.2021 um 0
Hi Hans,
On Thu, 2021-05-06 at 14:50 +0200, Hans Verkuil wrote:
> On 05/05/2021 17:20, Benjamin Gaignard wrote:
> >
> > Le 05/05/2021 à 16:55, Hans Verkuil a écrit :
> > > On 20/04/2021 14:10, Benjamin Gaignard wrote:
> > > > The HEVC HANTRO driver needs to know the number of bits to skip at
> >
Hi Lucas,
On Fri, 2021-04-16 at 12:54 +0200, Lucas Stach wrote:
> Am Mittwoch, dem 07.04.2021 um 09:35 +0200 schrieb Benjamin Gaignard:
> > In order to be able to share the control hardware block between
> > VPUs use a syscon instead a ioremap it in the driver.
> > To keep the compatibility with o
On Wed, 2021-05-05 at 16:55 +0200, Hans Verkuil wrote:
> On 20/04/2021 14:10, Benjamin Gaignard wrote:
> > The HEVC HANTRO driver needs to know the number of bits to skip at
> > the beginning of the slice header.
> > That is a hardware specific requirement so create a dedicated control
> > for this
Hi Andrzej,
Thanks a lot for picking this up.
On Tue, 2021-05-04 at 13:37 +0200, Andrzej Pietrasiewicz wrote:
> From: Ezequiel Garcia
>
> The driver should only set the payload on .buf_prepare if the
> buffer is CAPTURE type. If an OUTPUT buffer has a zero bytesused
> set by
Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> .../userspace-api/media/drivers/hantro.rst | 19 +++
> .../userspace-api/media/drivers/index.rst | 1 +
> include/media/hevc-ctrls.h | 13 +
> 3 files changed, 33 in
makes sense to bother with Fixes tag.
Reviewed-by: Ezequiel Garcia
Thanks,
Ezequiel
> ---
> drivers/staging/media/hantro/hantro_drv.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/hantro/hantro_drv.c
> b/drivers/stag
rrors.
>
> While there's nothing wrong with the current usage on this driver,
> as we're getting rid of the pm_runtime_get_sync() call all over
> the media subsystem, let's remove the last occurrence on this
> driver.
>
> Signed-off-by: Mauro Carvalho Chehab
Hi Mauro,
On Wed, 2021-04-28 at 08:44 +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 28 Apr 2021 08:27:42 +0200
> Mauro Carvalho Chehab escreveu:
>
> > Em Tue, 27 Apr 2021 12:18:32 -0300
> > Ezequiel Garcia escreveu:
> >
> > > On Tue, 2021-04-27 at 16:08 +01
On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote:
> On 2021-04-27 11:27, Mauro Carvalho Chehab wrote:
> > Despite other *_get()/*_put() functions, where usage count is
> > incremented only if not errors, the pm_runtime_get_sync() has
> > a different behavior, incrementing the counter *even* on
On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne wrote:
>
> Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit :
> > Hi Andrzej,
> >
> > Thank you for working on this!
> >
> > On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> > > Dear All,
> > >
> > > This is an RFC on stateless uapi for v
Hi Mauro,
On Sat, 2021-04-24 at 08:44 +0200, Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
> usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use t
uot;PM: runtime: Add pm_runtime_resume_and_get to deal with
> usage counter")
> in order to properly decrement the usage counter and avoid memory
> leaks.
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Ezequiel Garcia
Thanks a lot for taking care of this.
_
Hi Benjamin,
Thanks for the patch.
On Thu, 2021-04-01 at 17:59 +0200, Benjamin Gaignard wrote:
> The HEVC HANTRO driver needs to know the number of bits to skip at
> the beginning of the slice header.
> That is a hardware specific requirement so create a dedicated control
> that this purpose.
>
rence picture set".
>
> Adapt Cedrus driver to these changes.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> version 7:
> - rebased on top of media_tree/master branch
>
> version 6:
> - fix compilation errors
>
f-by: Benjamin Gaignard
> Reviewed-by: Philipp Zabel
Reviewed-by: Ezequiel Garcia
> ---
> version 7:
> - Add Philipp Reviewed-by tag.
>
> version 5:
> - remove useless postproc fields for G2
>
> version 2:
> - remove useless clocks
>
> drivers/staging/media/h
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2
> of the driver.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> drivers/staging/media/hantro/hantro_v4l2.c | 1 +
&g
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> If the variant doesn't offert postprocessed formats make sure it will
> be ok.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> drivers/staging/media/hantro/hantro.h |
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Define which HEVC profiles (up to level 5.1) and features
> (no scaling, no 10 bits) are supported by the driver.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> drivers/staging/med
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Change hantro_codec_ops run prototype from 'void' to 'int'.
> This allow to cancel the job if an error occur while configuring
> the hardware.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by:
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Add fields and flags as they are defined in
> 7.4.3.3.1 "General picture parameter set RBSP semantics of the
> H.265 ITU specification.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> -
On Fri, 2021-03-26 at 15:33 +0100, Benjamin Gaignard wrote:
>
> Le 26/03/2021 à 15:24, Philipp Zabel a écrit :
> > On Thu, Mar 18, 2021 at 09:20:46AM +0100, Benjamin Gaignard wrote:
> > > Split VPU node in two: one for G1 and one for G2 since they are
> > > different hardware blocks.
> > > Add sys
Hi Enric,
Thanks a lot for the patch.
On Thu, 25 Feb 2021 at 09:08, Enric Balletbo i Serra
wrote:
>
> The AXI ID is an AXI bus configuration for improve bus performance. If
> read and write operations use different ID the operations can be
> paralleled, whereas when they have the same ID the ope
formation from the stream that only the userland knows so let it
> provide the correct value to the driver.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> drivers/staging/media/hantro/Makefile |
Salut Paul,
Just a minor comment about the v4l2 async API.
On Thu, 31 Dec 2020 at 11:30, Paul Kocialkowski
wrote:
>
> The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 bridge
> found on Allwinner SoCs such as the A31 and V3/V3s.
>
> It is a standalone block, connected to the CSI controller
On Mon, 2021-01-11 at 13:22 +0100, Ricardo Ribalda wrote:
> Hi Ezequiel
>
> On Mon, Jan 11, 2021 at 12:55 PM Ricardo Ribalda wrote:
> >
> > Hi Ezequiel
> >
> > On Mon, Jan 11, 2021 at 12:48 PM Ezequiel Garcia
> > wrote:
> > >
> > > H
Hi Ricardo,
On Mon, 2021-01-11 at 12:35 +0100, Ricardo Ribalda wrote:
> Clear the reserved fields.
>
> Fixes:
> fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed
> test VIDIOC_TRY_FMT: FAIL
> fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed
> t
On Sat, 2021-01-09 at 17:43 +0530, Sri Laasya Nutheti wrote:
> Line 146 had a comma in place of a semicolon. Fix it.
>
> Signed-off-by: Sri Laasya Nutheti
> ---
> v3: Corrected email recipients
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
On Fri, 2021-01-08 at 17:22 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/r
On Thu, 2021-01-07 at 12:41 +0100, Boris Brezillon wrote:
> On Thu, 7 Jan 2021 10:13:43 +0100
> Hans Verkuil wrote:
>
> > On 08/12/2020 16:55, Adrian Ratiu wrote:
> > > Some configurations built by the ktest bot produce the following
> > > warn, so mark the struct as __maybe_unused to avoid unnec
On Fri, 2020-11-27 at 00:40 +0100, Jernej Škrabec wrote:
> Hi!
>
> Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a):
> > Hi Jernej, Emmanuel,
> >
> > Thanks for the patch.
> >
> > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec
ot; trigger.
>
> Signed-off-by: Jernej Skrabec
> [addressed issues from reviewer]
> Signed-off-by: Emmanuel Gil Peyrot
> ---
> Changes in v3:
> - addressed comments from Ezequiel Garcia - new comments,
> using new macros from VP8 UAPI, new function for waiting
> on
On Sat, 21 Nov 2020 at 23:01, Dmitry Osipenko wrote:
>
> 22.11.2020 04:02, Ezequiel Garcia пишет:
> > Hi Dmitry,
> >
> ...
> >> +++ b/drivers/staging/media/tegra-vde/TODO
> >> @@ -0,0 +1,4 @@
> >> +TODO:
> >> + - Implem
Hi Dmitry,
On Mon, 11 Dec 2017 at 21:27, Dmitry Osipenko wrote:
>
> NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that
> supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1.
>
> Signed-off-by: Dmitry Osipenko
> ---
> MAINTAINERS
Hi Emmanuel,
Thanks for the patch.
On Mon, 9 Nov 2020 at 15:37, Emmanuel Gil Peyrot wrote:
>
> These values will be used by various drivers implementing the VP8
> stateless API.
>
> This had been suggested by Ezequiel Garcia for the Cedrus VP8 driver.
>
> The only driver
0x14
> start_kernel+0x690/0x6b0
> Code: f2fbd5a6 f2fbd5a5 5284 a9400823 (f9000462)
> ---[ end trace 88233b9a76cdb261 ]---
> Kernel panic - not syncing: Fatal exception in interrupt
>
Just FWIW, you could have included the panic backtrace and
the information about the bug in t
On Sun, 26 Jul 2020 at 16:16, Jernej Škrabec wrote:
>
> Hi Ezequiel!
>
> Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a):
> > Hi Jernej,
> >
> > As you know, I'm not familiar with this hardware,
> > but I've tried to ta
Hi Jernej,
As you know, I'm not familiar with this hardware,
but I've tried to take a detailed look anyway.
The driver looks mostly good to me, I just have
some minor comments.
More importantly, seems the current uAPI
control is supporting this platform nicely,
which gives us some confidence to
Nicolas Dufresne
This looks correct.
Reviewed-by: Ezequiel Garcia
Thanks,
Ezequiel
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_vi
Hello Jernej,
I'd like to post a new H264 uAPI cleanup series soon,
would you mind resending this, or otherwise do you
mind if I include this patch in the series?
See below for a tiny comment.
On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote:
>
> When dealing with with interlaced frames, refer
Hi Jernej,
On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote:
>
> Currently H264 interlaced content it's not properly decoded on Cedrus.
> There are two reasons for this:
> 1. slice parameters control doesn't provide enough information
> 2. bug in frame list construction in Cedrus driver
>
> As d
Hello Jernej,
Thanks for the patch.
On Wed, 20 May 2020 at 14:12, Jernej Skrabec wrote:
>
> If VPU supports untiled output, it actually supports several different
> YUV 4:2:0 layouts, namely NV12, NV21, YUV420 and YVU420.
>
> Add support for all of them.
>
> Signed-off-by: Jernej Skrabec
> ---
Hi Heiko,
On Fri, 2020-04-03 at 13:15 -0300, Helen Koike wrote:
> From: Shunqian Zheng
>
> Designware MIPI D-PHY, used for ISP0 in rk3399.
>
> Verified with:
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
>
> Signed-off-by: Shu
Hi Hans,
On Fri, 2020-04-17 at 09:18 +0200, Hans Verkuil wrote:
> On 03/04/2020 18:15, Helen Koike wrote:
> > The Rockchip ISP bindings was moved out of staging.
> > Update MAINTAINERS file with the new path.
>
> Shouldn't there be a reference to
> Documentation/devicetree/bindings/phy/rockchip-
Hi Mauro, Randy,
On Mon, 20 Apr 2020 at 13:45, Mauro Carvalho Chehab
wrote:
>
> building it with a random config causes a warning:
>
> WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] &&
> (ARCH_ROC
On Wed, 2020-04-08 at 21:08 +0200, Arnd Bergmann wrote:
> On Wed, Apr 8, 2020 at 7:56 PM Ezequiel Garcia wrote:
> > On Wed, 2020-04-08 at 17:52 +0200, Arnd Bergmann wrote:
> > > When compile-testing with CONFIG_OF disabled, we get a warning
> > > about an unused varia
On Wed, 2020-04-08 at 17:52 +0200, Arnd Bergmann wrote:
> When compile-testing with CONFIG_OF disabled, we get a warning
> about an unused variable, and about inconsistent Kconfig dependencies:
>
> WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> Depends on [n]: STAGING [=
(+Kishon)
Hi Helen,
I was wondering if we couldn't also move the phy driver out of staging.
Thanks,
Ezequiel
On Wed, 2020-04-01 at 21:02 -0300, Helen Koike wrote:
> Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy
>
> Signed-off-by: Helen Koike
> ---
> .../device
Hi Andrzej,
On Mon, 2020-01-27 at 15:30 +0100, Andrzej Pietrasiewicz wrote:
> The table is actually different in the document than in this file, so align
> this file with the document.
>
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/staging/media/hantro/hantro_jpeg.c | 16 -
ed_be32() at consecutive word locations instead.
>
Ouch!
Seems we were too fast on that cleanup. Please add:
Cc: sta...@vger.kernel.org
Fixes: 00c30f42c7595f "media: rockchip vpu: remove some unused vars"
Reviewed-by: Ezequiel Garcia
Thanks,
Ezequiel
> Signed-off-by: Andrzej Pie
n other words, while patch 3/4
> changes what goes into which register, this patch changes when each
> register is written to. It also affects rk3288 and hasn't been
> tested with it.
>
I've just tested RK3288, and this series is indeed fixing
these issues. So for all pat
t; > > > > > diff --git a/drivers/staging/media/hantro/hantro_drv.c
> > > > > > b/drivers/staging/media/hantro/hantro_drv.c
> > > > > > index 6d9d41170832..9387619235d8 100644
> > > > > > --- a/drivers/staging/media/hantro/hantro_drv.c
> > > &
Hi Dan,
Thanks for the patch.
On Wed, 2020-01-08 at 08:35 +0300, Dan Carpenter wrote:
> This can't be NULL and we've already dereferenced it so let's remove
> the check.
>
> Signed-off-by: Dan Carpenter
> ---
> drivers/staging/media/hantro/hantro_v4l2.c | 2 +-
> 1 file changed, 1 insertion(+)
void _cedrus_write_ref_list(struct cedrus_ctx *ctx,
> if (buf_idx < 0)
> continue;
>
> - ref_buf = to_vb2_v4l2_buffer(ctx->dst_bufs[buf_idx]);
> + ref_buf = to_vb2_v4l2_buffer(cap_q->bufs[buf_id
Hi Jernej,
On Mon, 2019-06-03 at 13:38 +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote:
> > libvdpau-sunxi always disables engine after each decoded slice.
> > Do same in Cedrus driver.
> >
> > Presumably this also lowers power consumption whi
On Sat, 13 Jul 2019 at 13:43, Alex Dewar wrote:
>
> On 13/07/2019 16:17, Heiko Stuebner wrote:
> > Hi,
> >
> > Am Samstag, 13. Juli 2019, 13:38:45 CEST schrieb Alex Dewar:
> >> I initially thought my machine was failing to boot entirely, but it
> >> turns out it was just failing to start the displ
On Mon, 11 Mar 2019 at 18:40, Sam Ravnborg wrote:
>
> Hi Eze
> >
> > Why is this driver still here? I thought we migrated everyhing to
> > tinydrm already.
> Some have been ported, some are waiting for a user to do the port.
> If you looks at tinydrm you will see:
> ili9225.c ili9341.c
>
> And we
Hi everyone,
Dante: please avoid top-posting. In other words, put your replies in-line,
like I'm gonna do now. See below (and see how discussion goes on other threads).
On Mon, 11 Mar 2019 at 17:34, DANTE JAVIER PAZ wrote:
>
> Hello Sam, thank you very much for your comments,
> As I told Dan (my
On Mon, 2019-01-14 at 14:38 +0100, Paul Kocialkowski wrote:
> Introduce a new optional job_done operation, which allows calling back
> to the driver when a job is done. Since the job might be completed
> from interrupt context where some operations are not available, having
> a callback from non-at
dia/rockchip/vpu/rockchip_vpu_enc.c: In function
> 'rockchip_vpu_buf_prepare':
> drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:560:33: warning:
> variable 'vpu_fmt' set but not used [-Wunused-but-set-variable]
> const struct rockchip_vpu_fmt *v
On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote:
> This introduces the Cedrus VPU driver that supports the VPU found in
> Allwinner SoCs, also known as Video Engine. It is implemented through
> a v4l2 m2m decoder device and a media device (used for media requests).
> So far, it only supp
Hey Paul,
On Thu, 2018-08-09 at 11:04 +0200, Paul Kocialkowski wrote:
> This is the seventh iteration of the updated Cedrus driver,
> that supports the Video Engine found on most Allwinner SoCs, starting
> with the A10. It was tested on the A13, A20, A33 and H3.
>
> The initial version of this dr
On Wed, 2018-07-25 at 12:02 +0200, Paul Kocialkowski wrote:
> This introduces the Cedrus VPU driver that supports the VPU found in
> Allwinner SoCs, also known as Video Engine. It is implemented through
> a v4l2 m2m decoder device and a media device (used for media requests).
> So far, it only supp
65 matches
Mail list logo
