Re: [PATCH v7 0/7] clk: clk-wizard: clock-wizard: Driver updates

2021-01-21 Thread Miquel Raynal
Hi Shubhrajyoti, Shubhrajyoti Datta wrote on Wed, 4 Nov 2020 20:36:40 +0530: > In the thread [1] Greg suggested that we move the driver > to the clk from the staging. > Add patches to address the concerns regarding the fractional and > set rate support in the TODO. > > The patch set does the fo

Re: [PATCH] docs: dt: fix several broken doc references

2020-02-24 Thread Miquel Raynal
ings/net/wireless/siliabs,wfx.txt | 2 +- > 7 files changed, 8 insertions(+), 8 deletions(-) For the Cadence file, Reviewed-by: Miquel Raynal Thanks, Miquèl ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: Remove the mt29f_spinand driver

2018-11-06 Thread Miquel Raynal
Hi Greg, Greg Kroah-Hartman wrote on Mon, 5 Nov 2018 15:34:33 +0100: > On Mon, Nov 05, 2018 at 03:27:34PM +0100, Miquel Raynal wrote: > > Hi Greg, > > > > Greg Kroah-Hartman wrote on Mon, 5 Nov > > 2018 14:29:49 +0100: > > > > > On Mon, Nov 05, 201

Re: [PATCH] staging: Remove the mt29f_spinand driver

2018-11-05 Thread Miquel Raynal
Hi Greg, Greg Kroah-Hartman wrote on Mon, 5 Nov 2018 14:29:49 +0100: > On Mon, Nov 05, 2018 at 11:12:27AM +0100, Miquel Raynal wrote: > > Hi Greg, > > > > Boris Brezillon wrote on Mon, 22 Oct 2018 > > 22:10:59 +0200: > > > > > A new SPI NAND subsys

Re: [PATCH] staging: Remove the mt29f_spinand driver

2018-11-05 Thread Miquel Raynal
Hi Greg, Boris Brezillon wrote on Mon, 22 Oct 2018 22:10:59 +0200: > A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and > Micron's MT29F devices are now supported in > drivers/mtd/nand/spi/micron.c. > > Remove the old driver. > > Signed-off-by: Boris Brezillon > --- > Hello,

Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

2018-09-19 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Mon, 17 Sep 2018 10:29:39 +0200: > On Sat, 15 Sep 2018 19:54:40 +0200 > Miquel Raynal wrote: > > > Hi Boris, > > > > Boris Brezillon wrote on Fri, 7 Sep 2018 > > 00:38:32 +0200: > > > > > Hello, > >

Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

2018-09-15 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Fri, 7 Sep 2018 00:38:32 +0200: > Hello, > > This is the 2nd batch of API cleanup patches. This time we move > deprecated hooks/fields to the nand_legacy struct, and then move some > of the code found in nand_base.c into separate source/header files. > > Wit

Re: [PATCH v2 00/23] mtd: rawnand: Stop passing mtd_info to drivers

2018-09-06 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Thu, 6 Sep 2018 14:05:12 +0200: > Hello, > > This is the first set of patches aiming at cleaning the raw NAND API. > > This one focuses on inconsistencies we have in the API + the nand_chip > and nand_ecc_ctrl interfaces. Some functions/hooks are passed a >

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-01 Thread Miquel Raynal
Hi Dan, Dan Carpenter wrote on Wed, 1 Aug 2018 15:05:51 +0300: > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > > are necessary to address the correct page. The driver sets the address for > > more

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-13 Thread Miquel Raynal
Hi Boris, On Tue, 13 Feb 2018 09:17:14 +0100, Boris Brezillon wrote: > On Tue, 13 Feb 2018 08:42:46 +0100 > Miquel Raynal wrote: > > > Hi Boris, > > > > Just a few comments about the form. > > > > Otherwise: > > Reviewed-by: Miquel Raynal >

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-12 Thread Miquel Raynal
Hi Boris, Just a few comments about the form. Otherwise: Reviewed-by: Miquel Raynal > diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c > index 555b94406e0b..3d6c8ffd351f 100644 > --- a/drivers/mtd/devices/lart.c > +++ b/drivers/mtd/devices/lart.c > @

Re: [PATCH 5/5] mtd: nand: add ->exec_op() implementation

2017-12-01 Thread Miquel RAYNAL
Hi Boris, On Fri, 1 Dec 2017 10:50:53 +0100 Boris Brezillon wrote: > Hi Miquel, > > On Thu, 30 Nov 2017 23:25:38 +0100 > Miquel RAYNAL wrote: > > > > > diff --git a/drivers/mtd/nand/nand_base.c > > > > b/drivers/mtd/nand/nand_base.c index 52965a8a

Re: [PATCH 5/5] mtd: nand: add ->exec_op() implementation

2017-11-30 Thread Miquel RAYNAL
> > diff --git a/drivers/mtd/nand/nand_base.c > > b/drivers/mtd/nand/nand_base.c index 52965a8aeb2c..46bf31aff909 > > 100644 --- a/drivers/mtd/nand/nand_base.c > > +++ b/drivers/mtd/nand/nand_base.c > > @@ -689,6 +689,59 @@ static void nand_wait_status_ready(struct > > mtd_info *mtd, unsigned long

Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-11-30 Thread Miquel RAYNAL
> > diff --git a/drivers/mtd/nand/nand_base.c > > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095 > > 100644 --- a/drivers/mtd/nand/nand_base.c > > +++ b/drivers/mtd/nand/nand_base.c > > @@ -3077,7 +3077,7 @@ int nand_erase_nand(struct mtd_info *mtd, > > struct erase_info *instr, st

[PATCH 3/5] mtd: nand: force drivers to explicitly send READ/PROG commands

2017-11-30 Thread Miquel Raynal
and relevant drivers to make NAND_ECC_CUSTOM_PAGE_ACCESS the default case, and remove this flag. Signed-off-by: Boris Brezillon [miquel.ray...@free-electrons.com: tested, fixed and rebased on nand/next] Signed-off-by: Miquel Raynal --- drivers/mtd/nand/atmel/nand-controller.c | 7 ++- d

[PATCH 2/5] mtd: nand: provide several helpers to do common NAND operations

2017-11-30 Thread Miquel Raynal
we can easily modify those helpers to make use of the new ->exec_op() interface when available. Signed-off-by: Boris Brezillon [miquel.ray...@free-electrons.com: rebased and fixed some conflicts] Signed-off-by: Miquel Raynal --- drivers/mtd/nand/atmel/nand-controller.c |2 +- drivers/mtd/nand

[PATCH 5/5] mtd: nand: add ->exec_op() implementation

2017-11-30 Thread Miquel Raynal
report whether the command is supported or not by a given controller, which was not possible before. Suggested-by: Boris Brezillon Signed-off-by: Miquel Raynal --- drivers/mtd/nand/nand_base.c | 1037 +++-- drivers/mtd/nand/nand_hynix.c |9 + include/linu

[PATCH 4/5] mtd: nand: use a static data_interface in the nand_chip structure

2017-11-30 Thread Miquel Raynal
safely. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/nand_base.c| 44 ++--- drivers/mtd/nand/nand_timings.c | 21 +--- include/linux/mtd/rawnand.h | 7 ++- 3 files changed, 26 insertions(+), 46 deletions(-) diff --git a/drivers

[PATCH 0/5] Introduce the new NAND core interface: ->exec_op()

2017-11-30 Thread Miquel Raynal
nd: provide several helpers to do common NAND operations mtd: nand: force drivers to explicitly send READ/PROG commands Miquel Raynal (3): mtd: nand: use usual return values for the ->erase() hook mtd: nand: use a static data_interface in the nand_chip structure mtd: nand: add ->exec_op()

[PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

2017-11-30 Thread Miquel Raynal
Avoid using specific defined values for checking returned status of the ->erase() hook. Instead, use usual negative error values on failure, zero otherwise. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/denali.c| 2 +- drivers/mtd/nand/docg4.c | 7 ++- drivers/mtd/n

Re: [RFC 05/12] dt-bindings: mtd: add Marvell NAND controller documentation

2017-11-06 Thread Miquel RAYNAL
Hi Rob, > > +Required properties: > > +C'est faux, t'en a rajouté un y a pas longtps :). > > +Je conseille de mettre ça sous forme de liste, genre > > Humm. Oops! > > > + > > +- compatible: can be one of the following: > > +* "marvell,armada-8k-nand-controller" > > +* "marvell,armada

[RFC 07/12] ARM: dts: armada-370-xp: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
,nand-enable-arbiter' property, inefective with Armada boards. Signed-off-by: Miquel Raynal --- arch/arm/boot/dts/armada-370-db.dts| 56 arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 119 arch/arm/boot/dts/armada-370-mirabox.dts

[RFC 12/12] ARM64: dts: marvell: use reworked NAND controller driver on Armada 7K/8K

2017-10-18 Thread Miquel Raynal
,nand-enable-arbiter' property, inefective with Armada boards. Signed-off-by: Miquel Raynal --- arch/arm64/boot/dts/marvell/armada-7040-db.dts | 47 +- .../boot/dts/marvell/armada-cp110-master.dtsi | 6 +-- .../arm64/boot/dts/marvell/armada-cp110-slave.dtsi |

[RFC 10/12] ARM: dts: armada-39x: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
,nand-enable-arbiter' property, inefective with Armada boards. Signed-off-by: Miquel Raynal --- arch/arm/boot/dts/armada-390-db.dts | 65 + arch/arm/boot/dts/armada-395-gp.dts | 73 +++-- arch/arm/boot/dts/armada-398-d

[RFC 08/12] ARM: dts: armada-375: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
,nand-enable-arbiter' property, inefective with Armada boards. Signed-off-by: Miquel Raynal --- arch/arm/boot/dts/armada-375-db.dts | 49 ++--- arch/arm/boot/dts/armada-375.dtsi | 6 ++--- 2 files changed, 32 insertions(+), 23 deletions(-) diff --git a/arc

[RFC 01/12] mtd: nand: provide several helpers to do common NAND operations

2017-10-18 Thread Miquel Raynal
we can easily modify those helpers to make use of the new ->exec_op() interface when available. Signed-off-by: Boris Brezillon [miquel.ray...@free-electrons.com: rebased and fixed some conflicts] Signed-off-by: Miquel Raynal --- drivers/mtd/nand/atmel/nand-controller.c | 2 +- drivers/mtd/nand

[RFC 11/12] ARM: dts: pxa: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
Change the bindings to use the reworked Marvell NAND controller driver. Also adapt the nand controller node organization to distinguish which property is relevant for the controller, and which one is NAND chip specific. Expose the partitions as a subnode of the NAND chip. Signed-off-by: Miquel

[RFC 05/12] dt-bindings: mtd: add Marvell NAND controller documentation

2017-10-18 Thread Miquel Raynal
Document the bindings for the legacy and the new bindings relative to Marvell NAND controller driver rework. Signed-off-by: Miquel Raynal --- .../devicetree/bindings/mtd/marvell-nand.txt | 95 ++ 1 file changed, 95 insertions(+) create mode 100644 Documentation

[RFC 06/12] mtd: nand: add reworked Marvell NAND controller driver

2017-10-18 Thread Miquel Raynal
hierarchical view has to be used to keep the controller and the NAND chip structures clearly separated both inside the device tree and also in the driver code. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/Kconfig| 11 + drivers/mtd/nand/Makefile |1 + drivers/mtd/nand/m

[RFC 04/12] mtd: nand: add ->exec_op() implementation

2017-10-18 Thread Miquel Raynal
vers writing. This new interface should really ease the support of new vendor specific instructions. Suggested-by: Boris Brezillon Signed-off-by: Miquel Raynal --- drivers/mtd/nand/denali.c | 93 +++- drivers/mtd/nand/nand_base.c | 949 +++-- driv

[RFC 03/12] mtd: nand: use a static data_interface in the nand_chip structure

2017-10-18 Thread Miquel Raynal
to data_interface was not referenced yet. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/nand_base.c| 35 ++- drivers/mtd/nand/nand_timings.c | 23 ++- include/linux/mtd/rawnand.h | 9 ++--- 3 files changed, 18 insertions(+),

[RFC 00/12] Marvell NAND controller rework with ->exec_op()

2017-10-18 Thread Miquel Raynal
veral helpers to do common NAND operations mtd: nand: force drivers to explicitly send READ/PROG commands Miquel Raynal (10): mtd: nand: use a static data_interface in the nand_chip structure mtd: nand: add ->exec_op() implementation dt-bindings: mtd: add Marvell NAND controller d

[RFC 09/12] ARM: dts: armada-38x: use reworked NAND controller driver

2017-10-18 Thread Miquel Raynal
,nand-enable-arbiter' property, inefective with Armada boards. Signed-off-by: Miquel Raynal --- arch/arm/boot/dts/armada-385-db-ap.dts | 68 ++-- arch/arm/boot/dts/armada-385-linksys-caiman.dts | 129 +++--- arch/arm/boot/dts/armada-385-linksys-cobra.

[RFC 02/12] mtd: nand: force drivers to explicitly send READ/PROG commands

2017-10-18 Thread Miquel Raynal
and relevant drivers to make NAND_ECC_CUSTOM_PAGE_ACCESS the default case, and remove this flag. Signed-off-by: Boris Brezillon [miquel.ray...@free-electrons.com: rebased and fixed some conflicts] Signed-off-by: Miquel Raynal --- drivers/mtd/nand/atmel/nand-controller.c | 7 ++- drivers/mtd/nand/bf5xx