Re: [PATCH v4] staging: nvec: change usage of slave to secondary

2020-08-02 Thread Rohit K Bharadwaj
On 02/08/20 1:43 pm, Marc Dietrich wrote: > Hello Rohit, > > On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote: > >> changed usage of slave (which is deprecated) to secondary without breaking >> the driver >> >> Tested-by: Dan Carpenter >> Acked-by

Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote: > Em Sun, 26 Jul 2020 14:35:12 +0530 > Rohit K Bharadwaj escreveu: > >> this patch fixes style of open brace after functions and if statements >> >> Signed-off-by: Rohit K Bharadwaj > >> @@ -119,8 +121,9 @@

Re: [PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:42 pm, Greg KH wrote: > On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote: >> this patch fixes the coding style of block comments. >> >> Signed-off-by: Rohit K Bharadwaj >> --- >> v3: change patch subject prefix >> v2: split pat

[PATCH v3 4/4] staging: media: atomisp: fix line length exceeds

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the line length exceeded error from checkpatch.pl Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 ++- 1 file

[PATCH v3 3/4] staging: media: atomisp: fix trailing statement of if

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the error from checkpatch.pl which says that trailing statements after if keyword to be on next line Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch drivers/staging

[PATCH v3 2/4] staging: media: atomisp: fix style of open brace

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes style of open brace after functions and if statements Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 29

[PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments. Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 28 +-- 1 file

Re: [PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:18 pm, Rohit K Bharadwaj wrote: > this patch fixes the coding style of block comments. > > Signed-off-by: Rohit K Bharadwaj > --- > v2: split patch into sequence of patches > v1: fix all coding style issues in single patch > > .../media/atomisp/pci/sh_c

[PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments. Signed-off-by: Rohit K Bharadwaj --- v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 28 +-- 1 file changed, 19 insertions(+), 9

[PATCH] staging: media: atomisp: fix code style issues

2020-07-25 Thread Rohit K Bharadwaj
this patch fixes the warnings and errors generated after running checkpatch.pl on pci/sh_css_firmware.c Signed-off-by: Rohit K Bharadwaj --- .../media/atomisp/pci/sh_css_firmware.c | 62 +++ 1 file changed, 36 insertions(+), 26 deletions(-) diff --git a/drivers/staging

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

2020-07-25 Thread Rohit K Bharadwaj
On 25/07/20 6:20 pm, Michał Mirosław wrote: > On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: >> On 25/07/20 5:31 pm, Michał Mirosław wrote: >>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: >>>> changed usage of slave (whi

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

2020-07-25 Thread Rohit K Bharadwaj
On 25/07/20 5:31 pm, Michał Mirosław wrote: > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: >> changed usage of slave (which is deprecated) to secondary without breaking >> the driver > > The relevant I2C and SMBus standards use master/slave termi

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

2020-07-24 Thread Rohit K Bharadwaj
On 25/07/20 2:12 am, Marc Dietrich wrote: > > Hi Rohit, > > On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote: > >> On 24/07/20 10:06 pm, Marc Dietrich wrote: >>> >>> >>> On Fri, 24 Jul 2020, Marc Dietrich wrote: >>> >>>> Hi Rohit

[PATCH v4] staging: nvec: change usage of slave to secondary

2020-07-24 Thread Rohit K Bharadwaj
changed usage of slave (which is deprecated) to secondary without breaking the driver Tested-by: Dan Carpenter Acked-by: Marc Dietrich Signed-off-by: Rohit K Bharadwaj --- v4: undo the changes (which broke the driver) to this line: if (of_property_read_u32(dev->of_node, "slave-addr

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

2020-07-24 Thread Rohit K Bharadwaj
+0530, Rohit Bharadwaj wrote: >>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote: >>>>>> changed usage of slave (deprecated) to secondary >>>>>> >>>>>> Signed-off-by: Rohit K Bharadwaj >>>>>> --- >>>

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

2020-07-24 Thread Rohit K Bharadwaj
On 24/07/20 7:39 pm, Dan Carpenter wrote: > On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote: >> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) >> platform_set_drvdata(pdev, nvec); >> nvec->dev = dev; >> &g

[PATCH v3] staging: nvec: change usage of slave to secondary

2020-07-23 Thread Rohit K Bharadwaj
changed usage of slave (deprecated) to secondary Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject, add version history v2: add changelog text in body of mail v1: fix style issues by changing usage of slave to secondary drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed

[PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Rohit K Bharadwaj
changed usage of slave (deprecated) to secondary Signed-off-by: Rohit K Bharadwaj --- drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..5d7b66719a39 100644

[PATCH] change slave occurence to secondary everywhere

2020-07-23 Thread Rohit K Bharadwaj
Signed-off-by: Rohit K Bharadwaj --- drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..5d7b66719a39 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers