Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody

2019-10-31 Thread Theodore Y. Ts'o
On Wed, Oct 30, 2019 at 09:07:33PM -0400, Valdis Kletnieks wrote: > Three questions: (a) ACK/NAK on this patch, (b) should it be all in one > patch, or one to add to errno.h and 6 patches for 6 filesystems?), and > (c) if one patch, who gets to shepherd it through? Acked-by: Theodore Ts'o ___

Re: [PATCH] erofs: move erofs out of staging

2019-08-20 Thread Theodore Y. Ts'o
On Wed, Aug 21, 2019 at 12:35:08AM +0800, Gao Xiang wrote: > > For EROFS, it's a special case since it is a RO fs, and erofs mkfs > will generate reproducable images (which means, for one dir trees, > it only generates exact one result except for build time). Agreed, and given that, doing the fuz

Re: [PATCH] erofs: move erofs out of staging

2019-08-20 Thread Theodore Y. Ts'o
On Tue, Aug 20, 2019 at 10:24:11AM +0800, Chao Yu wrote: > Out of curiosity, it looks like every mainstream filesystem has its own > fuzz/injection tool in their tool-set, if it's really such a generic > requirement, why shouldn't there be a common tool to handle that, let > specified > filesystem

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Theodore Y. Ts'o
On Sun, Aug 18, 2019 at 07:06:40PM +0200, Richard Weinberger wrote: > > So holding a file system like EROFS to a higher standard than say, > > ext4, xfs, or btrfs hardly seems fair. > > Nobody claimed that. Pointing out that erofs has issues in this area when Gao Xiang is asking if erofs can be m

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Theodore Y. Ts'o
On Sun, Aug 18, 2019 at 08:58:12AM -0700, Christoph Hellwig wrote: > On Sun, Aug 18, 2019 at 11:11:54AM -0400, Theodore Y. Ts'o wrote: > > Note that of the mainstream file systems, ext4 and xfs don't guarantee > > that it's safe to blindly take maliciously provided f

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Theodore Y. Ts'o
On Sun, Aug 18, 2019 at 11:21:13AM +0200, Richard Weinberger wrote: > > Not to say that erofs shouldn't be worked on to fix these kinds of > > issues, just that it's not an unheard of thing to trust the disk image. > > Especially for the normal usage model of erofs, where the whole disk > > image i

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Theodore Y. Ts'o
On Mon, Jul 22, 2019 at 10:16:44PM +0800, Gao Xiang wrote: > OK, I will give a try. One point I think is how to deal with the case > if there is already cached information when remounting as well as you said. > > As the first step, maybe the mount option can be defined as > allowing/forbiding cachi

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Theodore Y. Ts'o
On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: > > The number of individual Kconfig options is quite high, are you sure you > > need them to be split like that? > > You mean the above? these are 3 cache strategies, which impact the > runtime memory consumption and performance. I tend t

Re: leaking path in android binder: set_nice

2018-09-25 Thread Theodore Y. Ts'o
On Tue, Sep 25, 2018 at 01:52:57PM -0400, Stephen Smalley wrote: > On 09/25/2018 01:27 PM, Tong Zhang wrote: > > Kernel Version: 4.18.5 > > > > Problem Description: > > > > When setting nice value, it is checked by LSM function > > security_task_setnice(). > > see kernel/sched/core.c:3972 SYSCAL