Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-09-07 Thread Martijn Coenen
> Any progress on this problem? A patch was recently submitted to address this: https://lkml.org/lkml/2018/8/7/802 > >> >>> Without disabling by default or latelimit printk(), the system shall become >>> unusable. >>> >>> $ grep binder: log | wc -l >>> 13214 >>> $ head log >>> [ 1167.389978] bi

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-09-07 Thread Tetsuo Handa
On 2018/07/10 21:40, Martijn Coenen wrote: > On Tue, Jul 10, 2018 at 2:09 PM, Tetsuo Handa > wrote: >> I don't have benchmark data (I'm not an Android user). But an example log at >> https://syzkaller.appspot.com/text?tag=CrashLog&x=12f316fc40 got >> about 13214 messages in 124 seconds (over 1

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-10 Thread Martijn Coenen
On Tue, Jul 10, 2018 at 2:09 PM, Tetsuo Handa wrote: > I don't have benchmark data (I'm not an Android user). But an example log at > https://syzkaller.appspot.com/text?tag=CrashLog&x=12f316fc40 got > about 13214 messages in 124 seconds (over 100 messages per a second). I meant data for the c

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-10 Thread Tetsuo Handa
On 2018/07/09 23:29, Tetsuo Handa wrote: > On 2018/07/09 23:02, Martijn Coenen wrote: >> On Mon, Jul 9, 2018 at 3:27 PM, Dmitry Vyukov wrote: >>> I know almost nothing about binder. How these debug messages are >>> enabled? I don't see anything like CONFIG_BINDER_VERBOSE_DEBUG in the >>> config:

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-09 Thread Tetsuo Handa
On 2018/07/09 23:02, Martijn Coenen wrote: > On Mon, Jul 9, 2018 at 3:27 PM, Dmitry Vyukov wrote: >> I know almost nothing about binder. How these debug messages are >> enabled? I don't see anything like CONFIG_BINDER_VERBOSE_DEBUG in the >> config: >> https://github.com/google/syzkaller/blob/mas

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-09 Thread Martijn Coenen
On Mon, Jul 9, 2018 at 3:27 PM, Dmitry Vyukov wrote: > I know almost nothing about binder. How these debug messages are > enabled? I don't see anything like CONFIG_BINDER_VERBOSE_DEBUG in the > config: > https://github.com/google/syzkaller/blob/master/dashboard/config/upstream-kasan.config > Also

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-09 Thread Tetsuo Handa
t; Date: Mon, 9 Jul 2018 09:54:01 +0900 >> Subject: [PATCH] ANDROID: binder: Latelimit binder_debug(). >> >> syzbot is reporting hung tasks [1] [2]. This might be due to flooding of >> printk() messages from binder subsystem, for NMI backtrace says the CPU >> was busy

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2018 at 10:10:34AM +0900, Tetsuo Handa wrote: > >From 62ddef96020cb397dcbf4b8574f1859b32f983de Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Mon, 9 Jul 2018 09:54:01 +0900 > Subject: [PATCH] ANDROID: binder: Latelimit binder_debug(). > > syzbot is re

Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-09 Thread Martijn Coenen
On Mon, Jul 9, 2018 at 3:10 AM, Tetsuo Handa wrote: > While at it, let's add cond_resched() to binder_thread_write(), > binder_transaction() and binder_release_work() loops because they might > take long time. This should be a separate patch, and I would love to see some benchmark data around thi

[PATCH] ANDROID: binder: Latelimit binder_debug().

2018-07-08 Thread Tetsuo Handa
>From 62ddef96020cb397dcbf4b8574f1859b32f983de Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Mon, 9 Jul 2018 09:54:01 +0900 Subject: [PATCH] ANDROID: binder: Latelimit binder_debug(). syzbot is reporting hung tasks [1] [2]. This might be due to flooding of printk() messages from bin