Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

2017-11-22 Thread Joe Perches
On Wed, 2017-11-22 at 18:33 +0100, Patryk Kocielnik wrote: > Joe, > > Thank you for your comments! > > I did compile it beforehand and it was clean. Did I miss anything? You also have to compile it afterhand... i.e.: with your patch applied $ make allyesconfig [] $ make drivers/staging/sm750fb

Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

2017-11-22 Thread Patryk Kocielnik
Joe, Thank you for your comments! > checkpatch is not always correct. I did compile it beforehand and it was clean. Did I miss anything? Regards, Patryk On 22 November 2017 at 18:33, Patryk Kocielnik wrote: > Joe, > > Thank you for your comments! > > I did compile it beforehand and it was cle

Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

2017-11-22 Thread Joe Perches
On Wed, 2017-11-22 at 16:42 +0100, Patryk Kocielnik wrote: > Cleaned checkpatch warnings by fixing coding style issues. checkpatch is not always correct. > Signed-off-by: Patryk Kocielnik > --- > drivers/staging/sm750fb/sm750.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > di

[PATCH] Staging: sm750fb: sm750: fixed coding style issues

2017-11-22 Thread Patryk Kocielnik
Cleaned checkpatch warnings by fixing coding style issues. Signed-off-by: Patryk Kocielnik --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 67207b055..41beeb9b9 1006