Hi Ashish,
On 18/04/2021 03:26, Ashish Kalra wrote:
> On Sat, Apr 17, 2021 at 08:56:13PM +0200, Mauro Carvalho Chehab wrote:
>> Em Sat, 17 Apr 2021 21:06:27 +0530
>> Ashish Kalra escreveu:
>>
>>> Upon running sparse, "warning: dubious: !x | !y" is brought to notice
>>> for this file. Logical and
On Sat, Apr 17, 2021 at 09:31:32PM +, David Laight wrote:
> From: Mauro Carvalho Chehab
> > Sent: 17 April 2021 19:56
> >
> > Em Sat, 17 Apr 2021 21:06:27 +0530
> > Ashish Kalra escreveu:
> >
> > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> > > for this file. Lo
From: Dan Carpenter
> Sent: 20 April 2021 11:28
>
> On Sat, Apr 17, 2021 at 09:31:32PM +, David Laight wrote:
> > From: Mauro Carvalho Chehab
> > > Sent: 17 April 2021 19:56
> > >
> > > Em Sat, 17 Apr 2021 21:06:27 +0530
> > > Ashish Kalra escreveu:
> > >
> > > > Upon running sparse, "warning
On Sat, Apr 17, 2021 at 09:31:32PM +, David Laight wrote:
> > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> > > for this file. Logical and bitwise OR are basically the same in this
> > > context so it doesn't cause a runtime bug. But let's change it to
> > > logica
ut_info || !vf_info)
>
>
> > return -EINVAL;
> >
> > out_width = out_info->res.width;
>
>
>
> Thanks,
> Mauro
Updated Patch as per your feedback
Thanks
Ashish
>From 770317157c3a7abf2fda1d71b0bd651c33bf0bfa Mon Sep 17 00:00:00 2001
From: Ashish Kalra
Date: Sun, 18
On Sat, Apr 17, 2021 at 09:31:32PM +, David Laight wrote:
> From: Mauro Carvalho Chehab
> > Sent: 17 April 2021 19:56
> >
> > Em Sat, 17 Apr 2021 21:06:27 +0530
> > Ashish Kalra escreveu:
> >
> > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> > > for this file. Lo
From: Mauro Carvalho Chehab
> Sent: 17 April 2021 19:56
>
> Em Sat, 17 Apr 2021 21:06:27 +0530
> Ashish Kalra escreveu:
>
> > Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> > for this file. Logical and bitwise OR are basically the same in this
> > context so it doesn't
Em Sat, 17 Apr 2021 21:06:27 +0530
Ashish Kalra escreveu:
> Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> for this file. Logical and bitwise OR are basically the same in this
> context so it doesn't cause a runtime bug. But let's change it to
> logical OR to make it cl
Upon running sparse, "warning: dubious: !x | !y" is brought to notice
for this file. Logical and bitwise OR are basically the same in this
context so it doesn't cause a runtime bug. But let's change it to
logical OR to make it cleaner and silence the Sparse warning.
Signed-off-by: Ashish Kalra
