Re: [PATCH] media: atomisp: stop compiling compat_ioctl32 code

2020-10-07 Thread Arnd Bergmann
On Wed, Oct 7, 2020 at 4:18 PM Christoph Hellwig wrote: > > On Wed, Oct 07, 2020 at 04:16:39PM +0200, Arnd Bergmann wrote: > > Alternatively, the entire file could just be removed, since anyone > > willing to restore the functionality can equally well just look up > > the contents in the git histo

Re: [PATCH] media: atomisp: stop compiling compat_ioctl32 code

2020-10-07 Thread Christoph Hellwig
On Wed, Oct 07, 2020 at 04:16:39PM +0200, Arnd Bergmann wrote: > Alternatively, the entire file could just be removed, since anyone > willing to restore the functionality can equally well just look up > the contents in the git history if needed. I suspect that is the right thing. Note that given

[PATCH] media: atomisp: stop compiling compat_ioctl32 code

2020-10-07 Thread Arnd Bergmann
This is one of the last remaining users of compat_alloc_user_space() and copy_in_user(), which are in the process of getting removed. As of commit 57e6b6f2303e ("media: atomisp_fops.c: disable atomisp_compat_ioctl32"), nothing in this file is actually getting used as the only reference has been st