Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-06-19 Thread Christoph Hellwig
FYI, I've also got another driver in progress that will need domains assigned outside the ACPI range, so it's not just limited to VMD. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-d

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-06-19 Thread Bjorn Helgaas
[+cc Christoph] On Wed, May 24, 2017 at 01:39:15PM -0700, Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch uses the lower 16 bits of the serial number as PCI > domain, otherwise some drivers may not be able to handle it. > > Besides Nvidia drivers, we also found X.org, and DPDK handle

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-25 Thread Stephen Hemminger
On Thu, 25 May 2017 14:19:55 +0100 Alan Cox wrote: > > > Signed-off-by: Haiyang Zhang > > > --- > > > > According to Stephen Hemminger , there are > > additional programs, like X.org, DPDK, are also using 16-bit only > > PCI domain numbers. So, I'm submitting this patch for re-consideration

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-25 Thread Alan Cox
> > Signed-off-by: Haiyang Zhang > > --- > > According to Stephen Hemminger , there are > additional programs, like X.org, DPDK, are also using 16-bit only > PCI domain numbers. So, I'm submitting this patch for re-consideration. The correct way to handle this is to send the needed patches to

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-25 Thread Christoph Hellwig
On Wed, May 24, 2017 at 01:39:15PM -0700, Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch uses the lower 16 bits of the serial number as PCI > domain, otherwise some drivers may not be able to handle it. > > Besides Nvidia drivers, we also found X.org, and DPDK handle > only 16 bit PCI

RE: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-24 Thread Haiyang Zhang
redhat.com; driverdev- > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org > Subject: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain > > [This sender failed our fraud detection checks and may not be who they > appear to be. Learn about spoofing at http://aka.ms/Le

[PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-24 Thread Haiyang Zhang
From: Haiyang Zhang This patch uses the lower 16 bits of the serial number as PCI domain, otherwise some drivers may not be able to handle it. Besides Nvidia drivers, we also found X.org, and DPDK handle only 16 bit PCI domain. Signed-off-by: Haiyang Zhang --- drivers/pci/host/pci-hyperv.c |

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-25 Thread John Hubbard
On Tue, 25 Apr 2017, Christoph Hellwig wrote: > Hi John, > > please fix your quoting of the previous mails, thanks! Shoot, sorry about any quoting issues. I'm sufficiently new to conversing on these lists that I'm not even sure which mistake I made. > > > What ACPI defines does not matter at

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-25 Thread Christoph Hellwig
Hi John, please fix your quoting of the previous mails, thanks! What ACPI defines does not matter at all. Linux uses 32-bit domains IDs, and on x86 specifily uses those for non-ACPI enumarated domains (e.g. VMD). You've also not demontrated any issue with any Linux driver yet. > Also...it wou

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-25 Thread Dan Carpenter
On Mon, Apr 24, 2017 at 04:06:37PM -0700, John Hubbard wrote: > First, a tiny nit about the patch: it would be good to add "Fixing a problem > that was introduced with commit <4a9b0933bdfc>", in the patch commit > message. > Please use the Fixes tag. Fixes: 123456789012 ("blah blah blah") regar

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-24 Thread John Hubbard
-devel@linuxdriverproject.org; linux- ker...@vger.kernel.org Subject: Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain On Thu, Apr 20, 2017 at 11:35 AM, Haiyang Zhang wrote: From: Haiyang Zhang This patch uses the lower 16 bits of the serial number as PCI domain, otherwise some

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Christoph Hellwig
On Thu, Apr 20, 2017 at 06:37:35PM +, Haiyang Zhang wrote: > It's Nvidia driver. Which of the many nvidia drivers in the tree? Just fix it instead of coming up with stupid workarounds like this. ___ devel mailing list de...@linuxdriverproject.org ht

RE: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Haiyang Zhang
verproject.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain > > On Thu, Apr 20, 2017 at 11:35 AM, Haiyang Zhang > wrote: > > From: Haiyang Zhang > > > > This patch uses the lower 16 bits of the serial nu

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Bjorn Helgaas
On Thu, Apr 20, 2017 at 11:35 AM, Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch uses the lower 16 bits of the serial number as PCI > domain, otherwise some drivers may not be able to handle it. Can you give any more details about this? Which drivers, for instance? Why do drivers ca

[PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Haiyang Zhang
From: Haiyang Zhang This patch uses the lower 16 bits of the serial number as PCI domain, otherwise some drivers may not be able to handle it. Signed-off-by: Haiyang Zhang --- drivers/pci/host/pci-hyperv.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pci/