Re: [PATCH] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-16 Thread Lidza Louina
On 05/13/2016 12:43 PM, Drokin, Oleg wrote: On May 12, 2016, at 6:33 PM, Lidza Louina wrote: The lustre_msg_buf method could return NULL. Subsequent code didn't check if it's null before using it. This patch adds two checks. Thank you for the patch, it looks good code-wise, but there are som

Re: [PATCH] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-13 Thread Drokin, Oleg
On May 12, 2016, at 6:33 PM, Lidza Louina wrote: > The lustre_msg_buf method could return NULL. Subsequent code didn't > check if it's null before using it. This patch adds two checks. Thank you for the patch, it looks good code-wise, but there are some style issues. > > Signed-off-by: Li

[PATCH] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-12 Thread Lidza Louina
The lustre_msg_buf method could return NULL. Subsequent code didn't check if it's null before using it. This patch adds two checks. Signed-off-by: Lidza Louina diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c b/drivers/staging/lustre/lustre/ptlrpc/sec.c index 187fd1d..e6fedc3 100644