Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Greg Kroah-Hartman
On Tue, Sep 19, 2017 at 12:20:15PM +0200, Benjamin Gaignard wrote: > 2017-09-19 12:15 GMT+02:00 Tomas Winkler : > > On Tue, Sep 19, 2017 at 1:07 PM, Benjamin Gaignard > > wrote: > >> 2017-09-19 11:40 GMT+02:00 Dan Carpenter : > >>> On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote:

Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
2017-09-19 12:15 GMT+02:00 Tomas Winkler : > On Tue, Sep 19, 2017 at 1:07 PM, Benjamin Gaignard > wrote: >> 2017-09-19 11:40 GMT+02:00 Dan Carpenter : >>> On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote: -static int validate_ioctl_arg(unsigned int cmd, union ion_ioctl_arg *a

Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Tomas Winkler
On Tue, Sep 19, 2017 at 1:07 PM, Benjamin Gaignard wrote: > 2017-09-19 11:40 GMT+02:00 Dan Carpenter : >> On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote: >>> -static int validate_ioctl_arg(unsigned int cmd, union ion_ioctl_arg *arg) >>> +static int validate_ioctl_arg(struct file

Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
2017-09-19 11:40 GMT+02:00 Dan Carpenter : > On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote: >> -static int validate_ioctl_arg(unsigned int cmd, union ion_ioctl_arg *arg) >> +static int validate_ioctl_arg(struct file *filp, >> + unsigned int cmd, union i

Re: [PATCH] staging: ion: create one device entry per heap

2017-09-19 Thread Dan Carpenter
On Mon, Sep 18, 2017 at 04:58:46PM +0200, Benjamin Gaignard wrote: > -static int validate_ioctl_arg(unsigned int cmd, union ion_ioctl_arg *arg) > +static int validate_ioctl_arg(struct file *filp, > + unsigned int cmd, union ion_ioctl_arg *arg) > { > int ret = 0; > +

[PATCH] staging: ion: create one device entry per heap

2017-09-18 Thread Benjamin Gaignard
Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id match wit