On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ int err;
> >> >+
> >> >+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
> >> >+ D3_DELINK_MODE_EN, 0x00);
> >> >+ if (err < 0)
> >
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +};
> >> >+
> >> >+void rts524a_init_params(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ rts5249_init_params(pcr);
> >> >+
> >> >+ pcr->ops = &rts524a_pcr_ops;
> >> >+}
> > I see a couple of these now. Why don't you make
On 01/18/2015 08:20 PM, Lee Jones wrote:
>> +};
>> >+
>> >+void rts524a_init_params(struct rtsx_pcr *pcr)
>> >+{
>> >+ rts5249_init_params(pcr);
>> >+
>> >+ pcr->ops = &rts524a_pcr_ops;
>> >+}
> I see a couple of these now. Why don't you make 'ops' a parameter of
> *_init_params().
>
*_init_p
On 01/18/2015 08:20 PM, Lee Jones wrote:
>> +static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
>> >+{
>> >+ int err;
>> >+
>> >+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
>> >+ D3_DELINK_MODE_EN, 0x00);
>> >+ if (err < 0)
>> >+ return err;
> if (err)
>
err
On 01/18/2015 08:20 PM, Lee Jones wrote:
>> @@ -72,8 +72,10 @@ static void rts5249_fetch_vendor_settings(struct rtsx_pcr
>> *pcr)
>> >rtsx_pci_read_config_dword(pcr, PCR_SETTING_REG1, ®);
>> >dev_dbg(&(pcr->pci->dev), "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG1, reg);
>> >
>> >- if (!rtsx_ve
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> add support for new chip rts524A.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/rts5249.c| 112
> +++
> drivers/mfd/rtsx_pcr.c | 5 ++
> drivers/mfd/rts
From: Micky Ching
add support for new chip rts524A.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 112 +++
drivers/mfd/rtsx_pcr.c | 5 ++
drivers/mfd/rtsx_pcr.h | 4 ++
include/linux/mfd/rtsx_pci.h | 87 ++