RE: [PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

2013-12-17 Thread Hartley Sweeten
On Tuesday, December 17, 2013 10:58 AM, gre...@linuxfoundation.org wrote: > On Tue, Dec 10, 2013 at 10:58:59AM +, Ian Abbott wrote: >> On 2013-12-09 22:30, H Hartley Sweeten wrote: >>>There is only one ai subdevice in this driver so there is no reason >>>to hold the last sample written to each

Re: [PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

2013-12-17 Thread gre...@linuxfoundation.org
On Tue, Dec 10, 2013 at 10:58:59AM +, Ian Abbott wrote: > On 2013-12-09 22:30, H Hartley Sweeten wrote: > >There is only one ai subdevice in this driver so there is no reason > >to hold the last sample written to each channel in the subdevice > >private data. Move the data into the device priva

Re: [PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

2013-12-10 Thread Ian Abbott
On 2013-12-09 22:30, H Hartley Sweeten wrote: There is only one ai subdevice in this driver so there is no reason to hold the last sample written to each channel in the subdevice private data. Move the data into the device private data, This gets some of the data out of the subdevice private dat

[PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

2013-12-09 Thread H Hartley Sweeten
There is only one ai subdevice in this driver so there is no reason to hold the last sample written to each channel in the subdevice private data. Move the data into the device private data, This gets some of the data out of the subdevice private data union and removes some of the uses of the ugly