Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread Stefan Roese
On 04.02.19 09:53, Mark Brown wrote: On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: It is extremely common in the kernel for a file to start // SPDX-License-Identifier. and to have that immediately followed by a comment lile: /* * . * Yes, there

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread NeilBrown
On Mon, Feb 04 2019, Mark Brown wrote: > On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: > >> It is extremely common in the kernel for a file to start >>// SPDX-License-Identifier. > >> and to have that immediately followed by a comment lile: > >> /* >> * . >> *

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread Mark Brown
On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: > It is extremely common in the kernel for a file to start >// SPDX-License-Identifier. > and to have that immediately followed by a comment lile: > /* > * . > * Yes, there was a lot of automated conversion AFAIC

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-03 Thread NeilBrown
On Fri, Feb 01 2019, Mark Brown wrote: > On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote: > >> @@ -1,3 +1,4 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> /* >> * spi-mt7621.c -- MediaTek MT7621 SPI controller driver >> * > > Please convert the entire comment into a C++ comment so

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-01 Thread Mark Brown
On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote: > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * spi-mt7621.c -- MediaTek MT7621 SPI controller driver > * Please convert the entire comment into a C++ comment so it looks more intentional. signature.asc Descrip

[PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-01 Thread Stefan Roese
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - No change v2: - Changes are done to the driver in staging before m