Re: [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block

2019-09-02 Thread Gao Xiang
Hi Christoph, On Mon, Sep 02, 2019 at 05:12:34AM -0700, Christoph Hellwig wrote: > > + dsb = (struct erofs_super_block *)((u8 *)bh->b_data + > > + EROFS_SUPER_OFFSET); > > Not new in this patch, but that u8 cast shouldn't be needed. Yes, thanks and will fix

Re: [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block

2019-09-02 Thread Christoph Hellwig
> + dsb = (struct erofs_super_block *)((u8 *)bh->b_data + > +EROFS_SUPER_OFFSET); Not new in this patch, but that u8 cast shouldn't be needed. ___ devel mailing list de...@linuxdriverproject.org http://driverde

[PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block

2019-08-31 Thread Gao Xiang
From: Gao Xiang As Christoph pointed out [1], "Why is the variable name for the on-disk subperblock layout? We usually still calls this something with sb in the name, e.g. dsb. for disksuper block. " Let's fix it. [1] https://lore.kernel.org/r/20190829101545.gc20...@infradead.org/ Signed-off-by: