Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

2018-01-08 Thread Dan Carpenter
> There are counterexamples in the subsystem. Staging is essentially one giant counter example. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

2018-01-08 Thread Joe Perches
On Mon, 2018-01-08 at 22:26 +0300, Dan Carpenter wrote: > On Mon, Jan 08, 2018 at 10:27:01AM -0800, Joe Perches wrote: > > On Mon, 2018-01-08 at 18:03 +0300, Dan Carpenter wrote: > > > On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote: > > > > The Linux kernel coding style states that b

Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

2018-01-08 Thread Dan Carpenter
On Mon, Jan 08, 2018 at 10:27:01AM -0800, Joe Perches wrote: > On Mon, 2018-01-08 at 18:03 +0300, Dan Carpenter wrote: > > On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote: > > > The Linux kernel coding style states that braces should only be used > > > when necessary. > > > > > > Thi

Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

2018-01-08 Thread Joe Perches
On Mon, 2018-01-08 at 18:03 +0300, Dan Carpenter wrote: > On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote: > > The Linux kernel coding style states that braces should only be used > > when necessary. > > > > This fixes the checkpatch warning > > > > WARNING: line over 80 characters

Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

2018-01-08 Thread Dan Carpenter
On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote: > The Linux kernel coding style states that braces should only be used > when necessary. > > This fixes the checkpatch warning > > WARNING: line over 80 characters > + } else if (display->regwidth == 8 && display->buswidth == 9 &&

[PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else

2018-01-08 Thread Luis Gerhorst
The Linux kernel coding style states that braces should only be used when necessary. This fixes the checkpatch warning WARNING: line over 80 characters + } else if (display->regwidth == 8 && display->buswidth == 9 && par->spi) { introduced by patch #1. Signed-off-by: Luis Gerhorst Acked