On 19/10/16 14:11, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote:
>> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
>>> What does illuminance0_ mean? Can we remove that?
>>
>> I left the names of the existing sysfs attributes intact to not brea
On 19 October 2016 11:32:06 BST, Brian Masney wrote:
>Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
>macros to create the device attributes.
>
>Signed-off-by: Brian Masney
Hi Brian,
One very quick comment. Driver should be using an iio_chan_spec array and
relevant
inf
On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote:
> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
> > What does illuminance0_ mean? Can we remove that?
>
> I left the names of the existing sysfs attributes intact to not break
> any existing users of the driver. I'm no
On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
> What does illuminance0_ mean? Can we remove that?
I left the names of the existing sysfs attributes intact to not break
any existing users of the driver. I'm not sure why the original author
named it that way.
Brian
__
On Wed, Oct 19, 2016 at 12:47:13PM +0200, Peter Meerwald-Stadler wrote:
>
> > Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> > macros to create the device attributes.
>
> great that you work on cleaning this up!
>
> the patch does a bit more than is claimed, it also renames
What does illuminance0_ mean? Can we remove that?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> macros to create the device attributes.
great that you work on cleaning this up!
the patch does a bit more than is claimed, it also renames stuff;
eventually, a proper prefix ('tsl2583_') should be used...
maybe you can un
Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
macros to create the device attributes.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 117 ++--
1 file changed, 57 insertions(+), 60 deletions(-)
diff --git a/drivers/stagi
