Re: [PATCH v2] drivers/staging: refactor dgnc tty registration.

2017-05-15 Thread Dan Carpenter
On Mon, May 15, 2017 at 02:48:52PM +0300, Haim Daniel wrote: > +static struct tty_driver *_dgnc_tty_register(char *serial_name, uint > maxports, Ahh... I see why you are adding underscores. Please, just get a better name instead of taking an existing name and adding underscores. regards, dan

[PATCH v2] drivers/staging: refactor dgnc tty registration.

2017-05-15 Thread Haim Daniel
-remove duplicate tty allocation code for serial and printer drivers. -fix sparse warning: too long initializer-string for array of char. Signed-off-by: Haim Daniel --- drivers/staging/dgnc/dgnc_driver.h | 13 drivers/staging/dgnc/dgnc_tty.c| 150 +++--