Re: [PATCH v2] iio: trigger: free trigger resource correctly

2017-01-22 Thread Jonathan Cameron
On 22/01/17 15:56, Lars-Peter Clausen wrote: > On 01/22/2017 03:25 PM, Jonathan Cameron wrote: >> On 20/01/17 03:47, Alison Schofield wrote: >>> These stand-alone trigger drivers were using iio_trigger_put() >>> where they should have been using iio_trigger_free(). The >>> iio_trigger_put() adds a

Re: [PATCH v2] iio: trigger: free trigger resource correctly

2017-01-22 Thread Lars-Peter Clausen
On 01/22/2017 03:25 PM, Jonathan Cameron wrote: > On 20/01/17 03:47, Alison Schofield wrote: >> These stand-alone trigger drivers were using iio_trigger_put() >> where they should have been using iio_trigger_free(). The >> iio_trigger_put() adds a module_put which is bad since they >> never did a

Re: [PATCH v2] iio: trigger: free trigger resource correctly

2017-01-22 Thread Jonathan Cameron
On 20/01/17 03:47, Alison Schofield wrote: > These stand-alone trigger drivers were using iio_trigger_put() > where they should have been using iio_trigger_free(). The > iio_trigger_put() adds a module_put which is bad since they > never did a module_get. > > In the sysfs driver, module_get/put's

[PATCH v2] iio: trigger: free trigger resource correctly

2017-01-19 Thread Alison Schofield
These stand-alone trigger drivers were using iio_trigger_put() where they should have been using iio_trigger_free(). The iio_trigger_put() adds a module_put which is bad since they never did a module_get. In the sysfs driver, module_get/put's are used as triggers are added & removed. This extra m