Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

2017-05-16 Thread Dan Carpenter
On Mon, May 15, 2017 at 04:49:16PM +0300, Haim Daniel wrote: > me@haim-toshiba1 ~ $ dpkg -l sparse > Desired=Unknown/Install/Remove/Purge/Hold > | > Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend > |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) > ||/ Name

Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

2017-05-15 Thread Haim Daniel
me@haim-toshiba1 ~ $ dpkg -l sparse Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==

Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

2017-05-15 Thread Dan Carpenter
On Mon, May 15, 2017 at 03:30:50PM +0300, Haim Daniel wrote: > -remove duplicate tty allocation code for serial and printer drivers. > -fix sparse warning: too long initializer-string for array of char. I think my version of Sparse is too old. I don't get a warning. Please cut and paste the exac

[PATCH v3] drivers/staging: refactor dgnc tty registration.

2017-05-15 Thread Haim Daniel
-remove duplicate tty allocation code for serial and printer drivers. -fix sparse warning: too long initializer-string for array of char. Signed-off-by: Haim Daniel --- drivers/staging/dgnc/dgnc_driver.h | 13 drivers/staging/dgnc/dgnc_tty.c| 150 +++--