Re: [PATCH v3 04/24] staging: ks7010: rename identifier rc to ret

2017-04-12 Thread Dan Carpenter
You should have put some of this into the commit message. If there is something you think is maybe questionable or controversial, put that in the commit so we don't have to find it ourselves. regards, dan carpenter ___ devel mailing list de...@linuxdri

Re: [PATCH v3 04/24] staging: ks7010: rename identifier rc to ret

2017-04-11 Thread Tobin C. Harding
On Tue, Apr 11, 2017 at 04:03:07PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 10, 2017 at 01:15:41PM +1000, Tobin C. Harding wrote: > > Driver uses identifier 'rc' to hold the value for error return > > code. The rest of the driver predominately uses 'ret' for this > > purpose. It is easier to

Re: [PATCH v3 04/24] staging: ks7010: rename identifier rc to ret

2017-04-11 Thread Greg Kroah-Hartman
On Mon, Apr 10, 2017 at 01:15:41PM +1000, Tobin C. Harding wrote: > Driver uses identifier 'rc' to hold the value for error return > code. The rest of the driver predominately uses 'ret' for this > purpose. It is easier to follow the code if one name is used for one > task. > > Rename identifier '

[PATCH v3 04/24] staging: ks7010: rename identifier rc to ret

2017-04-09 Thread Tobin C. Harding
Driver uses identifier 'rc' to hold the value for error return code. The rest of the driver predominately uses 'ret' for this purpose. It is easier to follow the code if one name is used for one task. Rename identifier 'rc' to 'ret'. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks