Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-22 Thread Gaël PORTAY
Philipp, On Mon, Jan 21, 2019 at 12:49:10PM +0100, Philipp Zabel wrote: > Hi, > > On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: > > Disable the SMFC before disabling the IDMA channel, instead of after, > > in csi_idmac_unsetup(). > > > > This fixes a complete system hard lockup on t

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-22 Thread Philipp Zabel
On Mon, 2019-01-21 at 10:46 -0800, Steve Longerbeam wrote: > > On 1/21/19 10:43 AM, Steve Longerbeam wrote: > > > > > > On 1/21/19 3:49 AM, Philipp Zabel wrote: > > > Also ipu_smfc_disable is refcounted, so if the other CSI is capturing > > > simultaneously, this change has no effect. > > > > S

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-21 Thread Steve Longerbeam
On 1/21/19 10:43 AM, Steve Longerbeam wrote: On 1/21/19 3:49 AM, Philipp Zabel wrote: Also ipu_smfc_disable is refcounted, so if the other CSI is capturing simultaneously, this change has no effect. Sigh, you're right. Let me go back to disabling the CSI before the channel, the CSI enabl

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-21 Thread Steve Longerbeam
On 1/21/19 3:49 AM, Philipp Zabel wrote: Hi, On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: Disable the SMFC before disabling the IDMA channel, instead of after, in csi_idmac_unsetup(). This fixes a complete system hard lockup on the SabreAuto when streaming from the ADV7180, by

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-21 Thread Gaël PORTAY
Philipp, On Mon, Jan 21, 2019 at 12:49:10PM +0100, Philipp Zabel wrote: > Hi, > > On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: > > Disable the SMFC before disabling the IDMA channel, instead of after, > > in csi_idmac_unsetup(). > > > > This fixes a complete system hard lockup on t

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-21 Thread Philipp Zabel
Hi, On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: > Disable the SMFC before disabling the IDMA channel, instead of after, > in csi_idmac_unsetup(). > > This fixes a complete system hard lockup on the SabreAuto when streaming > from the ADV7180, by repeatedly sending a stream off imme

[PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

2019-01-18 Thread Steve Longerbeam
Disable the SMFC before disabling the IDMA channel, instead of after, in csi_idmac_unsetup(). This fixes a complete system hard lockup on the SabreAuto when streaming from the ADV7180, by repeatedly sending a stream off immediately followed by stream on: while true; do v4l2-ctl -d4 --stream-mmap