Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2023-05-17 Thread Hongren Zheng
On Wed, Apr 29, 2020 at 01:53:02PM +, Stahl, Manuel wrote: > On Mi, 2020-04-29 at 11:41 +0200, gre...@linuxfoundation.org wrote: > > On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > > > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > > > On Thu, Apr 1

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread Stahl, Manuel
On Mi, 2020-04-29 at 11:41 +0200, gre...@linuxfoundation.org wrote: > On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > > > + * >

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > + * > > > + * Since the driver does not declare any device ids, you must allocate >

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread Stahl, Manuel
On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > + * > > + * Since the driver does not declare any device ids, you must allocate > > + * id and bind the device to the driver yourself. For example: > > +

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-28 Thread gre...@linuxfoundation.org
On Tue, Apr 28, 2020 at 03:47:42PM +, Stahl, Manuel wrote: > > > > > + return err; > > > + } > > > + pci_set_master(pdev); > > > + > > > + dev_info(&pdev->dev, "Legacy IRQ: %i", pdev->irq); > > > > Again, remove, be quiet :) > > Use dev_dbg() or remove completely? If it helps in deb

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-28 Thread Stahl, Manuel
On Di, 2020-04-28 at 15:54 +0200, greg k-h wrote: > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > This device combines the uio_pci_generic driver and the uio_dmem_genirq > > driver since PCI uses a slightly different API for interrupts. > > A fixed number of DMA capable memory r

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-28 Thread gregkh @ linuxfoundation . org
On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > This device combines the uio_pci_generic driver and the uio_dmem_genirq > driver since PCI uses a slightly different API for interrupts. > A fixed number of DMA capable memory regions can be defined using the > module parameter "dmem_s

[PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-16 Thread Manuel Stahl
This device combines the uio_pci_generic driver and the uio_dmem_genirq driver since PCI uses a slightly different API for interrupts. A fixed number of DMA capable memory regions can be defined using the module parameter "dmem_sizes". The memory is not allocated until the uio device file is opened