Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-24 Thread Lukas Wunner
> New helpers take pointers to uuid_{be|le} as parameters. > > When using them on a raw data we don't need to do an ugly dereference and, > in some cases, a type casting. > > Cc: Andrew Morton > Cc: Arnd Bergmann > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Vinod Koul > Cc: Srinivas Pandruvada

Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-24 Thread Andy Shevchenko
On Sun, 2017-04-23 at 20:20 +, Winkler, Tomas wrote: > On Sun, 2017-04-23 at 15:42 +0300, Andy Shevchenko wrote: > > On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas > . > > com> wrote: > > > > New helpers take pointers to uuid_{be|le} as parameters. > > > > > > > > When using them on a raw da

Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-23 Thread Winkler, Tomas
On Sun, 2017-04-23 at 15:42 +0300, Andy Shevchenko wrote: > On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas com> wrote: > > > New helpers take pointers to uuid_{be|le} as parameters. > > > > > > When using them on a raw data we don't need to do an ugly > > > dereference and, > > > in some cases,

Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-23 Thread Andy Shevchenko
On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas wrote: >> New helpers take pointers to uuid_{be|le} as parameters. >> >> When using them on a raw data we don't need to do an ugly dereference and, >> in some cases, a type casting. > I think this going overboard, the _pp types are just enough. I l

RE: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-23 Thread Winkler, Tomas
> New helpers take pointers to uuid_{be|le} as parameters. > > When using them on a raw data we don't need to do an ugly dereference and, > in some cases, a type casting. > > Cc: Andrew Morton > Cc: Arnd Bergmann > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Vinod Koul > Cc: Srinivas Pandruvada