Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-19 Thread Sergio Had
Thank you very much! Sergey On Aug 19, 2024 at 00:55 +0800, FX Coudert , wrote: > Thanks Sergey, > > I have pushed the patch at > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1cfe4a4d0d4447b364815d5e5c889deb2e533669 > > FX

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-18 Thread FX Coudert
Thanks Sergey, I have pushed the patch at https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1cfe4a4d0d4447b364815d5e5c889deb2e533669 FX

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-17 Thread Sergio Had
Hi, If we are good at this point, could someone help with merging it? (I don’t have commit access, of course.) Sergey On Aug 14, 2024 at 21:30 +0800, Sergey Fedorov , wrote: > Thank you, Iain. > I have adjusted a longer line and added an intro sentence before changelog > record. > > > > > On We

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-14 Thread Sergey Fedorov
Thank you, Iain. I have adjusted a longer line and added an intro sentence before changelog record. On Wed, Aug 14, 2024 at 8:24 PM Iain Sandoe wrote: > > > > On 14 Aug 2024, at 13:17, Sergey Fedorov wrote: > > > > > > > > On Wed, Aug 14, 2024 at 8:03 PM FX Coudert wrote: > > > Thank you for

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-14 Thread Iain Sandoe
> On 14 Aug 2024, at 13:17, Sergey Fedorov wrote: > > > > On Wed, Aug 14, 2024 at 8:03 PM FX Coudert wrote: > > Thank you for responding. > > I have added a changelog (is this a correct way?). > > Content seems ok, lines are maybe too long. Check with > contrib/gcc-changelog/git_check_com

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-14 Thread Sergey Fedorov
On Wed, Aug 14, 2024 at 8:03 PM FX Coudert wrote: > > Thank you for responding. > > I have added a changelog (is this a correct way?). > > Content seems ok, lines are maybe too long. Check with > contrib/gcc-changelog/git_check_commit.py before pushing. > Once that is fine, OK to push. > Looks l

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-14 Thread FX Coudert
> Thank you for responding. > I have added a changelog (is this a correct way?). Content seems ok, lines are maybe too long. Check with contrib/gcc-changelog/git_check_commit.py before pushing. Once that is fine, OK to push. FX

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-14 Thread Sergey Fedorov
Thank you for responding. I have added a changelog (is this a correct way?). Sergey On Wed, Aug 14, 2024 at 12:58 AM FX Coudert wrote: > Hi, > > > I dropped a change to the test file, since you have fixed it > appropriately, and switched to Apple libm convention for flags, as you have > suggest

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-13 Thread FX Coudert
Hi, > I dropped a change to the test file, since you have fixed it appropriately, > and switched to Apple libm convention for flags, as you have suggested. > Please let me know if I should do anything further to improve it and make it > acceptable for a merge. The patch itself is OK. Please add

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-13 Thread Sergey Fedorov
On Mon, Aug 5, 2024 at 6:25 PM Sergey Fedorov wrote: > > On Thu, Jul 25, 2024 at 4:47 PM FX Coudert wrote: > >> Can you post an updated version of the patch, following the first round >> of review? >> >> FX > > If you got some time, please review this. I will likely be away from my PowerPC har

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-08-05 Thread Sergey Fedorov
On Thu, Jul 25, 2024 at 4:47 PM FX Coudert wrote: > Can you post an updated version of the patch, following the first round of > review? > > FX Sorry for a delay, done. I dropped a change to the test file, since you have fixed it appropriately, and switched to Apple libm convention for flags,

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-25 Thread FX Coudert
Can you post an updated version of the patch, following the first round of review? FX

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-24 Thread Sergey Fedorov
Bumping the topic. Since this patch exclusively affects powerpc-darwin, and I think we agree that it does not add regressions with tests (no tests which passed without it fail with it), perhaps it can be merged? It would be great to have it in gcc 15 when it is released, otherwise we will need to

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-06 Thread Sergey Fedorov
On Sat, Jul 6, 2024 at 6:07 AM FX Coudert wrote: > > This part of the patch is quite old, but from the remaining log it looks > I got an error here: > > Now on a second thought, this did not require a fix perhaps. We can drop > it. > > I have addressed this: > https://gcc.gnu.org/pipermail/gcc-pa

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-06 Thread Sergey Fedorov
>From f19315cd425d0a23c02ba1be9c24c2a1f82cb47c Mon Sep 17 00:00:00 2001 From: Sergey Fedorov Date: Sat, 29 Apr 2023 14:55:44 +0800 Subject: [PATCH] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic Signed-off-by: Sergey Fedorov --- libgfortran/config/fpu-macppc.h | 414

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-05 Thread FX Coudert
> This part of the patch is quite old, but from the remaining log it looks I > got an error here: > Now on a second thought, this did not require a fix perhaps. We can drop it. I have addressed this: https://gcc.gnu.org/pipermail/gcc-patches/2024-July/656484.html The test should now be run on al

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-04 Thread Sergey Fedorov
On Fri, Jul 5, 2024 at 5:23 AM FX Coudert wrote: > Hi, > The core of the powerpc-FPU manipulation is okay for me. Some comments > below. > Thank you for reviewing! > > --- a/gcc/testsuite/gfortran.dg/ieee/signaling_2_c.c > > +++ b/gcc/testsuite/gfortran.dg/ieee/signaling_2_c.c > > @@ -1,3 +1,1

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-04 Thread FX Coudert
Hi, The core of the powerpc-FPU manipulation is okay for me. Some comments below. > --- a/gcc/testsuite/gfortran.dg/ieee/signaling_2_c.c > +++ b/gcc/testsuite/gfortran.dg/ieee/signaling_2_c.c > @@ -1,3 +1,11 @@ > +#ifdef __POWERPC__ // No support for issignaling in math.h on Darwin PPC Two thin

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-04 Thread Sergey Fedorov
Below is the diff of tests for gfortran on powerpc-apple-darwin10.8.0 without (unmodified gcc upstream) vs with the gfortran patch being added. === gfortran Summary === -# of expected passes69273 -# of unexpected failures36 +# of expected passes69646 +# of unexpected

[PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

2024-07-04 Thread Sergey Fedorov
>From 50fc05566ba7479844949d727233c04a5e8151e8 Mon Sep 17 00:00:00 2001 From: Sergey Fedorov Date: Sat, 29 Apr 2023 14:55:44 +0800 Subject: [PATCH] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic Signed-off-by: Sergey Fedorov --- .../gfortran.dg/ieee/signaling_2_c.c