Re: Possible memory leak in rlm_sql?

2010-12-17 Thread Alan DeKok
Brian Candler wrote: > I noticed something in rlm_sql.c function rlm_sql_process_groups(). > > group_list is allocated at the top of the function, but > sql_grouplist_free(&group_list) is only called at the end. All the various > error exits don't call it. > > ISTM that's going to leak memory in

Possible memory leak in rlm_sql?

2010-12-17 Thread Brian Candler
I noticed something in rlm_sql.c function rlm_sql_process_groups(). group_list is allocated at the top of the function, but sql_grouplist_free(&group_list) is only called at the end. All the various error exits don't call it. ISTM that's going to leak memory in event of errors, but perhaps I hav