[Bug rtl-optimization/54900] write introduction incorrect wrt the C11 memory model (2)

[rguenth at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54900

Richard Biener  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Richard Biener  ---
Fixed.

[Bug rtl-optimization/54900] write introduction incorrect wrt the C11 memory model (2)

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54900

--- Comment #6 from Steven Bosscher  ---
(In reply to Aldy Hernandez from comment #5)
> I am leaving this PR open while I address the corner case presented by Jakub
> somewhere in this thread:
> 
> http://gcc.gnu.org/ml/gcc-patches/2012-10/msg01763.html
> 
> ...though technically the testcase in this PR has been fixed :).

Maybe open a new PR for those corner cases, and put some test cases in
it?  Leaving this open without further reference to an actual problem
is confusing...

[Bug rtl-optimization/54900] write introduction incorrect wrt the C11 memory model (2)

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54900



--- Comment #5 from Aldy Hernandez  2012-10-18 
23:46:04 UTC ---

I am leaving this PR open while I address the corner case presented by Jakub

somewhere in this thread:



http://gcc.gnu.org/ml/gcc-patches/2012-10/msg01763.html



...though technically the testcase in this PR has been fixed :).

[Bug rtl-optimization/54900] write introduction incorrect wrt the C11 memory model (2)

[francesco.zappa.nardelli at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54900



--- Comment #4 from Francesco Zappa Nardelli  2012-10-18 13:39:30 UTC ---

gcc version 4.8.0 20121018 (experimental) - which includes revision 192548 -

compiles this example correctly.  



It also fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54906 .



Great, thanks.

[Bug rtl-optimization/54900] write introduction incorrect wrt the C11 memory model (2)

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54900



--- Comment #3 from Aldy Hernandez  2012-10-17 
20:59:43 UTC ---

Author: aldyh

Date: Wed Oct 17 20:59:40 2012

New Revision: 192548



URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192548

Log:

PR rtl-optimization/54900

* ifcvt.c (noce_can_store_speculate_p): Call

memory_must_be_modified_in_insn_p.

* alias.c (memory_must_be_modified_in_insn_p): New.

(set_dest_equal_p): New.

* rtl.h (memory_must_be_modified_in_p): Protoize.



Modified:

trunk/gcc/ChangeLog

trunk/gcc/alias.c

trunk/gcc/ifcvt.c

trunk/gcc/rtl.h