[Bug target/125100] CONST_VECTOR in REG_EQUAL note isn't checked

2026-06-26 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125100

--- Comment #4 from GCC Commits  ---
The master branch has been updated by H.J. Lu :

https://gcc.gnu.org/g:6452fcd25769cbd0fcd28f83ebd96aa190004b4c

commit r17-1930-g6452fcd25769cbd0fcd28f83ebd96aa190004b4c
Author: H.J. Lu 
Date:   Sat Jun 27 13:34:20 2026 +0800

pr125100-4.c: Adjust check-function-bodies for x32

PR target/125100
* gcc.target/i386/pr125100-4.c: Replace "movq  %rax, \(%rdi\)"
with "movq  %rax, \(%[re]di\)" to support x32.

Signed-off-by: H.J. Lu 

[Bug target/125100] CONST_VECTOR in REG_EQUAL note isn't checked

2026-05-07 Thread hjl.tools at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125100

H.J. Lu  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Target Milestone|--- |17.0
 Status|NEW |RESOLVED

--- Comment #3 from H.J. Lu  ---
Fixed for GCC 17.

[Bug target/125100] CONST_VECTOR in REG_EQUAL note isn't checked

2026-05-07 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125100

--- Comment #2 from GCC Commits  ---
The master branch has been updated by H.J. Lu :

https://gcc.gnu.org/g:12e4a2acda8da558010c9962f96b3167aee21072

commit r17-397-g12e4a2acda8da558010c9962f96b3167aee21072
Author: H.J. Lu 
Date:   Thu Apr 30 09:21:27 2026 +0800

x86_cse: Add X86_CSE_CONST_VECTOR

Add X86_CSE_CONST_VECTOR for native CONST_VECTOR:

(insn 25 23 234 4 (set (reg:V16QI 135)
(const_vector:V16QI [
(const_int -1 [0x]) repeated x16
])) "bar-2.c":10:16 discrim 67584 2453 {movv16qi_internal}
 (nil))

and constant integer load:

(insn 280 8 279 2 (set (subreg:HI (reg:V2QI 172) 0)
(const_int -1 [0x])) -1
 (nil))
...
(insn 110 39 194 9 (set (reg:V2QI 147)
(reg:V2QI 172)) 2089 {*movv2qi_internal}
 (expr_list:REG_EQUAL (const_vector:V2QI [
(const_int -1 [0x]) repeated x2
])
(nil)))

converted from

(insn 111 87 121 18 (set (reg:V2QI 147)
(mem/u/c:V2QI (symbol_ref/u:DI ("*.LC0") [flags 0x2]) [0  S2 A16]))
2089 {*movv2qi_internal}
 (expr_list:REG_EQUAL (const_vector:V2QI [
(const_int -1 [0x]) repeated x2])
(nil)))

1. Use CONST_VECTOR in REG_EQUAL note to avoid DF chain.
2. Keep constant integer load when crossing a function call since it is
faster than save and restore an integer register.
3. Convert CONST_VECTOR load no larger than integer register to constant
integer load even if there is no redundant CONST_VECTOR load.

Tested on Linux/x86-64.

gcc/

PR target/125100
* config/i386/i386-features.cc (x86_cse_kind): Add
X86_CSE_CONST_VECTOR.
(redundant_pattern): Add dest_mode.
(ix86_place_single_vector_set): Handle X86_CSE_CONST_VECTOR.
Generate SUBREG for constant integer source.
(ix86_broadcast_inner): Add an INSN argument.  Use CONST_VECTOR
in REG_EQUAL note.  Set load kind to X86_CSE_CONST_VECTOR for
native and converted CONST_VECTORs.  Return CONST_VECTOR if it
can be converted to constant integer load.
(pass_x86_cse::candidate_vector_p): Add an INSN argument and
pass the insn to ix86_broadcast_inner.
(pass_x86_cse::x86_cse): Add a basic block bitmap for calls.
Pass the insn to candidate_vector_p.  Handle X86_CSE_CONST_VECTOR.
Set dest_mode.  Keep constant integer load when crossing a
function call.  Convert CONST_VECTOR load no larger than integer
register to constant integer load even if there are no redundant
CONST_VECTOR loads.

gcc/testsuite/

PR target/125100
* gcc.target/i386/pr125100-1.c: New test.
* gcc.target/i386/pr125100-2.c: Likewise.
* gcc.target/i386/pr125100-3.c: Likewise.
* gcc.target/i386/pr125100-4.c: Likewise.

Signed-off-by: H.J. Lu 

[Bug target/125100] CONST_VECTOR in REG_EQUAL note isn't checked

2026-04-30 Thread hjl.tools at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125100

H.J. Lu  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Assignee|unassigned at gcc dot gnu.org  |hjl.tools at gmail dot 
com
 Ever confirmed|0   |1
   Last reconfirmed||2026-04-30

--- Comment #1 from H.J. Lu  ---
Created attachment 64329
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=64329&action=edit
A patch