Re: [PATCH] aarch64: Enable Neon search_line_fast

2014-09-02 Thread Richard Henderson
On 09/02/2014 08:51 AM, Ramana Radhakrishnan wrote: > The ADDV instruction isn't available on the AArch32 side IIRC. Given that > situation there is no intrinsic for ADDV on the AArch32 side which is why this > doesn't exist in the AArch32 version of arm_neon.h :( Whoops, yes indeed. I clearly mi

Re: [PATCH] aarch64: Enable Neon search_line_fast

2014-09-02 Thread Ramana Radhakrishnan
On 02/09/14 16:28, Richard Henderson wrote: Is it intentional or not that AArch64 does not define __ARM_NEON__? Yes I remember so, __ARM_NEON__ is not ACLE compatible so we haven't defined it for AArch64 - on AArch32 and AArch64 we now have __ARM_NEON defined so that's the macro to be used.

[PATCH] aarch64: Enable Neon search_line_fast

2014-09-02 Thread Richard Henderson
Is it intentional or not that AArch64 does not define __ARM_NEON__? Otherwise, here's a better way to fold the test bits. AArch64 of course does not have dN+1 overlap the high part of the qM register, like AArch32, so the current l = vpadd_u8 (vget_low_u8 (t), vget_high_u8 (t)); implie