Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Can someone outline the changes that happened and the approaches taken to resolve problems. Did we cleanup any uneeded code or did we just add all licenses for all source deps? On Mon, Jan 14, 2019, 3:43 PM HI, > > >> Justin - Zach's follow up is in this PR into 1.4 branch [1 > >>

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

HI, >> Justin - Zach's follow up is in this PR into 1.4 branch [1 >> ], which includes all >> changes (another PR was already merged to master) Was there any changes to LICENSE that PR doesn’t include any making it hard to review. What was t

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, > Justin - Zach's follow up is in this PR into 1.4 branch [1 > ], which includes all > changes (another PR was already merged to master) If you’ve deal with the CC-SA licensing issue then the other issues were minor and could be fixed in

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Thanks Zach for jumping on this! Justin - Zach's follow up is in this PR into 1.4 branch [1 ], which includes all changes (another PR was already merged to master) Once you confirm changes look good, Steffen can restart the vote process. Cheer

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi Justin, We will replace the file CC-BY-SA documentation file with a pointer then. Because it is a submodule, we can't change it in the code and will just replace it as part of our release process. Per you suggestion, I also added copyright owners to the license file in addition to fixing the v

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, > Hi Justin, it would be great if we can clarify the policy the submodule > dependencies. Basically follow the guiding principle [1] what states anything that is bundled in a release need to be mentioned in LICENSE. If it not in the release then it doesn’t need to be included. Thanks, Jus

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi Justin, it would be great if we can clarify the policy the submodule dependencies. Strictly speaking, these dependencies are in the form of git submodule and they are not part of the commit tree (instead, they are pointers to the specific version of dependency). If we just do git clone, or tag

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

For TensorRT I'd recommend we just remove the third party folder from onnx. I hope this would resolve most dependency license issues. We do not use any of the code in that folder. On Wed, Jan 9, 2019, 9:08 PM Justin Mclean Hi, > > I assume you realise this would be a lot easier if the dependanc

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, I assume you realise this would be a lot easier if the dependancies were not copied into the git tree (as mentioned in the link you posted) , but I assume there a reason for doing this that I’m not aware of. Thanks, Justin

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, > As for your comments: > - 3rdparty/onnx-tensorrt itself has four different git submodules inside it > which is the cause of the number of different licenses. I added the main > license of each repo to our license file. Which probably misses the point I was trying to make I think? It's not t

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi Justin, I went through the license file to remove all licenses that no longer exist and tried to add any missing licenses I could find. I also tried to prune our rat-excludes for files that should be checked such as .js ones. As for your comments: - 3rdparty/onnx-tensorrt itself has four diffe

[CANCELLED][VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Dear community - I'm cancelling the vote due to -1 feedback from Justin due to outstanding licensing issues. For details see https://lists.apache.org/thread.html/ebb8c4c00fb66dd98da13621c7dcb8753fee57562a861d61379d31e9@%3Cgeneral.incubator.apache.org%3E The MXNet community will address the issue

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Thanks for clarifying Justin. On Mon, Jan 7, 2019 at 1:06 AM Justin Mclean wrote: > Hi, > > > Good call. I will work with my colleagues in Amazon to try and help with > > this. > > Great if you need any help just ask. > > > I'm not sure what is the best approach with 3P code issues though: you >

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, > Good call. I will work with my colleagues in Amazon to try and help with > this. Great if you need any help just ask. > I'm not sure what is the best approach with 3P code issues though: you call > out 3rdparty/onnx-tensorrt as having a mix of license types and having > other issues. Howev

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Justin, Good call. I will work with my colleagues in Amazon to try and help with this. I'm not sure what is the best approach with 3P code issues though: you call out 3rdparty/onnx-tensorrt as having a mix of license types and having other issues. However, this is part of another repo, integrated

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, I’m still -1 (binding) there are also some LICENSE issues that need to be looked into. I checked: - incubating in name - signature and hashes good - DISCLAIMER exists - LICENSE and NOTICE need some work (see below) - No unexpected binary files - A number of files are missing headers and it’s

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, -1(binding) I brought up an issue in the 1.2 release and it hasn’t been addressed yet. This release contains plan text CC-BY-2.5 content [1] this is category X. I see that you asked to have the license changed but it is still CC-BY-2.5) and the file is still included in the release. I’ll

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi Gang - thanks for your feedback. I filed https://github.com/apache/incubator-mxnet/issues/13773, please add details on your specific environment and specific build configuration. Dear MXNet mentors and IPMC members - we are still one vote short. Please test the MXNet v1.4.0.rc0 release and prov

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Happy New Year! * Signature verified * SHA verified * Tried to build the distributed source code (rc0) on my machine using following command w/ and w/o -j option. *make -j 6 USE_OPENCV=1 USE_BLAS=openblas USE_CUDA=0* It reports *make[1]: Entering directory '/home/wg/ws/mxnet/apache-mxnet-src-1.4.0

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Happy New Year to all of you! Please review and test Apache MXNet v1.4.0, release candidate 0 and provide your vote. Current status: +1: 1 binding (thanks Jim!) 0:0 -1: 0 The source tarball, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/incubator

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

+1 (binding) > On Dec 28, 2018, at 2:07 PM, Steffen Rochel wrote: > > Dear community, > > This is a call for releasing Apache MXNet (incubating) 1.4.0, release > candidate 0 > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > https://lists.apache.org

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Hi, > The vote will be open until January 3rd noon PST. Votes don’t have a closing date they last a s long as is needed and usually for a minimum of 72 hours. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubat

[VOTE] Release Apache MXNet (incubating) version 1.4.0.rc0

Dear community, This is a call for releasing Apache MXNet (incubating) 1.4.0, release candidate 0 Apache MXNet (incubating) community has voted and approved the release. Vote thread: https://lists.apache.org/thread.html/28f4d4bb62ce10d85b1ef856602b27cb6d8971e4ece6f212411b8ca6@%3Cdev.mxnet.apache