Re: [PATCH v4 00/17] New sparse-checkout builtin and "cone" mode

2019-10-21 Thread Derrick Stolee 
On 10/17/2019 7:53 PM, Jon Simons wrote:
> On 10/15/19 6:55 AM, Derrick Stolee via GitGitGadget wrote:
>> V4 UPDATE: Rebased on latest master to include ew/hashmap and
>> ds/include-exclude in the base.
> 
> I did a partial review of the v4 patches out of curiosity and I notice
> in sparse-checkout.c there are a couple of unchecked `fopen` call sites
> that could be converted to `xfopen` to die gracefully upon error, and
> one unchecked `fdopen` that can likewise be `xfdopen`.

Thanks! Fixed for v5.

-Stolee

Re: [PATCH v4 00/17] New sparse-checkout builtin and "cone" mode

2019-10-17 Thread Jon Simons 

On 10/15/19 6:55 AM, Derrick Stolee via GitGitGadget wrote:

V4 UPDATE: Rebased on latest master to include ew/hashmap and
ds/include-exclude in the base.


I did a partial review of the v4 patches out of curiosity and I notice
in sparse-checkout.c there are a couple of unchecked `fopen` call sites
that could be converted to `xfopen` to die gracefully upon error, and
one unchecked `fdopen` that can likewise be `xfdopen`.


-Jon

Re: [PATCH v4 00/17] New sparse-checkout builtin and "cone" mode

2019-10-16 Thread Elijah Newren 
On Tue, Oct 15, 2019 at 6:56 AM Derrick Stolee via GitGitGadget
 wrote:
> Updates in V4:
>
>  * Updated hashmap API usage to respond to ew/hashmap
>
>
>  * Responded to detailed review by Elijah. Thanks!
>
>
>  * Marked the feature as experimental in git-sparse-checkout.txt the same
>way that git-switch.txt does.

I read through the range-diff, and it all looks good to me other than
one issue I flagged on patch 1.

Nice work!