Re: [PATCH v4 09/17] sparse-checkout: use hashmaps for cone patterns

2019-10-21 Thread Derrick Stolee 
On 10/18/2019 11:31 AM, SZEDER Gábor wrote:
> On Tue, Oct 15, 2019 at 01:55:56PM +, Derrick Stolee via GitGitGadget 
> wrote:
>> Running 'git read-tree -mu HEAD' on this file had the following
>> performance:
>>
>>  core.sparseCheckout=false: 0.21 s (0.00 s)
>>   core.sparseCheckout=true: 3.75 s (3.50 s)
>>   core.sparseCheckout=cone: 0.23 s (0.01 s)
> 
> The previous patch added 'core.sparseCheckoutCone', so this last line
> should be 'core.sparseCheckoutCone=true', shouldn't it?

Good catch! Thanks.

-Stolee

Re: [PATCH v4 09/17] sparse-checkout: use hashmaps for cone patterns

2019-10-18 Thread SZEDER Gábor 
On Tue, Oct 15, 2019 at 01:55:56PM +, Derrick Stolee via GitGitGadget wrote:
> Running 'git read-tree -mu HEAD' on this file had the following
> performance:
> 
>   core.sparseCheckout=false: 0.21 s (0.00 s)
>core.sparseCheckout=true: 3.75 s (3.50 s)
>core.sparseCheckout=cone: 0.23 s (0.01 s)

The previous patch added 'core.sparseCheckoutCone', so this last line
should be 'core.sparseCheckoutCone=true', shouldn't it?