[PR] [SWIFT] Add support for Timestamp data type [arrow]

2025-06-09 Thread via GitHub


mgrazianoc opened a new pull request, #46753:
URL: https://github.com/apache/arrow/pull/46753

   ### Rationale for this change
   
   Currently, the Swift implementation of Arrow does not support Timestamp, 
although they are available in the base C interface. This PR attempts to add 
its support by following the current implemented design pattern.
   
   ### What changes are included in this PR?
   
   1. `TimestampArray` with some basic formatting utilities
   2. `TimestampArrayBuilder`
   3. `Timestamp` alias
   4. `ArrowTimestampUnit`, which includes extensively all the variants 
(seconds, milliseconds, microseconds and nanoseconds)
   5. `ArrowTypeTimestamp` from base `Arrow`
   6. `ArrowNestedType` support for timestamp
   7. `ArrowWriterHelper` support for timestamp
   8. `fromProto` support for timestamp
   
   It properly handles the presence or absence of `timezone`.
   
   ### Are these changes tested?
   
   Tests are included in both `ArrayTests.swift` and `CDataTests.swift`.
   
   ### Are there any user-facing changes?
   
   Yes - users can now work with Timestamp data types in Swift Arrow 
implementations. This is additive and doesn't break existing functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [SWIFT] Add support for Timestamp data type [arrow]

2025-06-09 Thread via GitHub


github-actions[bot] commented on PR #46753:
URL: https://github.com/apache/arrow/pull/46753#issuecomment-2956444148

   
   
   Thanks for opening a pull request!
   
   If this is not a [minor 
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). 
Could you open an issue for this pull request on GitHub? 
https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the 
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
 of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
   GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
   MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
 * [Other pull requests](https://github.com/apache/arrow/pulls/)
 * [Contribution Guidelines - Contributing 
Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org