Re: [PR] Fix CI on main due to logical conflict [arrow-rs]

2025-05-23 Thread via GitHub


alamb merged PR #7542:
URL: https://github.com/apache/arrow-rs/pull/7542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix CI on main due to logical conflict [arrow-rs]

2025-05-23 Thread via GitHub


alamb commented on PR #7542:
URL: https://github.com/apache/arrow-rs/pull/7542#issuecomment-2905702626

   Thank you @tustvold 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fix CI on main due to logical conflict [arrow-rs]

2025-05-23 Thread via GitHub


alamb opened a new pull request, #7542:
URL: https://github.com/apache/arrow-rs/pull/7542

   # Which issue does this PR close?
   
   
   
   Closes #.
   
   # Rationale for this change
   - https://github.com/apache/arrow-rs/pull/7451 had a logical conflict with 
   - https://github.com/apache/arrow-rs/pull/7434
   
   Which results in an error: 
https://github.com/apache/arrow-rs/actions/runs/15216929616/job/42804494443
   
   ```
   error[E0061]: this function takes 4 arguments but 3 arguments were supplied
  --> arrow-avro/src/codec.rs:425:27
   |
   425 | let val = make_data_type(&m.values, namespace, 
resolver)?;
   |   
^^ argument #4 of type `bool` is 
missing
   |
   note: function defined here
  --> arrow-avro/src/codec.rs:334:4
   |
   334 | fn make_data_type<'a>(
   |^^
   ...
   338 | use_utf8view: bool,
   | --
   help: provide the argument
   |
   
4[25](https://github.com/apache/arrow-rs/actions/runs/15216929616/job/42804494443#step:14:26)
 | let val = make_data_type(&m.values, namespace, resolver, /* 
bool */)?;
   |

   ```
   
   
   
   # What changes are included in this PR?
   
   Fix compilation
   
   # Are there any user-facing changes?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org