Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
conbench-apache-arrow[bot] commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2975186633 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 196cde38c112d32a944afe978b6da9c7ce935ef7. There were 122 benchmark results with an error: - Commit Run on `arm64-t4g-2xlarge-linux` at [2025-06-15 21:59:23Z](https://conbench.ursa.dev/compare/runs/c6d836d797954f1e8d014f8ef5c9f2f0...0c30decc03b14bc7bc2f7d58242added/) - [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/benchmark-results/0684f534c0967688800089b9bf4504e2) - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1](https://conbench.ursa.dev/benchmark-results/0684f540203d7d028000e752a0871a05) - and 120 more (see the report linked below) There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/44147022025) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
kou merged PR #46758: URL: https://github.com/apache/arrow/pull/46758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
hiroyuki-sato commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2972199117 @assignUser Thanks. It seems that the PR for 20.0.0 is not merge yet. I will update this PR if this the PR for 20.0 merged before this PR merge. Otherwise, I'll create new one later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
assignUser commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2971509539 There are some additional changes in the PR for 20.0.0: https://github.com/conan-io/conan-center-index/pull/27311 Maybe it makes sense to add them too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
kou commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2965137355 Could you fix lint errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
kou commented on code in PR #46758: URL: https://github.com/apache/arrow/pull/46758#discussion_r2141725511 ## ci/conan/all/conanfile.py: ## @@ -19,6 +19,7 @@ # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE # SOFTWARE. +import os Review Comment: ```suggestion import os ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
hiroyuki-sato commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2965242557 I added `Copyright (c) 2025 Conan.io` as copyright year. Because this file was created Fed/2025 https://github.com/conan-io/conan-center-index/commits/master/recipes/arrow/all/patches/19.0.1-0001-fix-cmake.patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
hiroyuki-sato commented on PR #46758:
URL: https://github.com/apache/arrow/pull/46758#issuecomment-2957468897
```
./merge_upstream.sh /tmp/conan-center-index/
patching file 'all/conandata.yml'
patching file 'all/conanfile.py'
1 out of 10 hunks failed--saving rejects to 'all/conanfile.py.rej'
patching file 'all/patches/19.0.1-0001-fix-cmake.patch'
patching file 'all/patches/19.0.1-0002-fix-downloaded-mimalloc.patch'
patching file 'all/test_package/CMakeLists.txt'
1 out of 1 hunks failed--saving rejects to
'all/test_package/CMakeLists.txt.rej'
patching file config.yml
```
`git diff
a9b270f9d2052e193ce3c0a6c4e2fda0b0ac5ade..1729c3c2c3b0e9d058821fa00e8a54154415efc6
recipes/arrow/`
```diff
diff --git a/recipes/arrow/all/conandata.yml
b/recipes/arrow/all/conandata.yml
index f979a4480..a370e59e0 100644
--- a/recipes/arrow/all/conandata.yml
+++ b/recipes/arrow/all/conandata.yml
@@ -1,4 +1,7 @@
sources:
+ "19.0.1":
+url:
"https://www.apache.org/dyn/closer.lua/arrow/arrow-19.0.1/apache-arrow-19.0.1.tar.gz?action=download";
+sha256:
"acb76266e8b0c2fbb7eb15d542fbb462a73b3fd1e32b80fad6c2fafd95a51160"
"18.1.0":
url:
"https://www.apache.org/dyn/closer.lua/arrow/arrow-18.1.0/apache-arrow-18.1.0.tar.gz?action=download";
sha256:
"2dc8da5f8796afe213ecc5e5aba85bb82d91520eff3cf315784a52d0fa61d7fc"
@@ -18,6 +21,13 @@ sources:
url:
"https://www.apache.org/dyn/closer.lua/arrow/arrow-14.0.2/apache-arrow-14.0.2.tar.gz?action=download";
sha256:
"1304dedb41896008b89fe0738c71a95d9b81752efc77fa70f264cb1da15d9bc2"
patches:
+ "19.0.1":
+- patch_file: "patches/19.0.1-0001-fix-cmake.patch"
+ patch_description: "use cci package"
+ patch_type: "conan"
+- patch_file: "patches/19.0.1-0002-fix-downloaded-mimalloc.patch"
+ patch_description: "use cci package"
+ patch_type: "conan"
"18.1.0":
- patch_file: "patches/18.0.0-0001-fix-cmake.patch"
patch_description: "use cci package"
diff --git a/recipes/arrow/all/conanfile.py b/recipes/arrow/all/conanfile.py
index be8bacf5a..7aef9d284 100644
--- a/recipes/arrow/all/conanfile.py
+++ b/recipes/arrow/all/conanfile.py
@@ -1,3 +1,5 @@
+import os
+
from conan import ConanFile
from conan.errors import ConanInvalidConfiguration, ConanException
from conan.tools.build import check_min_cppstd, cross_building
@@ -6,11 +8,9 @@ from conan.tools.files import apply_conandata_patches,
copy, export_conandata_pa
from conan.tools.microsoft import is_msvc, is_msvc_static_runtime
from conan.tools.scm import Version
-import os
-import glob
-
required_conan_version = ">=2.1.0"
+
class ArrowConan(ConanFile):
name = "arrow"
description = "Apache Arrow is a cross-language development platform
for in-memory data"
@@ -80,7 +80,7 @@ class ArrowConan(ConanFile):
"dataset_modules": False,
"deprecated": True,
"encryption": False,
-"filesystem_layer": False,
+"filesystem_layer": True,
"hdfs_bridgs": False,
"plasma": "deprecated",
"simd_level": "default",
@@ -120,7 +120,7 @@ class ArrowConan(ConanFile):
def _min_cppstd(self):
# arrow >= 10.0.0 requires C++17.
# https://github.com/apache/arrow/pull/13991
-return "11" if Version(self.version) < "10.0.0" else "17"
+return "17"
def export_sources(self):
export_conandata_patches(self)
@@ -129,10 +129,10 @@ class ArrowConan(ConanFile):
def config_options(self):
if self.settings.os == "Windows":
del self.options.fPIC
-if Version(self.version) < "8.0.0":
-del self.options.substrait
if is_msvc(self):
self.options.with_boost = True
+if Version(self.version) >= "19.0.0":
+self.options.with_mimalloc = True
def configure(self):
if self.options.shared:
@@ -187,9 +187,6 @@ class ArrowConan(ConanFile):
self.requires("snappy/1.1.9")
if self.options.get_safe("simd_level") != None or \
self.options.get_safe("runtime_simd_level") != None:
-if Version(self.version) < 8:
-self.requires("xsimd/9.0.1")
-else:
self.requires("xsimd/13.0.0")
if self.options.with_zlib:
self.requires("zlib/[>=1.2.11 <2]")
@@ -231,15 +228,6 @@ class ArrowConan(ConanFile):
if self.settings.compiler.get_safe("cppstd"):
check_min_cppstd(self, self._min_cppstd)
-if (
-Version(self.version) < "10.0.0"
-and self.settings.compiler == "clang"
-and Version(self.settings.compil
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
hiroyuki-sato commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2957501875 @github-actions crossbow submit -g conan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
hiroyuki-sato commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2957527482 @github-actions crossbow submit -g conan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
github-actions[bot] commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2957530211 Revision: e8680a0eae6ce788be5d91de41d52335b223f74d Submitted crossbow builds: [ursacomputing/crossbow @ actions-d6d42a5019](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d6d42a5019) |Task|Status| ||--| |conan-maximum|[](https://github.com/ursacomputing/crossbow/actions/runs/15549377015/job/43776891868)| |conan-minimum|[](https://github.com/ursacomputing/crossbow/actions/runs/15549377147/job/43776892269)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
github-actions[bot] commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2957504416 Revision: ce4e7fb3233eb9537cbbacdb57edfb5f858aed02 Submitted crossbow builds: [ursacomputing/crossbow @ actions-fa68a234cc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fa68a234cc) |Task|Status| ||--| |conan-maximum|[](https://github.com/ursacomputing/crossbow/actions/runs/15549104346/job/43776130975)| |conan-minimum|[](https://github.com/ursacomputing/crossbow/actions/runs/15549104345/job/43776130977)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
github-actions[bot] commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2957468346 :warning: GitHub issue #46757 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]
hiroyuki-sato opened a new pull request, #46758: URL: https://github.com/apache/arrow/pull/46758 ### Rationale for this change Apache Arrow 19.0.1 available in the conan repository. Need synchronize upstream. ### What changes are included in this PR? * execute `ci/conan/merge_upstream.sh` * Resolve merge failed. (Both files contains license headers. So patch failed) * `ci/conan/all/test_package/CMakeLists.txtj` * `ci/conan/all/conanfile.py` ### Are these changes tested? Yes. ### Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
