Re: [PR] Implement proper time fields and conversions for the record API [arrow-rs]

2025-05-26 Thread via GitHub 


alamb commented on code in PR #7544:
URL: https://github.com/apache/arrow-rs/pull/7544#discussion_r2107026222


##
parquet/src/record/api.rs:
##
@@ -602,6 +602,12 @@ pub enum Field {
 /// Date without a time of day, stores the number of days from the
 /// Unix epoch, 1 January 1970.
 Date(i32),
+
+/// The total number of milliseconds since midnight.
+TimeMillis(i32),

Review Comment:
   I think adding these new variants means this is an API change and thus must 
wait for our next breaking release (in July)
   
   - #7395 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

[PR] Implement proper time fields and conversions for the record API [arrow-rs]

2025-05-23 Thread via GitHub 


njaremko opened a new pull request, #7544:
URL: https://github.com/apache/arrow-rs/pull/7544

   # Which issue does this PR close?
   
   Closes #7543
   
   # Rationale for this change

   I recently wrote a PR for https://github.com/apache/arrow-rs/issues/7510 
that was wrong. So this is rectifying that.
   
   # What changes are included in this PR?
   
   I had used TimestampMillis for a time value that does not have a date, which 
is wrong.
   
   I've added two new Fields for the missing concept of "time without date", 
and fixed the conversion to use them, and added the required trait 
implementations
   
   # Are there any user-facing changes?
   
   
   
   
   There are new `Field` variants, so if people are matching `Field`, this'll 
cause a compile error when they upgrade
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]