Re: [PR] Improve email created by create_tarball.sh script [arrow-rs]
alamb merged PR #9944: URL: https://github.com/apache/arrow-rs/pull/9944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve email created by create_tarball.sh script [arrow-rs]
alamb commented on PR #9944: URL: https://github.com/apache/arrow-rs/pull/9944#issuecomment-4612920639 THank you for the review @Jefffrey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve email created by create_tarball.sh script [arrow-rs]
Jefffrey commented on code in PR #9944:
URL: https://github.com/apache/arrow-rs/pull/9944#discussion_r3345140880
##
dev/release/create-tarball.sh:
##
@@ -88,14 +109,17 @@ Subject: [VOTE][RUST] Release Apache Arrow Rust ${version}
RC${rc}
Hi,
-I would like to propose a release of Apache Arrow Rust Implementation, version
${tag}.
+I would like to propose a release of Apache Arrow Rust Implementation, version
${version}.
Review Comment:
i guess we still have the release candidate number in the subject line at
least
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Improve email created by create_tarball.sh script [arrow-rs]
alamb commented on code in PR #9944:
URL: https://github.com/apache/arrow-rs/pull/9944#discussion_r3202400589
##
dev/release/create-tarball.sh:
##
@@ -79,6 +80,26 @@
url="https://dist.apache.org/repos/dist/dev/arrow/${release}-rc${rc}";
echo "Attempting to create ${tarball} from tag ${tag}"
+# create containing the files in git at $tag
Review Comment:
This is just moved before the email template output because previously the
sha 256 value was only computed *after* the email template was blatted out
##
dev/release/create-tarball.sh:
##
@@ -88,14 +109,17 @@ Subject: [VOTE][RUST] Release Apache Arrow Rust ${version}
RC${rc}
Hi,
-I would like to propose a release of Apache Arrow Rust Implementation, version
${tag}.
+I would like to propose a release of Apache Arrow Rust Implementation, version
${version}.
Review Comment:
`tag` is like 56.1.0-rc1
THis reads much easier in my opinoon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Improve email created by create_tarball.sh script [arrow-rs]
alamb opened a new pull request, #9944: URL: https://github.com/apache/arrow-rs/pull/9944 # Which issue does this PR close? # Rationale for this change There are several issues I found with the email template created by the current template: 1. It uses links to tags (rather than git shas) which can potentially be changed 2. It does not include the actual SHA values (only a link to a place to download the sha values) which means in theory it is not clear what exact artifact is being voted on 3. It does not include a link to the issue used to do release coordiation # What changes are included in this PR? Example new output: ``` - To: [email protected] Subject: [VOTE][RUST] Release Apache Arrow Rust 57.3.1 RC1 Hi, I would like to propose a release of Apache Arrow Rust Implementation, version 57.3.1. This release candidate is based on commit: da8975cfacdf8623892a7937dc5c5e6515a05483 [1]. The SHA256 of the release candidate is: 067a4c47c515d57b283f431d426c46c0f48601a2017202a490d2a234e0cd2fb4 The proposed release tarball and signatures are hosted at [2]. The changelog is located at [3]. The release tracking issue is: [4] Please download, verify checksums and signatures, run the unit tests, and vote on the release. There is a script [4] that automates some of the verification. The vote will be open for at least 72 hours. [ ] +1 Release this as Apache Arrow Rust 57.3.1 [ ] +0 [ ] -1 Do not release this as Apache Arrow Rust 57.3.1 because... [1]: https://github.com/apache/arrow-rs/tree/da8975cfacdf8623892a7937dc5c5e6515a05483 [2]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-rs-57.3.1-rc1 [3]: https://github.com/apache/arrow-rs/blob/da8975cfacdf8623892a7937dc5c5e6515a05483/CHANGELOG.md [4]: https://github.com/apache/arrow-rs/blob/master/dev/release/verify-release-candidate.sh [5]: RELEASE_ISSUE ``` # Are these changes tested? I tested this script while creating release candidates for 57.3.1 and 56.2.1 and it worked well - https://github.com/apache/arrow-rs/issues/9858 - https://github.com/apache/arrow-rs/issues/9857 # Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
