Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
eitsupi commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3093694447 @paleolimbot Thanks! Sorry if my understanding is wrong, but isn't that line already included in version 0.19.0 that's already released on CRAN? https://github.com/cran/adbcdrivermanager/blob/b5a149e907d0b57c667eff44dd61241d6bb626f4/src/c/driver_manager/current_arch.h#L71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
paleolimbot commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3092519049 I did the pick ``` In file included from c/driver_manager/adbc_driver_manager.cc:39: c/driver_manager/current_arch.h:71:9: warning: "__MUSL__" redefined 71 | #define __MUSL__ | ^~~~ ``` (i.e., this should probably also check `if defined(__MUSL__)` since it appears to be defined as part of the flags in some places, such as the default flags for building R packages on alpine) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
paleolimbot commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3089478713 I can cherry pick this into a patch no problem! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
eitsupi commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3087535482 @bastistician Due to the amount of effort involved in the Apache release process in general, I think it is unlikely that a patched version will be released for this. In that case, the next release will probably be more than a month away. But @paleolimbot could submit a patched version to CRAN. (I'm not sure how many users want to install adbcdrivermanager from CRAN on musl Linux, so I'm not sure if it's worth the effort. Just ping @paleolimbot) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
bastistician commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3087286054 FWIW, I am now seeing this compilation error in the new CRAN release of package 'adbcdrivermanager' (0.19.0). Checks on Alpine aren't part of the submission checks yet, so this slipped through. A patch version would be nice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
eitsupi commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3044866514 > We could just have a Docker Compose job that builds the source and run it as a nightly test, like we already do to test newest Clang/GCC. Thanks, sounds good. I've opened #3107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
lidavidm commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3044692988 Ignoring the Dev PR check since it's incorrectly reading the `@` in the PR body as trying to ping a user -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
lidavidm merged PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
eitsupi commented on PR #3105: URL: https://github.com/apache/arrow-adbc/pull/3105#issuecomment-3044557122 I had to leave my desk so I didn't fully write down the description, but I did complete it. I am not familiar with the CI of this repository, but I am surprised clang_tidy did not catch this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] fix(c/driver_manager): fix expected `;` for musl arch [arrow-adbc]
eitsupi opened a new pull request, #3105: URL: https://github.com/apache/arrow-adbc/pull/3105 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
