Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
kou commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2960526424 Issue resolved by pull request 46770 https://github.com/apache/arrow/pull/46770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2958326495 I've validated locally that `Cython==3.1.2` fixes the issue for us, no errors: ``` $ archery numpydoc --allow-rule GL10,PR01,PR03,PR04,PR05,PR10,RT03,YD01 INFO:archery:Running Python docstring linters pyarrow.gandiva is not available for import /home/raulcd/code/archery/lib/python3.12/site-packages/numpydoc/docscrape.py:418: UserWarning: Unknown section Example warn(msg) ``` We can potentially force Cython>3.1.1 if we are building docs, I've created a PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
pitrou commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2956105546 Cython 3.1.2 [was released](https://github.com/cython/cython/releases/tag/3.1.2), we should ensure that our CI is really fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2908991630 The Cython issue has been fixed, this should be fixed for Cython 3.1.2 (once is released) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2897040106 I've reported: https://github.com/cython/cython/issues/6904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
pitrou commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2896934740 > Yes, numpydocs expects two line separators (`\n`) between summary and parameters. Time to report a bug for Cython, then :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
pitrou commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2894786704 > This matches with the two different versions of docstring generated on the CPP file (depending on the Cython version used): > > - PyDoc_STRVAR(__pyx_doc_7pyarrow_4_csv_11ReadOptions_6equals, "ReadOptions.equals(self, ReadOptions other)\nParameters\n--\nother : pyarrow.csv.ReadOptions\n\nReturns\n---\nbool"); > + PyDoc_STRVAR(__pyx_doc_7pyarrow_4_csv_11ReadOptions_6equals, "ReadOptions.equals(self, ReadOptions other)\n\nParameters\n --\nother : pyarrow.csv.ReadOptions\n\nReturns\n ---\nbool\n"); The one with stripped whitespace is Cython 3.1.1, right? This is probably because of https://github.com/cython/cython/pull/6241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2894811843 > The one with stripped whitespace is Cython 3.1.1, right? Yes, numpydocs expects two line separators (`\n`) between summary and parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2894697496 After some debugging it seems numpydoc is not correctly generating the parameters from the provided docstring: ``` (Pdb) self.doc['Parameters'] [] (Pdb) self.doc['Summary'] ['ReadOptions.equals(self, ReadOptions other)', 'Parameters', '--', 'other : pyarrow.csv.ReadOptions'] ``` This matches with the two different versions of docstring generated on the CPP file (depending on the Cython version used): ```diff - PyDoc_STRVAR(__pyx_doc_7pyarrow_4_csv_11ReadOptions_6equals, "ReadOptions.equals(self, ReadOptions other)\nParameters\n--\nother : pyarrow.csv.ReadOptions\n\nReturns\n---\nbool"); + PyDoc_STRVAR(__pyx_doc_7pyarrow_4_csv_11ReadOptions_6equals, "ReadOptions.equals(self, ReadOptions other)\n\nParameters\n --\nother : pyarrow.csv.ReadOptions\n\nReturns\n ---\nbool\n"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2894481416 The pdb example should have been this: ``` -> if hasattr(member, '__objclass__'): (Pdb) member (Pdb) name 'equals' (Pdb) hasattr(member, '__objclass__') False `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Archery][CI][Doc] archery numpydoc fails with latest Cython 3.1.1 [arrow]
raulcd commented on issue #46516: URL: https://github.com/apache/arrow/issues/46516#issuecomment-2894442856 @pitrou this seems like a bug on the newest Cython, right? `__objclass__` should be there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
