Re: [I] [C++][Parquet] Fix endianness and test failures on s390x (big-endian) [arrow]
k8ika0s commented on issue #48213: URL: https://github.com/apache/arrow/issues/48213#issuecomment-3572884032 @kou Sounds good Closing this and will continue to provide support in other related PRs/Issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [C++][Parquet] Fix endianness and test failures on s390x (big-endian) [arrow]
kou commented on issue #48213: URL: https://github.com/apache/arrow/issues/48213#issuecomment-3568750269 Thanks. If you find missed changed in the PRs from @Vishwanatha-HD, could you open a separated (smaller) issues/PRs for them? Can we close this in favor of #48151? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [C++][Parquet] Fix endianness and test failures on s390x (big-endian) [arrow]
k8ika0s commented on issue #48213: URL: https://github.com/apache/arrow/issues/48213#issuecomment-3568309154 Thanks, @kou — that makes sense. The big diff in #48212 is mostly because I pulled in fresh upstream commits before adding my endianness work, so it looks a lot noisier than it really is. But I totally get that reviewing a giant PR like that isn’t practical. I’ll start going through the PRs from @Vishwanatha-HD and add technical feedback there, especially around keeping the behavior consistent for canonical little-endian I/O on s390x. If you or the other maintainers eventually want me to break out pieces of my work into smaller, focused PRs, I’m happy to do that — just let me know the direction you prefer and I’ll follow it. Appreciate the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [C++][Parquet] Fix endianness and test failures on s390x (big-endian) [arrow]
kou commented on issue #48213: URL: https://github.com/apache/arrow/issues/48213#issuecomment-3566728048 OK. Could you review PRs from @Vishwanatha-HD instead of https://github.com/apache/arrow/pull/48212 ? #48212 has many unrelated changes. We can't review #48212. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [C++][Parquet] Fix endianness and test failures on s390x (big-endian) [arrow]
k8ika0s commented on issue #48213: URL: https://github.com/apache/arrow/issues/48213#issuecomment-3564965515 I don't know @Vishwanathan-HD. This is my own work, done without any knowledge someone else was about to put up a PR for what I had been working on. Also for context, here is the detailed technical write-up of the s390x issue discovery, testing methodology, and architecture-level design approach: [](https://www.linkedin.com/pulse/apache-arrow-parquet-ibm-s390x-kaitlyn-davis-f7nkc) This PR is the implementation of that research. Even if some parts end up merged separately or differently, I'm happy to collaborate and ensure the final s390x solution is consistent, canonical, and maintainable across the Arrow/Parquet C++ codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [C++][Parquet] Fix endianness and test failures on s390x (big-endian) [arrow]
kou commented on issue #48213: URL: https://github.com/apache/arrow/issues/48213#issuecomment-3564944813 @Vishwanatha-HD created #48151 and sub-issues and opened PRS for them. Is this duplicate of them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
